Skip to content

HDFS-16350. Datanode start time should be set after RPC server starts successfully #3711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2021
Merged

HDFS-16350. Datanode start time should be set after RPC server starts successfully #3711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3886e5
HDFS-16350. Datanode start time should be set after RPC server starts…
virajjasani Nov 23, 2021
776b654
add test
virajjasani Nov 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...fs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ private static Tracer createTracer(Configuration conf) {

private ScheduledThreadPoolExecutor metricsLoggerTimer;

private final long startTime = now();
private long startTime = 0;

/**
* Creates a dummy DataNode for testing purpose.
Expand Down Expand Up @@ -2721,6 +2721,7 @@ public void runDatanodeDaemon() throws IOException {
}
ipcServer.setTracer(tracer);
ipcServer.start();
startTime = now();
startPlugins(getConf());
}

Expand Down
1 change: 1 addition & 0 deletions .../hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMXBean.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ public void testDataNodeMXBean() throws Exception {
Assert.assertEquals(datanode.getVersion(),version);
// get attribute "DNStartedTimeInMillis"
long startTime = (long) mbs.getAttribute(mxbeanName, "DNStartedTimeInMillis");
Assert.assertTrue("Datanode start time should not be 0", startTime > 0);
Assert.assertEquals(datanode.getDNStartedTimeInMillis(), startTime);
// get attribute "SotfwareVersion"
String softwareVersion =
Expand Down