HDFS-16313. Add metrics for each subcluster #3638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goiri
reviewed
Nov 9, 2021
| */ | ||
| @InterfaceAudience.Private | ||
| @InterfaceStability.Evolving | ||
| public interface SubClusterRPCMBean { |
There was a problem hiding this comment.
I am not sure if we are consistent with terminology.
Sometimes we use subcluster at a high level but then throughout the code we refer to it as namespace.
Can you check what is the most consistent terminology throughout?
There was a problem hiding this comment.
Sure. Aligned to use "subcluster".
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
@goiri I got the idea to use "subcluster" because of https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-hdfs-rbf/HDFSRouterFederation.html. I chose subcluster earlier because I thought compared to "FederationRPCMetrics", it might be easier for users to know that we are talking about the metrics of the underlayer of RBF to use "SubclusterRPCMetrics" than "NameserviceRPCMetrics". Both names would be fine to me, I'll make the change after there is an alignment. |
|
💔 -1 overall
This message was automatically generated. |
goiri
approved these changes
Nov 12, 2021
|
|
||
| @Override | ||
| public void proxyOpNoNamenodes() { | ||
| public void proxyOpNoNamenodes(String nameservice) { |
| private MutableCounterLong proxyOpNoNamenodes; | ||
|
|
||
| public NameserviceRPCMetrics(Configuration conf, String name) { | ||
| this.name = name; |
| * @param success If the operation was successful. | ||
| */ | ||
| void proxyOpComplete(boolean success); | ||
| void proxyOpComplete(boolean success, String ns); |
|
💔 -1 overall
This message was automatically generated. |
ferhui
approved these changes
Nov 15, 2021
|
@goiri Do you have any other comments? |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
LiuGuH
pushed a commit
to LiuGuH/hadoop
that referenced
this pull request
Mar 26, 2024
NyteKnight
pushed a commit
to NyteKnight/hadoop
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Currently we have metrics to track the operations for Router to all nameservices, like "FederationRPCMetrics", but we don't have metrics for Router to each nameservices.
This ticket is to add metrics for each nameservice to better track the performance of each sub cluster.
Jira ticket: https://issues.apache.org/jira/browse/HDFS-16313
How was this patch tested?
unit test
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?