HADOOP-17424. Replace HTrace with No-Op tracer #3520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
htrace-core-3.1.0-incubating is bundled as transitive dependency of hadoop-yarn-server-timelineservice-hbase while it does not appear in the regular classpath. |
|
💔 -1 overall
This message was automatically generated. |
steveloughran
requested changes
Oct 8, 2021
There was a problem hiding this comment.
There's a few checkstyles, but I don't want to diverge from what's in trunk. The only changes I'd recommend is purging those unused imports, as they only complicate further backports (especially the .thirdparty guava)
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsTracer.java:20:import org.apache.hadoop.thirdparty.com.google.common.annotations.VisibleForTesting;:8: Unused import - org.apache.hadoop.thirdparty.com.google.common.annotations.VisibleForTesting. [UnusedImports]
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tracing/Tracer.java:25: private static final Tracer globalTracer = null;:31: Name 'globalTracer' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. [ConstantName]
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tracing/Tracer.java:80: static Tracer globalTracer;:19: Variable 'globalTracer' must be private and have accessor methods. [VisibilityModifier]
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tracing/TraceScope.java:23: Span span;:8: Variable 'span' must be private and have accessor methods. [VisibilityModifier]
./hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSPacket.java:304: public void addTraceParent(Span span) {:35: 'span' hides a field. [HiddenField]
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java:35:import org.apache.hadoop.hdfs.protocol.proto.DataTransferProtos.DataTransferTraceInfoProto;:8: Unused import - org.apache.hadoop.hdfs.protocol.proto.DataTransferProtos.DataTransferTraceInfoProto. [UnusedImports]
+1 pending the import tuning
|
💔 -1 overall
This message was automatically generated. |
(cherry picked from commit 1a205cc) Conflicts: hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTracing.java
iwasakims
force-pushed
the
HADOOP-17424-branch-3.3
branch
from
f7d078e to
8ddf763
Compare
|
rebased. |
|
💔 -1 overall
This message was automatically generated. |
|
Test failures are not related to the patch and not reproducible on my local. |
|
I'm merging this based on the +1 of @steveloughran. |
4 tasks
deepakdamri
pushed a commit
to acceldata-io/hadoop
that referenced
this pull request
Jan 21, 2025
(cherry picked from commit 1a205cc) Conflicts: hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTracing.java Co-authored-by: Siyao Meng <[email protected]>
deepakdamri
added a commit
to acceldata-io/hadoop
that referenced
this pull request
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is backport to branch-3.3 of HADOOP-17424.