-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-17612. Upgrade Zookeeper to 3.6.3 and Curator to 5.2.0 #3241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dev-support/Jenkinsfile
Outdated
| options { | ||
| buildDiscarder(logRotator(numToKeepStr: '5')) | ||
| timeout (time: 24, unit: 'HOURS') | ||
| timeout (time: 40, unit: 'HOURS') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just in case full build exceeds 24 hr, I have done this change. Will revert this once we have confidence on QA results.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
This reverts commit 775340b.
|
If Curator 5.2 supports ZooKeeper 3.5.x, I'm +1 to upgrade. |
@aajisaka you mean if (Curator 5.2 + Zookeeper 3.6) are compatible with Zookeeper 3.5 server? As per this doc, Curator 5 does not support ZK 3.4 but it does not mention if Curator 5 is wire compatible with ZK 3.5 servers. Edit: Reg Zookeeper 3.4/3.5/3.6 compatibilities, found this from release doc here: |
in Curator we have integration tests about using ZooKeeper 3.5 client and server on the classpath. https://github.com/apache/curator/tree/master/curator-test-zk35 |
| <artifactId>zookeeper</artifactId> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>io.dropwizard.metrics</groupId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
usually you should also add "snappy-java"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Why did we decide to add io.dropwizard.metrics as part of this PR? Is it related with zk upgrade?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea. They are needed only for the server side part in case you use that metrics provider, that's the default
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Addressed comment by @eolivelli. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @virajjasani and @eolivelli
|
BTW, let's fix the deprecation warnings in a separate jira. |
…#3241) Signed-off-by: Akira Ajisaka <[email protected]>
…#3241) Signed-off-by: Akira Ajisaka <[email protected]>
…#3241) Signed-off-by: Akira Ajisaka <[email protected]>
…#3241) Signed-off-by: Akira Ajisaka <[email protected]>
…#3241) Signed-off-by: Akira Ajisaka <[email protected]>
…o 3.6.3 and Curator to 5.2.0) (#5097) * HADOOP-17612. Upgrade Zookeeper to 3.6.3 and Curator to 5.2.0 (#3241) Signed-off-by: Akira Ajisaka <[email protected]> Co-authored-by: Viraj Jasani <[email protected]> Co-authored-by: Melissa You <[email protected]>
…o 3.6.3 and Curator to 5.2.0) (apache#5097) (apache#24) * HADOOP-17612. Upgrade Zookeeper to 3.6.3 and Curator to 5.2.0 (apache#3241) Signed-off-by: Akira Ajisaka <[email protected]> Co-authored-by: Viraj Jasani <[email protected]> Co-authored-by: Melissa You <[email protected]> Co-authored-by: Viraj Jasani <[email protected]>
No description provided.