-
Couldn't load subscription status.
- Fork 9.1k
HADOOP-17767. ABFS: Updates test scripts #3124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
:::: AGGREGATED TEST RESULT :::: HNS-OAuth----- Test results ----- HNS-SharedKey[INFO] Results: NonHNS-SharedKey[INFO] Results: AppendBlob-HNS-OAuth[INFO] Results: The test failure seen in AppendBlob mode is known and will be addressed in a another lease related PR tracked against: |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
...ls/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/utils/CleanupTestContainers.java
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
|
@snvijaya , Thanks for update. Looks good to me. Just fix the check style warning. |
|
💔 -1 overall
This message was automatically generated. |
|
rebase to/merge in trunk to see if that fixes the build |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not set up to test this yet...but if others say it is good then I'm happy to merge in.
did a superficial review with a few minor suggestions
hadoop-tools/hadoop-azure/dev-support/testrun-scripts/testsupport.sh
Outdated
Show resolved
Hide resolved
hadoop-tools/hadoop-azure/dev-support/testrun-scripts/testsupport.sh
Outdated
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
…ptions added to test script
|
Thanks @steveloughran for the review. Have incorporated the changes. We have used these scripts to automate internal CI runs and tested it. |
|
🎊 +1 overall
This message was automatically generated. |
|
Hi @steveloughran, @surendralilhore , Have addressed all review comments. Latest yetus is successful as well. Kindly request help to commit the change. Thanks for your time in reviewing the change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
@snvijaya merged to trunk; cherrypick in to branch-3.3, test it and push up a new pr and i will merge that. thanks |
Contributed by Sneha Vijayarajan
Contributed by Sneha Vijayarajan
Backport HADOOP-17767. ABFS: Updates test scripts apache#3124
Contributed by Sneha Vijayarajan
Current test run scripts need manual update across all combinations in runTests.sh for account name and is working off a single azure-auth-keys.xml file. While having to test across accounts that span various geo, the config file grows big and also needs a manual change for configs such as fs.contract.test.[abfs/abfss] which has to be uniquely set. To use the script across various combinations, dev to be aware of the names of all the combinations defined in runTests.sh as well.
This PR updates the test scripts to address above concerns. An option to delete old test containers on the account is also added. Sample run output: