Skip to content

HADOOP-17711. Fix divide by zero in LoadBalancingKMSClientProvider. #3048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
+8 −6
Open

HADOOP-17711. Fix divide by zero in LoadBalancingKMSClientProvider. #3048

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f554b83
Fix divide by zero in LoadBalancingKMSClientProvider
yiyuaner May 25, 2021
ddb8f39
Check length of providers in the constructor
yiyuaner May 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions ...common/src/main/java/org/apache/hadoop/crypto/key/kms/LoadBalancingKMSClientProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,19 +86,24 @@ public WrapperException(Throwable cause) {
private RetryPolicy retryPolicy = null;

public LoadBalancingKMSClientProvider(URI providerUri,
KMSClientProvider[] providers, Configuration conf) {
KMSClientProvider[] providers, Configuration conf) throws IOException {
this(providerUri, providers, Time.monotonicNow(), conf);
}

@VisibleForTesting
LoadBalancingKMSClientProvider(KMSClientProvider[] providers, long seed,
Configuration conf) {
Configuration conf) throws IOException {
this(URI.create("kms://testing"), providers, seed, conf);
}

private LoadBalancingKMSClientProvider(URI uri,
KMSClientProvider[] providers, long seed, Configuration conf) {
KMSClientProvider[] providers, long seed, Configuration conf) throws IOException {
super(conf);

if (providers.length == 0) {
throw new IOException("No providers configured !");
}

// uri is the token service so it can be instantiated for renew/cancel.
dtService = KMSClientProvider.getDtService(uri);
// if provider not in conf, new client will alias on uri else addr.
Expand Down Expand Up @@ -165,9 +170,6 @@ public KMSClientProvider[] getProviders() {

private <T> T doOp(ProviderCallable<T> op, int currPos,
boolean isIdempotent) throws IOException {
if (providers.length == 0) {
throw new IOException("No providers configured !");
}
int numFailovers = 0;
for (int i = 0;; i++, numFailovers++) {
KMSClientProvider provider = providers[(currPos + i) % providers.length];
Expand Down