Skip to content

HADOOP-17715 ABFS: Append blob tests with non HNS accounts fail #3028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 9, 2021
Merged

HADOOP-17715 ABFS: Append blob tests with non HNS accounts fail #3028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b3c9db
Setting appendblob enabled to false for NonHNS combination
snehavarma May 20, 2021
0dfa5f3
Incorporating the comments
snehavarma May 21, 2021
b403f01
Merge branch 'apache:trunk' into HADOOP-17715
snehavarma May 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions hadoop-tools/hadoop-azure/dev-support/testrun-scripts/runtests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ set -eo pipefail
begin

### ADD THE TEST COMBINATIONS BELOW. DO NOT EDIT THE ABOVE LINES.
### THE SCRIPT REQUIRES THE FOLLOWING UTILITIES xmlstarlet AND pcregrep.


combination=HNS-OAuth
Expand All @@ -34,6 +35,12 @@ properties=("fs.azure.abfs.account.name" "fs.azure.test.namespace.enabled"
values=("{account name}.dfs.core.windows.net" "true" "OAuth")
generateconfigs

combination=AppendBlob-HNS-OAuth
properties=("fs.azure.abfs.account.name" "fs.azure.test.namespace.enabled"
"fs.azure.account.auth.type" "fs.azure.test.appendblob.enabled")
values=("{account name}.dfs.core.windows.net" "true" "OAuth" "true")
generateconfigs

combination=HNS-SharedKey
properties=("fs.azure.abfs.account.name" "fs.azure.test.namespace.enabled" "fs.azure.account.auth.type")
values=("{account name}.dfs.core.windows.net" "true" "SharedKey")
Expand Down
3 changes: 2 additions & 1 deletion hadoop-tools/hadoop-azure/src/test/resources/azure-auth-keys.xml.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,8 @@ create the test FS instance.
<value>false</value>
<description>If made true, tests will be running under the assumption that
append blob is enabled and the root directory and contract test root
directory will be part of the append blob directories.
directory will be part of the append blob directories. Should be false for
non-HNS accounts.
</description>
</property>

Expand Down