YARN-10476. Queue metrics for Unmanaged applications #2674

cyrus-jackson · 2021-02-02T13:19:40Z

This PR aims to provide metrics for unmanaged applications.

cyrus-jackson · 2021-02-02T15:17:43Z

@bibinchundatt Can you please review this patch.

hadoop-yetus · 2021-02-02T16:19:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 11s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚		0m 0s	test4tests	The patch appears to include 9 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	33m 3s		trunk passed
+1 💚	compile	0m 59s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	compile	0m 51s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚	checkstyle	1m 11s		trunk passed
+1 💚	mvnsite	0m 57s		trunk passed
+1 💚	shadedclient	15m 20s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 45s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	0m 41s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+0 🆗	spotbugs	1m 49s		Used deprecated FindBugs config; considering switching to SpotBugs.
-1 ❌	findbugs	1m 47s	/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-warnings.html	hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager in trunk has 1 extant findbugs warnings.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 49s		the patch passed
+1 💚	compile	0m 51s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javac	0m 51s		the patch passed
+1 💚	compile	0m 44s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚	javac	0m 44s		the patch passed
-0 ⚠️	checkstyle	1m 4s	/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt	hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 3 new + 991 unchanged - 4 fixed = 994 total (was 995)
+1 💚	mvnsite	0m 48s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	12m 56s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 38s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	0m 38s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚	findbugs	1m 48s		the patch passed
			_ Other Tests _
+1 💚	unit	100m 14s		hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚	asflicense	0m 35s		The patch does not generate ASF License warnings.
		179m 12s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2674/1/artifact/out/Dockerfile
GITHUB PR	#2674
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 3be017f3c5a2 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `18978f2`
Default Java	Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2674/1/testReport/
Max. process+thread count	845 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2674/1/console
versions	git=2.25.1 maven=3.6.3 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2021-02-02T22:18:26Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	5m 48s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚		0m 0s	test4tests	The patch appears to include 9 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	41m 56s		trunk passed
+1 💚	compile	0m 58s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	compile	0m 50s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚	checkstyle	1m 1s		trunk passed
+1 💚	mvnsite	0m 54s		trunk passed
+1 💚	shadedclient	17m 55s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 41s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	0m 39s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+0 🆗	spotbugs	1m 53s		Used deprecated FindBugs config; considering switching to SpotBugs.
-1 ❌	findbugs	1m 51s	/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-warnings.html	hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager in trunk has 1 extant findbugs warnings.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 49s		the patch passed
+1 💚	compile	0m 53s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javac	0m 53s		the patch passed
+1 💚	compile	0m 44s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚	javac	0m 44s		the patch passed
+1 💚	checkstyle	0m 55s		hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 993 unchanged - 4 fixed = 993 total (was 997)
+1 💚	mvnsite	0m 49s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	14m 59s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 36s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	0m 34s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚	findbugs	1m 51s		the patch passed
			_ Other Tests _
+1 💚	unit	97m 32s		hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚	asflicense	0m 28s		The patch does not generate ASF License warnings.
		193m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2674/2/artifact/out/Dockerfile
GITHUB PR	#2674
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux d9a62b8d23f1 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `f37bf65`
Default Java	Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2674/2/testReport/
Max. process+thread count	824 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2674/2/console
versions	git=2.25.1 maven=3.6.3 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

...java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java

hadoop-yetus · 2021-02-17T20:21:41Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	21m 52s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚		0m 0s	test4tests	The patch appears to include 9 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	32m 8s		trunk passed
+1 💚	compile	1m 0s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	0m 54s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	1m 10s		trunk passed
+1 💚	mvnsite	0m 58s		trunk passed
+1 💚	shadedclient	15m 19s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 44s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	0m 42s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+0 🆗	spotbugs	18m 36s		Both FindBugs and SpotBugs are enabled, using SpotBugs.
+1 💚	spotbugs	1m 50s		trunk passed
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 50s		the patch passed
+1 💚	compile	0m 53s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	0m 53s		the patch passed
+1 💚	compile	0m 44s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	0m 44s		the patch passed
-0 ⚠️	checkstyle	1m 4s	/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt	hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 2 new + 991 unchanged - 4 fixed = 993 total (was 995)
+1 💚	mvnsite	0m 49s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	12m 57s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 41s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	0m 37s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
-1 ❌	spotbugs	1m 44s	/patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt	hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager cannot run computeBugHistory from spotbugs
			_ Other Tests _
+1 💚	unit	98m 47s		hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚	asflicense	0m 33s		The patch does not generate ASF License warnings.
		197m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2674/3/artifact/out/Dockerfile
GITHUB PR	#2674
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle
uname	Linux f52aee3bfa14 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `0ed9e36`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2674/3/testReport/
Max. process+thread count	899 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2674/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

bibinchundatt · 2021-02-18T11:38:08Z

+1 LGTM , @cyrus-jackson please to take care of the checkstyle too

hadoop-yetus · 2021-02-18T15:56:41Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 40s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚		0m 0s	test4tests	The patch appears to include 9 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	35m 54s		trunk passed
+1 💚	compile	1m 38s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	1m 5s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	1m 14s		trunk passed
+1 💚	mvnsite	1m 1s		trunk passed
+1 💚	shadedclient	19m 40s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 52s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	0m 49s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+0 🆗	spotbugs	23m 49s		Both FindBugs and SpotBugs are enabled, using SpotBugs.
+1 💚	spotbugs	2m 28s		trunk passed
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 2s		the patch passed
+1 💚	compile	1m 14s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	1m 14s		the patch passed
+1 💚	compile	1m 0s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	1m 0s		the patch passed
+1 💚	checkstyle	1m 5s		hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 993 unchanged - 4 fixed = 993 total (was 997)
+1 💚	mvnsite	1m 4s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	19m 7s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 53s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	0m 48s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
-1 ❌	spotbugs	2m 38s	/patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt	hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager cannot run computeBugHistory from spotbugs
			_ Other Tests _
-1 ❌	unit	113m 22s	/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt	hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚	asflicense	0m 35s		The patch does not generate ASF License warnings.
		210m 45s

Reason	Tests
Failed junit tests	hadoop.yarn.server.resourcemanager.recovery.TestLeveldbRMStateStore

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2674/4/artifact/out/Dockerfile
GITHUB PR	#2674
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle
uname	Linux 17b254a9e3a5 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `e391844`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2674/4/testReport/
Max. process+thread count	832 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2674/4/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

…ontributed by Cyrus Jackson

Adds Unmanaged Metrics

334a4af

Fix checkstyle errors

f7f6925

bibinchundatt requested a review from szilard-nemeth February 16, 2021 11:16

bibinchundatt reviewed Feb 16, 2021

View reviewed changes

...java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java Outdated Show resolved Hide resolved

Change varable name to unamangedAM

2136343

bibinchundatt self-requested a review February 18, 2021 11:38

bibinchundatt approved these changes Feb 18, 2021

View reviewed changes

Fix checkstyle

15b028b

Cyrus added 2 commits February 22, 2021 16:33

Trigger Build

1d2b1c8

Merge branch 'trunk' into YARN-10476

2726cb0

bibinchundatt merged commit cd44e91 into apache:trunk Mar 19, 2021

kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021

YARN-10476. Queue metrics for Unmanaged applications (apache#2674). C…

7ce6f1c

…ontributed by Cyrus Jackson

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

YARN-10476. Queue metrics for Unmanaged applications #2674

YARN-10476. Queue metrics for Unmanaged applications #2674

Uh oh!

cyrus-jackson commented Feb 2, 2021

Uh oh!

cyrus-jackson commented Feb 2, 2021

Uh oh!

hadoop-yetus commented Feb 2, 2021

Uh oh!

hadoop-yetus commented Feb 2, 2021

Uh oh!

Uh oh!

hadoop-yetus commented Feb 17, 2021

Uh oh!

bibinchundatt commented Feb 18, 2021

Uh oh!

hadoop-yetus commented Feb 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

YARN-10476. Queue metrics for Unmanaged applications #2674

YARN-10476. Queue metrics for Unmanaged applications #2674

Uh oh!

Conversation

cyrus-jackson commented Feb 2, 2021

Uh oh!

cyrus-jackson commented Feb 2, 2021

Uh oh!

hadoop-yetus commented Feb 2, 2021

Uh oh!

hadoop-yetus commented Feb 2, 2021

Uh oh!

Uh oh!

hadoop-yetus commented Feb 17, 2021

Uh oh!

bibinchundatt commented Feb 18, 2021

Uh oh!

hadoop-yetus commented Feb 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants