HADOOP-17497. refactoring the signature of S3ClientFactory breaks hboss compile. #2654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveloughran
force-pushed
the
s3/HADOOP-17497-s3clientfactory
branch
from
3aa213f to
1383544
Compare
|
oops, left off the final line of the javadocs. Fixing up. Testing in progress |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Full test run completed; only tests were the usual intermittent network buffering in unbuffer issues which is an artifact of my network setup |
There was a problem hiding this comment.
Builds will compile now but tests will still fail right?
There was a problem hiding this comment.
no, we do tricks with handoff. the HBoss code should get its own class invoked because it subclasses this one; it's the new method (with stats coming) in which isn't called.
And for S3A itself, because our clients do implement the method -this one never gets invoked
There was a problem hiding this comment.
nit: doc seems a bit off. Please review.
|
💔 -1 overall
This message was automatically generated. |
…ss compile. Change the S3ClientFactory to restore/invoke the previous method, if the new one has not been invoked. Change-Id: I858d62fb34b8d4b4d0f864f33ee809357299d8c1
Change-Id: If8d83fbd98411f0b66996077e68efdefe658d2e4
steveloughran
force-pushed
the
s3/HADOOP-17497-s3clientfactory
branch
from
ffc7ace to
7c61984
Compare
|
I'm going to abandon this patch as #2778 supercedes it -all new client creation params will be passed in a parameter class down to the client, so that the signature of the methods doesn't change if/when new options are passed in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the S3ClientFactory to restore/invoke the previous method,
if the new one has not been invoked.
Change-Id: I858d62fb34b8d4b4d0f864f33ee809357299d8c1
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute