Skip to content

HADOOP-17424. Replace HTrace with No-Op tracer #2632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

HADOOP-17424. Replace HTrace with No-Op tracer #2632

wants to merge 5 commits into from

Conversation

@smengcl
Copy link
Contributor

@smengcl smengcl commented Jan 20, 2021 •
edited
Loading

https://issues.apache.org/jira/browse/HADOOP-17424

TODO

  • Rebase HADOOP-15566. Support Opentracing #1846 to latest trunk
  • Remove OpenTracing related part to make this patch No-Op tracer only - remove HTrace dependencies, goal is to eliminate HTrace binaries from the dist build

@smengcl
HADOOP-17424. Replace HTrace with No-Op tracer
4da50bd 
Change-Id: I6eda18bd98614e716e045c618e58273b339d7324
@smengcl smengcl self-assigned this Jan 20, 2021
@hadoop-yetus

This comment has been minimized.

Sign in to view
@smengcl
Fix hadoop-thirdparty-jaeger.version.
8a27674 
Change-Id: I0bf779ac4220d944f86751ddd06d5fb69c341b6a
@smengcl
Undo the OpenTracing impls but keep the no-op tracer.
7115681 
Change-Id: I5d0efd644660e4e4de432aa2800d6de55c491356
@hadoop-yetus

This comment has been minimized.

Sign in to view
@smengcl
Fix TraceScope NPE.
83bd41b 
Change-Id: I1c9c0a02ed0752a40e32f9e9519b48e7ca046102
@smengcl smengcl marked this pull request as ready for review January 21, 2021 19:29
@smengcl smengcl requested a review from jojochuang January 21, 2021 19:31
@swagle swagle requested a review from sodonnel January 21, 2021 19:37
@smengcl
Clean up dead code.
3ba5496 
Change-Id: Ic3b9258abecc3372ed13afbf627a578e9894d857
@smengcl
Copy link
Contributor Author

smengcl commented Jan 21, 2021 •
edited
Loading

Not sure why shadedclient still complains that I calls into jaegertracing while I have clearly removed it.

[INFO] Running org.apache.hadoop.example.ITUseMiniCluster
[ERROR] Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 2.605 s <<< FAILURE! - in org.apache.hadoop.example.ITUseMiniCluster
[ERROR] useWebHDFS(org.apache.hadoop.example.ITUseMiniCluster)  Time elapsed: 2.305 s  <<< ERROR!
java.util.ServiceConfigurationError: org.apache.hadoop.shaded.io.jaegertracing.spi.SenderFactory: Provider org.apache.hadoop.shaded.io.jaegertracing.thrift.internal.senders.ThriftSenderFactory not found
	at java.util.ServiceLoader.fail(ServiceLoader.java:239)
	at java.util.ServiceLoader.access$300(ServiceLoader.java:185)
	at java.util.ServiceLoader$LazyIterator.nextService(ServiceLoader.java:372)
	at java.util.ServiceLoader$LazyIterator.next(ServiceLoader.java:404)
	at java.util.ServiceLoader$1.next(ServiceLoader.java:480)
	at org.apache.hadoop.shaded.io.jaegertracing.internal.senders.SenderResolver.resolve(SenderResolver.java:60)
	at org.apache.hadoop.shaded.io.jaegertracing.Configuration$SenderConfiguration.getSender(Configuration.java:657)
	at org.apache.hadoop.shaded.io.jaegertracing.Configuration$ReporterConfiguration.getReporter(Configuration.java:547)
	at org.apache.hadoop.shaded.io.jaegertracing.Configuration$ReporterConfiguration.access$000(Configuration.java:507)
	at org.apache.hadoop.shaded.io.jaegertracing.Configuration.getTracerBuilder(Configuration.java:222)
	at org.apache.hadoop.tracing.TraceUtils.createAndRegisterTracer(TraceUtils.java:105)
	at org.apache.hadoop.tracing.Tracer$Builder.build(Tracer.java:106)

Ran the shadedclient check locally (after recompiling) and got a successful run. Will wait for the next yetus run.

mvn --batch-mode verify -fae --batch-mode -am -pl hadoop-client-modules/hadoop-client-check-invariants -pl hadoop-client-modules/hadoop-client-check-test-invariants -pl hadoop-client-modules/hadoop-client-integration-tests -Dtest=NoUnitTests -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true

@apache apache deleted a comment from hadoop-yetus Jan 21, 2021
@smengcl
Copy link
Contributor Author

smengcl commented Jan 21, 2021 •
edited
Loading

Pending latest CI: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2632/5/

I've deleted one of the yetus run result post in this PR by mistake (meant to collapse it, oops). It should still be visible under the jira's work log.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 buf 0m 1s buf was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 0m 0s test4tests The patch appears to include 8 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 14m 5s Maven dependency ordering for branch
+1 💚 mvninstall 21m 9s trunk passed
+1 💚 compile 20m 19s trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 compile 17m 34s trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 checkstyle 3m 15s trunk passed
+1 💚 mvnsite 8m 3s trunk passed
+1 💚 shadedclient 27m 34s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 6m 43s trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javadoc 7m 42s trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+0 🆗 spotbugs 0m 37s Used deprecated FindBugs config; considering switching to SpotBugs.
+0 🆗 findbugs 0m 37s branch/hadoop-project no findbugs output file (findbugsXml.xml)
+0 🆗 findbugs 0m 40s branch/hadoop-client-modules/hadoop-client-api no findbugs output file (findbugsXml.xml)
+0 🆗 findbugs 0m 38s branch/hadoop-client-modules/hadoop-client-runtime no findbugs output file (findbugsXml.xml)
+0 🆗 findbugs 0m 39s branch/hadoop-client-modules/hadoop-client-check-invariants no findbugs output file (findbugsXml.xml)
+0 🆗 findbugs 0m 38s branch/hadoop-client-modules/hadoop-client-minicluster no findbugs output file (findbugsXml.xml)
+0 🆗 findbugs 0m 37s branch/hadoop-client-modules/hadoop-client-check-test-invariants no findbugs output file (findbugsXml.xml)
_ Patch Compile Tests _
+0 🆗 mvndep 0m 30s Maven dependency ordering for patch
-1 ❌ mvninstall 0m 28s /patch-mvninstall-hadoop-common-project_hadoop-common.txt hadoop-common in the patch failed.
-1 ❌ mvninstall 0m 22s /patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-client.txt hadoop-hdfs-client in the patch failed.
-1 ❌ mvninstall 0m 25s /patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch failed.
-1 ❌ mvninstall 0m 14s /patch-mvninstall-hadoop-client-modules_hadoop-client-check-test-invariants.txt hadoop-client-check-test-invariants in the patch failed.
-1 ❌ compile 0m 58s /patch-compile-root-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.txt root in the patch failed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.
-1 ❌ cc 0m 58s /patch-compile-root-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.txt root in the patch failed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.
-1 ❌ javac 0m 58s /patch-compile-root-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.txt root in the patch failed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.
-1 ❌ compile 0m 55s /patch-compile-root-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt root in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.
-1 ❌ cc 0m 55s /patch-compile-root-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt root in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.
-1 ❌ javac 0m 55s /patch-compile-root-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt root in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.
-0 ⚠️ checkstyle 2m 49s /diff-checkstyle-root.txt root: The patch generated 21 new + 1319 unchanged - 39 fixed = 1340 total (was 1358)
-1 ❌ mvnsite 0m 34s /patch-mvnsite-hadoop-common-project_hadoop-common.txt hadoop-common in the patch failed.
-1 ❌ mvnsite 0m 24s /patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-client.txt hadoop-hdfs-client in the patch failed.
-1 ❌ mvnsite 0m 27s /patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch failed.
-1 ❌ mvnsite 0m 16s /patch-mvnsite-hadoop-client-modules_hadoop-client-check-test-invariants.txt hadoop-client-check-test-invariants in the patch failed.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 10s The patch has no ill-formed XML file.
-1 ❌ shadedclient 0m 55s patch has errors when building and testing our client artifacts.
-1 ❌ javadoc 0m 25s /patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.txt hadoop-common in the patch failed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.
-1 ❌ javadoc 0m 30s /patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.txt hadoop-hdfs-client in the patch failed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.
-1 ❌ javadoc 0m 29s /patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.txt hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.
-1 ❌ javadoc 0m 15s /patch-javadoc-hadoop-client-modules_hadoop-client-check-test-invariants-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.txt hadoop-client-check-test-invariants in the patch failed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.
-1 ❌ javadoc 1m 18s /diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu118.04-b01 with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu118.04-b01 generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)
-1 ❌ javadoc 0m 24s /patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt hadoop-hdfs-client in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.
-1 ❌ javadoc 0m 27s /patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.
-1 ❌ javadoc 0m 16s /patch-javadoc-hadoop-client-modules_hadoop-client-check-test-invariants-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt hadoop-client-check-test-invariants in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.
+0 🆗 findbugs 0m 15s hadoop-project has no data from findbugs
-1 ❌ findbugs 0m 31s /patch-findbugs-hadoop-common-project_hadoop-common.txt hadoop-common in the patch failed.
-1 ❌ findbugs 0m 23s /patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.txt hadoop-hdfs-client in the patch failed.
-1 ❌ findbugs 0m 26s /patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch failed.
+0 🆗 findbugs 0m 17s hadoop-client-modules/hadoop-client-api has no data from findbugs
+0 🆗 findbugs 0m 16s hadoop-client-modules/hadoop-client-runtime has no data from findbugs
+0 🆗 findbugs 0m 16s hadoop-client-modules/hadoop-client-check-invariants has no data from findbugs
+0 🆗 findbugs 0m 17s hadoop-client-modules/hadoop-client-minicluster has no data from findbugs
-1 ❌ findbugs 0m 15s /patch-findbugs-hadoop-client-modules_hadoop-client-check-test-invariants.txt hadoop-client-check-test-invariants in the patch failed.
_ Other Tests _
+1 💚 unit 0m 15s hadoop-project in the patch passed.
-1 ❌ unit 0m 31s /patch-unit-hadoop-common-project_hadoop-common.txt hadoop-common in the patch failed.
-1 ❌ unit 0m 23s /patch-unit-hadoop-hdfs-project_hadoop-hdfs-client.txt hadoop-hdfs-client in the patch failed.
-1 ❌ unit 0m 25s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch failed.
+1 💚 unit 0m 15s hadoop-client-api in the patch passed.
+1 💚 unit 0m 15s hadoop-client-runtime in the patch passed.
+1 💚 unit 0m 15s hadoop-client-check-invariants in the patch passed.
+1 💚 unit 0m 15s hadoop-client-minicluster in the patch passed.
-1 ❌ unit 0m 15s /patch-unit-hadoop-client-modules_hadoop-client-check-test-invariants.txt hadoop-client-check-test-invariants in the patch failed.
+1 💚 asflicense 0m 27s The patch does not generate ASF License warnings.
163m 45s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2632/4/artifact/out/Dockerfile
GITHUB PR #2632
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle cc buflint bufcompat
uname Linux 1abd6e81ad7b 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / e2f8503
Default Java Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2632/4/testReport/
Max. process+thread count 747 (vs. ulimit of 5500)
modules C: hadoop-project hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-client-modules/hadoop-client-api hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-check-invariants hadoop-client-modules/hadoop-client-minicluster hadoop-client-modules/hadoop-client-check-test-invariants U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2632/4/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 34m 47s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 buf 0m 1s buf was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 0m 0s test4tests The patch appears to include 8 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 14m 7s Maven dependency ordering for branch
+1 💚 mvninstall 28m 24s trunk passed
+1 💚 compile 27m 47s trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
-1 ❌ compile 25m 25s /branch-compile-root-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt root in trunk failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.
-0 ⚠️ checkstyle 0m 35s /buildtool-branch-checkstyle-root.txt The patch fails to run checkstyle in root
-1 ❌ mvnsite 0m 38s /branch-mvnsite-hadoop-project.txt hadoop-project in trunk failed.
-1 ❌ mvnsite 0m 37s /branch-mvnsite-hadoop-common-project_hadoop-common.txt hadoop-common in trunk failed.
-1 ❌ mvnsite 0m 41s /branch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-client.txt hadoop-hdfs-client in trunk failed.
-1 ❌ mvnsite 0m 39s /branch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in trunk failed.
-1 ❌ mvnsite 0m 36s /branch-mvnsite-hadoop-client-modules_hadoop-client-api.txt hadoop-client-api in trunk failed.
-1 ❌ mvnsite 0m 39s /branch-mvnsite-hadoop-client-modules_hadoop-client-runtime.txt hadoop-client-runtime in trunk failed.
-1 ❌ mvnsite 0m 42s /branch-mvnsite-hadoop-client-modules_hadoop-client-minicluster.txt hadoop-client-minicluster in trunk failed.
-1 ❌ mvnsite 0m 44s /branch-mvnsite-hadoop-client-modules_hadoop-client-check-test-invariants.txt hadoop-client-check-test-invariants in trunk failed.
+1 💚 shadedclient 29m 28s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 6m 46s trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javadoc 6m 23s trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+0 🆗 spotbugs 0m 27s Used deprecated FindBugs config; considering switching to SpotBugs.
+0 🆗 findbugs 0m 28s branch/hadoop-project no findbugs output file (findbugsXml.xml)
+0 🆗 findbugs 0m 25s branch/hadoop-client-modules/hadoop-client-api no findbugs output file (findbugsXml.xml)
+0 🆗 findbugs 0m 28s branch/hadoop-client-modules/hadoop-client-runtime no findbugs output file (findbugsXml.xml)
+0 🆗 findbugs 0m 26s branch/hadoop-client-modules/hadoop-client-check-invariants no findbugs output file (findbugsXml.xml)
+0 🆗 findbugs 0m 26s branch/hadoop-client-modules/hadoop-client-minicluster no findbugs output file (findbugsXml.xml)
+0 🆗 findbugs 0m 27s branch/hadoop-client-modules/hadoop-client-check-test-invariants no findbugs output file (findbugsXml.xml)
_ Patch Compile Tests _
+0 🆗 mvndep 0m 29s Maven dependency ordering for patch
-1 ❌ mvninstall 0m 30s /patch-mvninstall-hadoop-common-project_hadoop-common.txt hadoop-common in the patch failed.
-1 ❌ mvninstall 0m 19s /patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-client.txt hadoop-hdfs-client in the patch failed.
-1 ❌ mvninstall 0m 25s /patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch failed.
-1 ❌ mvninstall 0m 11s /patch-mvninstall-hadoop-client-modules_hadoop-client-check-test-invariants.txt hadoop-client-check-test-invariants in the patch failed.
-1 ❌ compile 0m 59s /patch-compile-root-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.txt root in the patch failed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.
-1 ❌ cc 0m 59s /patch-compile-root-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.txt root in the patch failed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.
-1 ❌ javac 0m 59s /patch-compile-root-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.txt root in the patch failed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.
-1 ❌ compile 0m 53s /patch-compile-root-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt root in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.
-1 ❌ cc 0m 53s /patch-compile-root-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt root in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.
-1 ❌ javac 0m 53s /patch-compile-root-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt root in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.
-0 ⚠️ checkstyle 3m 2s /diff-checkstyle-root.txt root: The patch generated 1340 new + 0 unchanged - 0 fixed = 1340 total (was 0)
-1 ❌ mvnsite 0m 35s /patch-mvnsite-hadoop-common-project_hadoop-common.txt hadoop-common in the patch failed.
-1 ❌ mvnsite 0m 25s /patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-client.txt hadoop-hdfs-client in the patch failed.
-1 ❌ mvnsite 0m 27s /patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch failed.
-1 ❌ mvnsite 0m 14s /patch-mvnsite-hadoop-client-modules_hadoop-client-check-test-invariants.txt hadoop-client-check-test-invariants in the patch failed.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 10s The patch has no ill-formed XML file.
-1 ❌ shadedclient 0m 54s patch has errors when building and testing our client artifacts.
-1 ❌ javadoc 0m 26s /patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.txt hadoop-common in the patch failed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.
-1 ❌ javadoc 0m 31s /patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.txt hadoop-hdfs-client in the patch failed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.
-1 ❌ javadoc 0m 28s /patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.txt hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.
-1 ❌ javadoc 0m 13s /patch-javadoc-hadoop-client-modules_hadoop-client-check-test-invariants-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.txt hadoop-client-check-test-invariants in the patch failed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.
-1 ❌ javadoc 1m 18s /diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu118.04-b01 with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu118.04-b01 generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)
-1 ❌ javadoc 0m 21s /patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt hadoop-hdfs-client in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.
-1 ❌ javadoc 0m 25s /patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.
-1 ❌ javadoc 0m 13s /patch-javadoc-hadoop-client-modules_hadoop-client-check-test-invariants-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt hadoop-client-check-test-invariants in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.
+0 🆗 findbugs 0m 12s hadoop-project has no data from findbugs
-1 ❌ findbugs 0m 29s /patch-findbugs-hadoop-common-project_hadoop-common.txt hadoop-common in the patch failed.
-1 ❌ findbugs 0m 21s /patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.txt hadoop-hdfs-client in the patch failed.
-1 ❌ findbugs 0m 24s /patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch failed.
+0 🆗 findbugs 0m 13s hadoop-client-modules/hadoop-client-api has no data from findbugs
+0 🆗 findbugs 0m 13s hadoop-client-modules/hadoop-client-runtime has no data from findbugs
+0 🆗 findbugs 0m 13s hadoop-client-modules/hadoop-client-check-invariants has no data from findbugs
+0 🆗 findbugs 0m 13s hadoop-client-modules/hadoop-client-minicluster has no data from findbugs
-1 ❌ findbugs 0m 12s /patch-findbugs-hadoop-client-modules_hadoop-client-check-test-invariants.txt hadoop-client-check-test-invariants in the patch failed.
_ Other Tests _
+1 💚 unit 0m 12s hadoop-project in the patch passed.
-1 ❌ unit 0m 29s /patch-unit-hadoop-common-project_hadoop-common.txt hadoop-common in the patch failed.
-1 ❌ unit 0m 20s /patch-unit-hadoop-hdfs-project_hadoop-hdfs-client.txt hadoop-hdfs-client in the patch failed.
-1 ❌ unit 0m 24s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch failed.
+1 💚 unit 0m 12s hadoop-client-api in the patch passed.
+1 💚 unit 0m 12s hadoop-client-runtime in the patch passed.
+1 💚 unit 0m 12s hadoop-client-check-invariants in the patch passed.
+1 💚 unit 0m 13s hadoop-client-minicluster in the patch passed.
-1 ❌ unit 0m 12s /patch-unit-hadoop-client-modules_hadoop-client-check-test-invariants.txt hadoop-client-check-test-invariants in the patch failed.
+1 💚 asflicense 0m 25s The patch does not generate ASF License warnings.
221m 6s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2632/5/artifact/out/Dockerfile
GITHUB PR #2632
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle cc buflint bufcompat
uname Linux 89fa34200ef0 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 8620984
Default Java Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2632/5/testReport/
Max. process+thread count 570 (vs. ulimit of 5500)
modules C: hadoop-project hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-client-modules/hadoop-client-api hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-check-invariants hadoop-client-modules/hadoop-client-minicluster hadoop-client-modules/hadoop-client-check-test-invariants U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2632/5/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@smengcl
Copy link
Contributor Author

smengcl commented Jan 25, 2021

Still not sure why CI is complaining about a file that I had already completely removed (TracerConfigurationManager.java):

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project hadoop-common: Compilation failure: Compilation failure: 
[ERROR] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2632/src/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tracing/TracerConfigurationManager.java:[35,51] error: cannot find symbol
[ERROR]   symbol: class TraceAdminProtocol
[ERROR] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2632/src/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tracing/TracerConfigurationManager.java:[47,22] error: cannot find symbol
[ERROR]   symbol:   class SpanReceiverInfo
[ERROR]   location: class TracerConfigurationManager
[ERROR] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2632/src/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tracing/TracerConfigurationManager.java:[63,43] error: cannot find symbol
[ERROR] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2632/src/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tracing/TracerConfigurationManager.java:[49,15] error: cannot find symbol
[ERROR] -> [Help 1]
[ERROR]

Not sure if yetus was facing some remnant issues. Guess I'll check that out later if I have time. For now I'll just trying starting a new PR.

@smengcl smengcl closed this Jan 25, 2021
@smengcl smengcl mentioned this pull request Jan 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jojochuang jojochuang Awaiting requested review from jojochuang

@sodonnel sodonnel Awaiting requested review from sodonnel

Assignees

@smengcl smengcl

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@smengcl @hadoop-yetus