Skip to content

YARN-10555. Missing access check before getAppAttempts #2608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2021
Merged

YARN-10555. Missing access check before getAppAttempts #2608

merged 1 commit into from
May 17, 2021

Conversation

lujiefsi
Copy link
Contributor

@lujiefsi lujiefsi commented Jan 8, 2021

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 32m 42s trunk passed
+1 💚 compile 1m 1s trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 compile 0m 52s trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 checkstyle 0m 40s trunk passed
+1 💚 mvnsite 1m 0s trunk passed
+1 💚 shadedclient 16m 50s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 43s trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javadoc 0m 38s trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+0 🆗 spotbugs 1m 49s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 1m 47s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 51s the patch passed
+1 💚 compile 0m 51s the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javac 0m 51s the patch passed
+1 💚 compile 0m 45s the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 javac 0m 45s the patch passed
+1 💚 checkstyle 0m 31s the patch passed
+1 💚 mvnsite 0m 47s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 14m 59s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 39s the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javadoc 0m 35s the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 findbugs 1m 47s the patch passed
_ Other Tests _
-1 ❌ unit 89m 18s /patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚 asflicense 0m 33s The patch does not generate ASF License warnings.
170m 10s
Reason Tests
Failed junit tests hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2608/1/artifact/out/Dockerfile
GITHUB PR #2608
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux bade78ba7eb7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 2ba7ec2
Default Java Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2608/1/testReport/
Max. process+thread count 881 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2608/1/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 3m 38s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 37m 9s trunk passed
+1 💚 compile 1m 1s trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 compile 0m 51s trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 checkstyle 0m 38s trunk passed
+1 💚 mvnsite 0m 55s trunk passed
+1 💚 shadedclient 18m 29s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 43s trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javadoc 0m 35s trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+0 🆗 spotbugs 1m 55s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 1m 52s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 51s the patch passed
+1 💚 compile 0m 54s the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javac 0m 54s the patch passed
+1 💚 compile 0m 45s the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 javac 0m 45s the patch passed
+1 💚 checkstyle 0m 32s the patch passed
+1 💚 mvnsite 0m 48s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 17m 13s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 36s the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javadoc 0m 33s the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 findbugs 1m 53s the patch passed
_ Other Tests _
+1 💚 unit 98m 6s hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚 asflicense 0m 29s The patch does not generate ASF License warnings.
190m 16s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2608/2/artifact/out/Dockerfile
GITHUB PR #2608
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux d1c3870421b8 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / cfe6e1f
Default Java Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2608/2/testReport/
Max. process+thread count 839 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2608/2/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 26m 47s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 33m 17s trunk passed
+1 💚 compile 1m 2s trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 compile 0m 54s trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 checkstyle 0m 40s trunk passed
+1 💚 mvnsite 0m 59s trunk passed
+1 💚 shadedclient 17m 13s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 44s trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javadoc 0m 40s trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+0 🆗 spotbugs 1m 50s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 1m 47s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 52s the patch passed
+1 💚 compile 0m 54s the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javac 0m 54s the patch passed
+1 💚 compile 0m 46s the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 javac 0m 46s the patch passed
+1 💚 checkstyle 0m 31s the patch passed
+1 💚 mvnsite 0m 48s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 14m 58s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 39s the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javadoc 0m 35s the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 findbugs 1m 49s the patch passed
_ Other Tests _
-1 ❌ unit 94m 21s /patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚 asflicense 0m 34s The patch does not generate ASF License warnings.
202m 29s
Reason Tests
Failed junit tests hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2608/3/artifact/out/Dockerfile
GITHUB PR #2608
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 89fb8ac99ec2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 45b3a84
Default Java Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2608/3/testReport/
Max. process+thread count 885 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2608/3/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@lujiefsi
Copy link
Contributor Author

lujiefsi commented Jan 21, 2021 •
edited
Loading

the failure is not related to this change

@gurshafriri
Copy link

Do you plan to merge this fix, and do you see this as a valid potential security issue?
If it is, we (at snyk) would like to add it to our vulnerability DB

aajisaka
aajisaka approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@aajisaka aajisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aajisaka aajisaka merged commit d92a25b into apache:trunk May 17, 2021
aajisaka pushed a commit that referenced this pull request May 17, 2021
@lujiefsi @aajisaka
YARN-10555. Missing access check before getAppAttempts (#2608)
137e20c 
Co-authored-by: lujie <[email protected]>
Signed-off-by: Akira Ajisaka <[email protected]>
(cherry picked from commit d92a25b)
aajisaka pushed a commit that referenced this pull request May 17, 2021
@lujiefsi @aajisaka
YARN-10555. Missing access check before getAppAttempts (#2608)
bc97dd0 
Co-authored-by: lujie <[email protected]>
Signed-off-by: Akira Ajisaka <[email protected]>
(cherry picked from commit d92a25b)
aajisaka pushed a commit that referenced this pull request May 17, 2021
@lujiefsi @aajisaka
YARN-10555. Missing access check before getAppAttempts (#2608)
e0b84c4 
Co-authored-by: lujie <[email protected]>
Signed-off-by: Akira Ajisaka <[email protected]>
(cherry picked from commit d92a25b)
@aajisaka aajisaka changed the title YARN-10555. missing access check before getAppAttempts YARN-10555. Missing access check before getAppAttempts May 17, 2021
aajisaka pushed a commit that referenced this pull request May 17, 2021
@lujiefsi @aajisaka
YARN-10555. Missing access check before getAppAttempts (#2608)
13a2e75 
Co-authored-by: lujie <[email protected]>
Signed-off-by: Akira Ajisaka <[email protected]>
(cherry picked from commit d92a25b)
kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021
@lujiefsi
YARN-10555. Missing access check before getAppAttempts (apache#2608)
0f81c49 
Co-authored-by: lujie <[email protected]>
Signed-off-by: Akira Ajisaka <[email protected]>
jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
@lujiefsi @tomicooler
COMPX-7858: YARN-10555. Missing access check before getAppAttempts (a…
9969680 
…pache#2608)

Change-Id: I34fadd20032361d73ebdc320a332e1fe3850d3d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aajisaka aajisaka aajisaka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lujiefsi @hadoop-yetus @gurshafriri @aajisaka