HADOOP-17323 Skipping IO for root directory when empty directory flag is not required. #2479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flag is not required.
|
CC @steveloughran Do check during your review session. |
This comment has been minimized.
This comment has been minimized.
steveloughran
requested changes
Nov 21, 2020
| "s3GetFileStatus(%s) wants to know if a directory is empty but" | ||
| + " does not request a list probe", path); | ||
|
|
||
| if(key.isEmpty() && !needEmptyDirectoryFlag) { |
There was a problem hiding this comment.
nit: add a space after if
| false, | ||
| StatusProbeEnum.ALL, | ||
| ROOT_FILE_STATUS_PROBE); | ||
| Assertions.assertThat(rootStatus.isDirectory()) |
There was a problem hiding this comment.
for strictness, how about before L270 you do a status.toString() into a variable, and include that at the end of each describedAs message. That way, if there really was an assertion failure, we'd see the status
This comment has been minimized.
This comment has been minimized.
asfgit
pushed a commit
that referenced
this pull request
Nov 24, 2020
Contributed by Mukund Thakur. Change-Id: I1709ad72b829999b6dd324f0755b51bc38918d30
steveloughran
added
enhancement
fs/s3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran ITestS3AFileOperationCost in raw mode using ap-south-1 bucket. Saw no failures.