HADOOP-14539. Move commons logging APIs over to slf4j in hadoop-common. #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aajisaka
reviewed
Jul 10, 2017
There was a problem hiding this comment.
Would you move the new imports above the comment "this will need to ...."?
There was a problem hiding this comment.
OK, fix it in d04928e.
wenxinhe
force-pushed
the
HADOOP-14539.hadoop-common.logging
branch
2 times, most recently
from
7de6a2b to
d04928e
Compare
simple replace: org.apache.commons.logging.Log -> org.slf4j.Logger
change: LOG.fatal() -> LOG.error()
change: org.apache.commons.logging.Log.debug(Object)
->org.slf4j.Logger.debug(String)
change: org.apache.commons.logging.Log.debug(Object)
-> org.slf4j.Logger.debug(String, Throwable)
change: org.apache.commons.logging.Log.debug(Object, (Throwable) null)
-> org.slf4j.Logger.debug(String, (Throwable) null)
change: IOUtils.cleanup -> IOUtils.cleanupWithLogger
revert FileSystem.LOG for it's referenced by hadoop-yarn
change: SignalLogger.INSTANCE.register(LOG)
-> SignalLogger.INSTANCE.register(LogAdapter.create(LOG))
move the new imports above the comment "this will need to ...."
fix checkstyle issues: Indentation, LineLength
fix checkstyle issues: StaticVariableName 1. add final modifier to LOG. 2. leave LOG in ShellCommandFencer unchanged for it's reassigned in tests.
fix checkstyle issues: MemberName 1. add static modifier to LOG. 2. leave LOG in AbstractGangliaSink, GangliaSink30 and GangliaSink31 unchanged for they're real instance member.
fix checkstyle issues: RedundantModifier, ConstantName
wenxinhe
force-pushed
the
HADOOP-14539.hadoop-common.logging
branch
from
680e0ba to
e73205d
Compare
shanthoosh
added a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
In some cases LocalAppRunner.waitForFinish indefinitely blocks after LocalApplicationRunner.kill. Last step in LocalAppRunner.kill(streamApp) is zkClient.close()[zkClient belongs to ZkCoordinationService]. ApplicationRunner.kill triggers listeners chain and in final listener zkClient.close throws ZkInterruptedException(RuntimeException) & it's swallowed in listeners preventing shutdownLatch update in LocalApplicationRunner(required for proper shutdown). Author: Shanthoosh Venkataraman <[email protected]> Reviewers: Boris Shkolnik <[email protected]>, Navina Ramesh <[email protected]> Closes apache#246 from shanthoosh/SAMZA-1364
susheelgupta7
pushed a commit
to susheel-gupta/hadoop
that referenced
this pull request
Apr 30, 2025
…) (apache#246) (cherry picked from commit 22b8fcd) Co-authored-by: Ferenc Erdelyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.