Skip to content

Conversation

@amahussein
Copy link
Contributor

I touched {{hadoop-yarn-common/pom.xml}} to trigger testing the entire module.

NOTICE

Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 33m 55s trunk passed
+1 💚 compile 0m 47s trunk passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1
+1 💚 compile 0m 44s trunk passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
+1 💚 checkstyle 0m 34s trunk passed
+1 💚 mvnsite 0m 49s trunk passed
+1 💚 shadedclient 16m 20s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 39s trunk passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1
+1 💚 javadoc 0m 49s trunk passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
+0 🆗 spotbugs 1m 52s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 1m 50s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 42s the patch passed
+1 💚 compile 0m 40s the patch passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1
+1 💚 javac 0m 40s the patch passed
+1 💚 compile 0m 38s the patch passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
+1 💚 javac 0m 38s the patch passed
+1 💚 checkstyle 0m 25s the patch passed
+1 💚 mvnsite 0m 39s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+1 💚 shadedclient 14m 50s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 33s the patch passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1
+1 💚 javadoc 0m 46s the patch passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
+1 💚 findbugs 1m 50s the patch passed
_ Other Tests _
+1 💚 unit 4m 6s hadoop-yarn-common in the patch passed.
+1 💚 asflicense 0m 31s The patch does not generate ASF License warnings.
84m 31s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2450/1/artifact/out/Dockerfile
GITHUB PR #2450
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle
uname Linux 336a1440091a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 9a9ab5b
Default Java Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2450/1/testReport/
Max. process+thread count 414 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2450/1/console
versions git=2.17.1 maven=3.6.0 findbugs=4.1.3
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@amahussein
Copy link
Contributor Author

@ayushtkn can you please take a look at this change?

Copy link
Contributor

@jbrennan333 jbrennan333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 this looks good to me.

@jbrennan333
Copy link
Contributor

This looks good to me. I will commit this monday afternoon if there are no objections.
cc: @ayushtkn, @pbacsko, @szilard-nemeth

@jbrennan333
Copy link
Contributor

I don't think a new test is needed here, because this change was made internally to fix tests that were failing due to time-outs.

Copy link
Contributor

@adamantal adamantal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the patch!

@jbrennan333 jbrennan333 merged commit 0b2510e into apache:trunk Nov 16, 2020
asfgit pushed a commit that referenced this pull request Nov 16, 2020
…Contributed by Ahmed Hussein

(cherry picked from commit 0b2510e)
asfgit pushed a commit that referenced this pull request Nov 16, 2020
…Contributed by Ahmed Hussein

(cherry picked from commit 0b2510e)
asfgit pushed a commit that referenced this pull request Nov 16, 2020
…Contributed by Ahmed Hussein

(cherry picked from commit 0b2510e)
@amahussein amahussein deleted the yarn-10485 branch November 24, 2020 16:43
asfgit pushed a commit that referenced this pull request Nov 28, 2020
…Contributed by Ahmed Hussein

(cherry picked from commit 0b2510e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants