Skip to content

HADOOP-17367. Add InetAddress api to ProxyUsers.authorize #2449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 19, 2020
Merged

HADOOP-17367. Add InetAddress api to ProxyUsers.authorize #2449

merged 2 commits into from
Nov 19, 2020

Conversation

@amahussein
Copy link
Contributor

NOTICE

Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 52s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 0m 0s test4tests The patch appears to include 3 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 15m 7s Maven dependency ordering for branch
+1 💚 mvninstall 24m 38s trunk passed
+1 💚 compile 23m 55s trunk passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1
+1 💚 compile 18m 8s trunk passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
+1 💚 checkstyle 2m 45s trunk passed
+1 💚 mvnsite 2m 57s trunk passed
+1 💚 shadedclient 21m 24s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 2m 28s trunk passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1
+1 💚 javadoc 2m 55s trunk passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
+0 🆗 spotbugs 0m 55s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 4m 1s trunk passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 27s Maven dependency ordering for patch
+1 💚 mvninstall 1m 45s the patch passed
+1 💚 compile 19m 33s the patch passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1
-1 ❌ javac 19m 33s /diff-compile-javac-root-jdkUbuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1.txt root-jdkUbuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1 with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1 generated 10 new + 2050 unchanged - 0 fixed = 2060 total (was 2050)
+1 💚 compile 17m 17s the patch passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
-1 ❌ javac 17m 16s /diff-compile-javac-root-jdkPrivateBuild-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10.txt root-jdkPrivateBuild-1.8.0_272-8u272-b10-0ubuntu118.04-b10 with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu118.04-b10 generated 10 new + 1945 unchanged - 0 fixed = 1955 total (was 1945)
-0 ⚠️ checkstyle 2m 39s /diff-checkstyle-root.txt root: The patch generated 3 new + 136 unchanged - 17 fixed = 139 total (was 153)
+1 💚 mvnsite 2m 58s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 14m 55s patch has no errors when building and testing our client artifacts.
-1 ❌ javadoc 1m 3s /patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1.txt hadoop-common in the patch failed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1.
-1 ❌ javadoc 1m 36s /diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10.txt hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_272-8u272-b10-0ubuntu118.04-b10 with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu118.04-b10 generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)
+1 💚 findbugs 4m 26s the patch passed
_ Other Tests _
-1 ❌ unit 9m 39s /patch-unit-hadoop-common-project_hadoop-common.txt hadoop-common in the patch passed.
+1 💚 unit 1m 12s hadoop-dynamometer-workload in the patch passed.
-1 ❌ unit 0m 44s /patch-unit-hadoop-tools_hadoop-dynamometer_hadoop-dynamometer-infra.txt hadoop-dynamometer-infra in the patch passed.
+1 💚 asflicense 0m 56s The patch does not generate ASF License warnings.
201m 14s
Reason Tests
Failed junit tests hadoop.util.TestMachineList
hadoop.tools.dynamometer.TestDynamometerInfra
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2449/1/artifact/out/Dockerfile
GITHUB PR #2449
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 9b1d41fc9324 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 1ea3f74
Default Java Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2449/1/testReport/
Max. process+thread count 3461 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-workload hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-infra U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2449/1/console
versions git=2.17.1 maven=3.6.0 findbugs=4.1.3
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 0m 0s test4tests The patch appears to include 3 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 15m 54s Maven dependency ordering for branch
+1 💚 mvninstall 20m 32s trunk passed
+1 💚 compile 20m 9s trunk passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1
+1 💚 compile 17m 21s trunk passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
+1 💚 checkstyle 2m 48s trunk passed
+1 💚 mvnsite 2m 54s trunk passed
+1 💚 shadedclient 20m 58s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 2m 26s trunk passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1
+1 💚 javadoc 2m 56s trunk passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
+0 🆗 spotbugs 0m 55s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 4m 3s trunk passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 26s Maven dependency ordering for patch
+1 💚 mvninstall 1m 45s the patch passed
+1 💚 compile 19m 28s the patch passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1
+1 💚 javac 19m 28s the patch passed
+1 💚 compile 17m 20s the patch passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
+1 💚 javac 17m 20s the patch passed
+1 💚 checkstyle 2m 42s root: The patch generated 0 new + 136 unchanged - 17 fixed = 136 total (was 153)
+1 💚 mvnsite 2m 53s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 14m 58s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 2m 25s the patch passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1
+1 💚 javadoc 2m 57s the patch passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
+1 💚 findbugs 4m 23s the patch passed
_ Other Tests _
+1 💚 unit 9m 35s hadoop-common in the patch passed.
+1 💚 unit 1m 15s hadoop-dynamometer-workload in the patch passed.
-1 ❌ unit 0m 44s /patch-unit-hadoop-tools_hadoop-dynamometer_hadoop-dynamometer-infra.txt hadoop-dynamometer-infra in the patch passed.
+1 💚 asflicense 0m 56s The patch does not generate ASF License warnings.
192m 19s
Reason Tests
Failed junit tests hadoop.tools.dynamometer.TestDynamometerInfra
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2449/2/artifact/out/Dockerfile
GITHUB PR #2449
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 4346284552be 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 9a9ab5b
Default Java Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2449/2/testReport/
Max. process+thread count 2727 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-workload hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-infra U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2449/2/console
versions git=2.17.1 maven=3.6.0 findbugs=4.1.3
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@amahussein
Copy link
Contributor Author

hadoop.tools.dynamometer.TestDynamometerInfra is failing on trunk from Nov 9th. It cannot find tar file.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 31m 37s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 0m 0s test4tests The patch appears to include 3 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 14m 50s Maven dependency ordering for branch
+1 💚 mvninstall 23m 20s trunk passed
+1 💚 compile 21m 40s trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 compile 18m 11s trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 checkstyle 2m 49s trunk passed
+1 💚 mvnsite 2m 34s trunk passed
+1 💚 shadedclient 22m 47s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 2m 0s trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javadoc 2m 29s trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+0 🆗 spotbugs 0m 46s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 3m 41s trunk passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 22s Maven dependency ordering for patch
+1 💚 mvninstall 1m 40s the patch passed
+1 💚 compile 21m 33s the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javac 21m 33s the patch passed
+1 💚 compile 18m 13s the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 javac 18m 13s the patch passed
+1 💚 checkstyle 2m 49s root: The patch generated 0 new + 136 unchanged - 17 fixed = 136 total (was 153)
+1 💚 mvnsite 2m 32s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 shadedclient 16m 58s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 2m 0s the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javadoc 2m 28s the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 findbugs 4m 7s the patch passed
_ Other Tests _
-1 ❌ unit 9m 38s /patch-unit-hadoop-common-project_hadoop-common.txt hadoop-common in the patch passed.
+1 💚 unit 1m 4s hadoop-dynamometer-workload in the patch passed.
-1 ❌ unit 0m 35s /patch-unit-hadoop-tools_hadoop-dynamometer_hadoop-dynamometer-infra.txt hadoop-dynamometer-infra in the patch passed.
+1 💚 asflicense 0m 47s The patch does not generate ASF License warnings.
230m 20s
Reason Tests
Failed junit tests hadoop.security.TestRaceWhenRelogin
hadoop.tools.dynamometer.TestDynamometerInfra
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2449/3/artifact/out/Dockerfile
GITHUB PR #2449
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle
uname Linux 211fd3f19f63 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 0d3155a
Default Java Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2449/3/testReport/
Max. process+thread count 1393 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-workload hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-infra U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2449/3/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

jbrennan333
jbrennan333 reviewed Nov 18, 2020
View reviewed changes
Copy link
Contributor

@jbrennan333 jbrennan333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 this looks good to me.

jbrennan333
jbrennan333 approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@jbrennan333 jbrennan333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Thanks @amahussein!

@jbrennan333 jbrennan333 merged commit 0705033 into apache:trunk Nov 19, 2020
asfgit pushed a commit that referenced this pull request Nov 19, 2020
@jbrennan333
HADOOP-17367. Add InetAddress api to ProxyUsers.authorize (#2449). Co…
e24a6b5 
…ntributed by Daryn Sharp and Ahmed Hussein
asfgit pushed a commit that referenced this pull request Nov 19, 2020
@jbrennan333
HADOOP-17367. Add InetAddress api to ProxyUsers.authorize (#2449). Co…
6b3d65b 
…ntributed by Daryn Sharp and Ahmed Hussein
asfgit pushed a commit that referenced this pull request Nov 19, 2020
@jbrennan333
HADOOP-17367. Add InetAddress api to ProxyUsers.authorize (#2449). Co…
da87653 
…ntributed by Daryn Sharp and Ahmed Hussein

(cherry picked from commit 6b3d65b)
asfgit pushed a commit that referenced this pull request Nov 28, 2020
@jbrennan333 @Hexiaoqiao
HADOOP-17367. Add InetAddress api to ProxyUsers.authorize (#2449). Co…
d99f8e7 
…ntributed by Daryn Sharp and Ahmed Hussein
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbrennan333 jbrennan333 jbrennan333 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amahussein @hadoop-yetus @jbrennan333