HDFS-15551. Tiny Improve for DeadNode detector #2265

imbajin · 2020-09-01T12:25:36Z

add or improve some logs for adding local & global deadnodes
logic improve
fix typo

1. add or improve some logs for adding local & global deadnodes 2. logic improve 3. fix typo

hadoop-yetus · 2020-09-01T13:49:57Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1 💚	mvninstall	31m 19s	trunk passed
+1 💚	compile	1m 4s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	0m 54s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	checkstyle	0m 32s	trunk passed
+1 💚	mvnsite	1m 1s	trunk passed
+1 💚	shadedclient	15m 54s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 43s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	0m 39s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗	spotbugs	2m 53s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 51s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 52s	the patch passed
+1 💚	compile	0m 55s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javac	0m 55s	the patch passed
+1 💚	compile	0m 46s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	javac	0m 46s	the patch passed
+1 💚	checkstyle	0m 20s	the patch passed
+1 💚	mvnsite	0m 50s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	14m 15s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 38s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	0m 35s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	findbugs	2m 48s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 11s	hadoop-hdfs-client in the patch passed.
-1 ❌	asflicense	0m 35s	The patch generated 3 ASF License warnings.
		82m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2265/1/artifact/out/Dockerfile
GITHUB PR	#2265
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 4736793dcd9d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `7e671f3`
Default Java	Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2265/1/testReport/
asflicense	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2265/1/artifact/out/patch-asflicense-problems.txt
Max. process+thread count	414 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2265/1/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

leosunli · 2020-09-01T15:32:19Z

hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java

  private byte[] oneByteBuf; // used for 'int read()'

  protected void addToLocalDeadNodes(DatanodeInfo dnInfo) {
+    DFSClient.LOG.debug("Add {} to local dead nodes, previously was {}",


1、Is it necessary to add log in Local dead nodes?
2、if add debug log in DFSInputStream#addToLocalDeadNodes, do you need add log in DFSInputStream#removeFromLocalDeadNodes?

From the statistics of the production environment, the log output of local deadnode information is too few, so that it is troublesome to find the problem reason

The reason to use the DEBUG log level is to separate from the INFO log level of the detector, and the impact is small.

Remove logs can be added at the same time(I think both are OK). It was not added before considering that the local dead node removal method will almost never be called, unless the detector is turned on and there is already log output there.

leosunli · 2020-09-04T04:43:10Z

...p-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DeadNodeDetector.java

      datanodeInfos.add(datanodeInfo);
    }

+    LOG.warn("Add datanode {} to suspectAndDeadNodes", datanodeInfo);


One case: when a lot of stale relicas, will the log flood?

use DEBUG as default now

...p-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DeadNodeDetector.java

hadoop-yetus · 2020-09-04T12:11:49Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	28m 7s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1 💚	mvninstall	27m 55s	trunk passed
+1 💚	compile	0m 58s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	0m 51s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	checkstyle	0m 29s	trunk passed
+1 💚	mvnsite	0m 58s	trunk passed
+1 💚	shadedclient	15m 30s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 42s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	0m 37s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗	spotbugs	2m 26s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 24s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 49s	the patch passed
+1 💚	compile	0m 50s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javac	0m 50s	the patch passed
+1 💚	compile	0m 43s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	javac	0m 43s	the patch passed
+1 💚	checkstyle	0m 19s	the patch passed
+1 💚	mvnsite	0m 46s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	14m 3s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 35s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	0m 33s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	findbugs	2m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 4s	hadoop-hdfs-client in the patch passed.
+1 💚	asflicense	0m 34s	The patch does not generate ASF License warnings.
		104m 51s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2265/2/artifact/out/Dockerfile
GITHUB PR	#2265
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 53e09050e647 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `696e4fe`
Default Java	Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2265/2/testReport/
Max. process+thread count	415 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2265/2/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

leosunli · 2020-09-08T02:00:03Z

+1 LGFM.

imbajin · 2020-09-09T02:25:07Z

@Hexiaoqiao Could u help me check if there are any other questions?

Hexiaoqiao · 2020-09-09T04:02:58Z

Thanks @imbajin involve me here and thanks @leosunli for reviews. LGTM. +1.
Will merge pending 3 business days if any other comments leave.

Contributed by imbajin. Reviewed-by: leosunli <[email protected]> Signed-off-by: He Xiaoqiao <[email protected]> (cherry picked from commit 89428f1)

DeadNode detector's tiny improve

ec130e9

1. add or improve some logs for adding local & global deadnodes 2. logic improve 3. fix typo

imbajin changed the title ~~HADOOP-15551 Tiny Improve for DeadNode detector~~ HADOOP-15551. Tiny Improve for DeadNode detector Sep 1, 2020

imbajin changed the title ~~HADOOP-15551. Tiny Improve for DeadNode detector~~ HDFS-15551. Tiny Improve for DeadNode detector Sep 1, 2020

leosunli reviewed Sep 1, 2020

View reviewed changes

leosunli reviewed Sep 4, 2020

View reviewed changes

adjust LOG level

1d3aa75

Hexiaoqiao approved these changes Sep 9, 2020

View reviewed changes

Hexiaoqiao merged commit 89428f1 into apache:trunk Sep 11, 2020

asfgit pushed a commit that referenced this pull request Mar 24, 2021

HDFS-15551. Tiny Improve for DeadNode detector (#2265)

4f79df4

Contributed by imbajin. Reviewed-by: leosunli <[email protected]> Signed-off-by: He Xiaoqiao <[email protected]> (cherry picked from commit 89428f1)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

HDFS-15551. Tiny Improve for DeadNode detector #2265

HDFS-15551. Tiny Improve for DeadNode detector #2265

Uh oh!

imbajin commented Sep 1, 2020

Uh oh!

hadoop-yetus commented Sep 1, 2020

Uh oh!

leosunli Sep 1, 2020

Uh oh!

imbajin Sep 2, 2020 •

edited

Loading

Uh oh!

leosunli Sep 4, 2020 •

edited

Loading

Uh oh!

imbajin Sep 4, 2020

Uh oh!

Uh oh!

hadoop-yetus commented Sep 4, 2020

Uh oh!

leosunli commented Sep 8, 2020

Uh oh!

imbajin commented Sep 9, 2020

Uh oh!

Hexiaoqiao commented Sep 9, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

HDFS-15551. Tiny Improve for DeadNode detector #2265

HDFS-15551. Tiny Improve for DeadNode detector #2265

Uh oh!

Conversation

imbajin commented Sep 1, 2020

Uh oh!

hadoop-yetus commented Sep 1, 2020

Uh oh!

leosunli Sep 1, 2020

Choose a reason for hiding this comment

Uh oh!

imbajin Sep 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

leosunli Sep 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

imbajin Sep 4, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hadoop-yetus commented Sep 4, 2020

Uh oh!

leosunli commented Sep 8, 2020

Uh oh!

imbajin commented Sep 9, 2020

Uh oh!

Hexiaoqiao commented Sep 9, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

imbajin Sep 2, 2020 •

edited

Loading

leosunli Sep 4, 2020 •

edited

Loading