HDFS-15430. create should work when parent dir is internalDir and fallback configured. #2107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jojochuang
reviewed
Jun 30, 2020
...fs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsLinkFallback.java
Outdated
Show resolved
Hide resolved
...ct/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemLinkFallback.java
Outdated
Show resolved
Hide resolved
jojochuang
reviewed
Jul 1, 2020
...ct/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemLinkFallback.java
Outdated
Show resolved
Hide resolved
|
Thanks @jojochuang for the review. I have updated with fixing the comments. Let me know if you have further. Thanks |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
…lback configured.
…dition as we attempt create only in the case of fallback.
umamaheswararao
force-pushed
the
HDFS-15430
branch
from
7f7bad8 to
3225add
Compare
|
💔 -1 overall
This message was automatically generated. |
|
Test failures are unrelated and javadoc failures due to HADOOP-17091. |
ayushtkn
approved these changes
Jul 4, 2020
There was a problem hiding this comment.
Thanx @umamaheswararao for the work here. Seems the test cases tend to handle almost all cases which I can think of. :-)
Changes LGTM +1
| vfs.create(vfsTestDir); | ||
| Assert.fail("Should fail to create file as this is an internal dir."); | ||
| } catch (NotInMountpointException e){ | ||
| // This tree is part of internal tree. The above expetion will be thrown |
There was a problem hiding this comment.
Thanks. Done.
| ParentNotDirectoryException, UnsupportedFileSystemException, | ||
| UnresolvedLinkException, IOException { | ||
| Preconditions.checkNotNull(f, "File cannot be null."); | ||
| // Just a sanity check. This should not happen. |
There was a problem hiding this comment.
What do you mean by : This should not happen. Ideally client call shouldn't land here or This If check will never get hit(It does get hit, I verified),
There was a problem hiding this comment.
My comments seems to be too light. "//" will trigger this. But ideally that should not happen as users would not create files with /. However if somebody attempts we are ready to shoot. I have removed that comment, as it may be confusing.
However, this will trigger mostly in ViewFs.java, but may not be in ViewFileSystem.java. In ViewFileSystem.java, getDefaultReplication API itself might shade this condition if parent is internal currently. Anyway the current condition should be good enough to handle if some one try with files as "//" etc
Thanks for checking.
|
Thank you @ayushtkn for review!! |
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HDFS-15430