HDFS-15419. RBF: Router should retry communicate with NN when cluster is unavailable using configurable time interval #2082
+32
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update forks
bhji123
changed the title
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
goiri
reviewed
Jun 18, 2020
...-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java
Outdated
Show resolved
Hide resolved
...-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
This logic starts with this counter at a value and then decreases, it makes sense to keep it as such.
There was a problem hiding this comment.
In fact, not all clients are so smart, they may not configred appropriately. When those clients encounter this problem, they complain about router not retry more.
There was a problem hiding this comment.
The idea before was for us to surface the unavailability to the client and then the client retry with the regular client logic.
There was a problem hiding this comment.
In fact, not all clients are so smart, they may not configred appropriately. When those clients encounter this problem, they complain about router not retry more.
There was a problem hiding this comment.
Sure, but we should change the logic to match the old style or at least to not have the two styles together.
bhji123
force-pushed
the
router-retry
branch
3 times, most recently
from
31247aa to
94b0399
Compare
|
💔 -1 overall
This message was automatically generated. |
…n cluster is unavailable.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
goiri
reviewed
Sep 16, 2020
| String DFS_LEASE_HARDLIMIT_KEY = "dfs.namenode.lease-hard-limit-sec"; | ||
| long DFS_LEASE_HARDLIMIT_DEFAULT = 20 * 60; | ||
|
|
||
| String DFS_ROUTER_RPC_RETRY_INTERVAL_KEY = "dfs.router.rpc.retry.interval.seconds"; |
There was a problem hiding this comment.
Technically is not seconds but time duration.
| long DFS_LEASE_HARDLIMIT_DEFAULT = 20 * 60; | ||
|
|
||
| String DFS_ROUTER_RPC_RETRY_INTERVAL_KEY = "dfs.router.rpc.retry.interval.seconds"; | ||
| int DFS_ROUTER_RPC_RETRY_INTERVAL_DEFAULT = 10; |
There was a problem hiding this comment.
Make it TimeUnit.SECONDS.toXXXX(10)
There was a problem hiding this comment.
Sure, but we should change the logic to match the old style or at least to not have the two styles together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute