-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-16830. IOStatistics API. #2069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
steveloughran
wants to merge
40
commits into
apache:trunk
from
steveloughran:s3/HADOOP-16830-iostatistics
Closed
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
77fb70b
HADOOP-16830. IOStatistics API.
steveloughran 6dc8955
HADOOP-16830. Turning off AWS SDK metric collection.
steveloughran 50fd592
extra assert in >AbstractSTestS3AHugeFiles.test_010_CreateHugeFile; c…
steveloughran 8466dcc
HADOOP-16830: statistics API
steveloughran f03a985
HADOOP-16830. Statistics APIs
steveloughran c95adff
HADOOP-16830. IO Statistics
steveloughran ec1d45b
HADOOP-16830. IO Statistics
steveloughran 88d6e79
HADOOP-16830. IO Statistics -add local fs stats
steveloughran ab4d2e0
HADOOP-16830. missed a file
steveloughran 62aaeb2
HADOOP-16830. counters are resettable
steveloughran 6d9828e
HADOOP-16830. move s3a input stream stats to CounterIOStatistics
steveloughran 1c3f9c2
Draft an IOStatisticEntry for more generic stats
steveloughran 2569d1d
HADOOP-16830 move to type plus tuple stats entries
steveloughran 4369445
HADOOP-16830 complete IOStatisticsEntry. This is getting overcomplicated
steveloughran fba2f98
HADOOP-16830 move to new stats api
steveloughran 6abd4bb
HADOOP-16830 third iteration of a statistics API
steveloughran 9eea895
HADOOP-16830 third iteration of a statistics API
steveloughran 8d5f4ab
- builder API for creating CounterIOStatistics
steveloughran 26affff
HADOOP-16830 counters, gauges, min and max
steveloughran e306ccc
empty statistics, how -ve values should be aggregated
steveloughran 3ab8b5a
HADOOP-16830; IOStatistics stream capability
steveloughran 5db61a6
HADOOP-16830 fix a javadoc warning. This isn't new with this PR
steveloughran 3224e8d
HADOOP-16830. IOStatisticsSnapshot to be JSON serializable
steveloughran 2b672a2
HADOOP-16830: statistics now round trip as JSON
steveloughran 910fdad
HADOOP-16830. IOStatistics through S3A committers
steveloughran 82e13f0
HADOOP-16830. S3AInputStreamStatistics
steveloughran 327be95
HADOOP-16830. multipart uploader integration
steveloughran ca4a240
HADOOP-16830 IOStatistics for duration tracking, broader use
steveloughran 34f21fd
HADOOP-16830 Duration Tracking
steveloughran 7e199e4
HADOOP-16830 S3A OutputStream unbuffer/close stats
steveloughran 53c88a3
HADOOP-16830 checkstyle, tests and toString
steveloughran b29f671
HADOOP-16830 RemoteIterator work and listings
steveloughran 7ba251d
HADOOP-17226. Failure of ITestAssumeRole.testRestrictedCommitActions
steveloughran 7c3b47b
HADOOP-16830 More standard operation names in hadoop-common
steveloughran be97274
HADOOP-16830 DurationTrackerFactory
steveloughran 952a34f
HADOOP-16830 DurationTrackerFactory adoption
steveloughran 0806a23
HADOOP-16830 speech dictation typo
steveloughran e9742f5
HADOOP-16830 RemoteIterators evolution
steveloughran 84c30a7
HADOOP-16830 IOStatistics
steveloughran a6935c0
HADOOP-16830. RemoteIterators
steveloughran File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this IOStatistics API primarily displays information through toString() messages in log statements. Is this the best way to integrate with Hadoop - or is there value to adding an explicit (possibly type safe) interface for objects to display their IOStatistics information?
Also - does it make sense here to move the calls to
sb#appendinside of the if statement? That way, non instances will not have their string representation changed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah nevermind I see the IOStatisticsSnapshot class is serializable and allows interprocess communication of this dataformat / an API to use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the logging lets us see what IO downstream apps are doing even without them picking up the API -the way S3A and ABFS streams do; The FSDataInputStream wrapper class &c do toString passthrough to help here. The IOStreams API Does exactly the same thing.
Result
Option #2 is the interim one which you can do for any app today -we just have to make sure the hadoop wrapper/aggregate classes all have toString() calls which forward/include stats from inner classes, and do it efficiently