Skip to content

Conversation

ayushtkn
Copy link
Member

@ayushtkn ayushtkn commented Jun 6, 2020

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 14s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 21m 46s trunk passed
+1 💚 compile 1m 8s trunk passed
+1 💚 checkstyle 0m 45s trunk passed
+1 💚 mvnsite 1m 13s trunk passed
+1 💚 shadedclient 17m 18s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 43s trunk passed
+0 🆗 spotbugs 3m 4s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 3m 2s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 1m 9s the patch passed
+1 💚 compile 1m 3s the patch passed
+1 💚 javac 1m 3s the patch passed
+1 💚 checkstyle 0m 41s the patch passed
+1 💚 mvnsite 1m 7s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 15m 25s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 40s the patch passed
+1 💚 findbugs 3m 4s the patch passed
_ Other Tests _
-1 ❌ unit 108m 16s hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 34s The patch does not generate ASF License warnings.
180m 24s
Reason Tests
Failed junit tests hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy
hadoop.hdfs.TestRollingUpgrade
hadoop.hdfs.TestReconstructStripedFile
hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
hadoop.hdfs.server.datanode.TestBPOfferService
hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2059/1/artifact/out/Dockerfile
GITHUB PR #2059
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux d391ebc64338 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / cc671b1
Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-2059/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-2059/1/testReport/
Max. process+thread count 3246 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-2059/1/console
versions git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ayushtkn
Copy link
Member Author

ayushtkn commented Jun 6, 2020

Test failures aren't related

@ayushtkn
Copy link
Member Author

ayushtkn commented Jun 7, 2020

Updated to Resolve to "/" in case of empty string

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 30s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 0m 26s Maven dependency ordering for branch
+1 💚 mvninstall 18m 51s trunk passed
+1 💚 compile 16m 53s trunk passed
+1 💚 checkstyle 2m 41s trunk passed
+1 💚 mvnsite 2m 54s trunk passed
+1 💚 shadedclient 19m 59s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 2m 0s trunk passed
+0 🆗 spotbugs 3m 5s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 5m 10s trunk passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 26s Maven dependency ordering for patch
+1 💚 mvninstall 1m 56s the patch passed
+1 💚 compile 16m 19s the patch passed
+1 💚 javac 16m 19s the patch passed
+1 💚 checkstyle 2m 39s the patch passed
+1 💚 mvnsite 2m 55s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 13m 54s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 2m 2s the patch passed
+1 💚 findbugs 5m 27s the patch passed
_ Other Tests _
+1 💚 unit 9m 18s hadoop-common in the patch passed.
-1 ❌ unit 93m 54s hadoop-hdfs in the patch passed.
+1 💚 asflicense 1m 7s The patch does not generate ASF License warnings.
217m 43s
Reason Tests
Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy
hadoop.hdfs.TestReconstructStripedFile
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2059/3/artifact/out/Dockerfile
GITHUB PR #2059
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 430d8c922c51 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 3ca1529
Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-2059/3/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-2059/3/testReport/
Max. process+thread count 4660 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-2059/3/console
versions git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 22s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 0m 59s Maven dependency ordering for branch
+1 💚 mvninstall 22m 18s trunk passed
+1 💚 compile 18m 32s trunk passed
+1 💚 checkstyle 2m 52s trunk passed
+1 💚 mvnsite 2m 51s trunk passed
+1 💚 shadedclient 21m 45s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 46s trunk passed
+0 🆗 spotbugs 3m 12s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 5m 22s trunk passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 24s Maven dependency ordering for patch
+1 💚 mvninstall 2m 11s the patch passed
+1 💚 compile 17m 46s the patch passed
+1 💚 javac 17m 46s the patch passed
+1 💚 checkstyle 2m 49s the patch passed
+1 💚 mvnsite 2m 48s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 16m 17s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 44s the patch passed
+1 💚 findbugs 5m 37s the patch passed
_ Other Tests _
+1 💚 unit 10m 31s hadoop-common in the patch passed.
-1 ❌ unit 113m 8s hadoop-hdfs in the patch passed.
+1 💚 asflicense 1m 1s The patch does not generate ASF License warnings.
249m 49s
Reason Tests
Failed junit tests hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy
hadoop.hdfs.TestReconstructStripedFile
hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2059/2/artifact/out/Dockerfile
GITHUB PR #2059
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 1e8528db9abf 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 3ca1529
Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-2059/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-2059/2/testReport/
Max. process+thread count 3224 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-2059/2/console
versions git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@umamaheswararao
Copy link
Contributor

+1 LGTM

@umamaheswararao umamaheswararao merged commit a8610c1 into apache:trunk Jun 7, 2020
@umamaheswararao
Copy link
Contributor

I have just noticed you did changes only in ViewFileSystem.java, but we should do same change in ViewFs.java also. Probably let's this JIRA stick to test passing. Reminder of change I will keep in HADOOP-17060. Or you want to revert and add that also? Let me know I will keep changes accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants