HDFS-15386. ReplicaNotFoundException keeps happening in DN after removing multiple DN's data directories. #2052

brfrn169 · 2020-06-04T03:00:58Z

…ing multiple DN's data directories

hadoop-yetus · 2020-06-04T05:46:06Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	19m 1s	trunk passed
+1 💚	compile	1m 9s	trunk passed
+1 💚	checkstyle	0m 51s	trunk passed
+1 💚	mvnsite	1m 19s	trunk passed
+1 💚	shadedclient	15m 55s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 46s	trunk passed
+0 🆗	spotbugs	3m 1s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 58s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 8s	the patch passed
+1 💚	compile	1m 0s	the patch passed
+1 💚	javac	1m 0s	the patch passed
-0 ⚠️	checkstyle	0m 39s	hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 124 unchanged - 1 fixed = 126 total (was 125)
+1 💚	mvnsite	1m 10s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	15m 4s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 42s	the patch passed
+1 💚	findbugs	3m 14s	the patch passed
		_ Other Tests _
-1 ❌	unit	96m 43s	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 42s	The patch does not generate ASF License warnings.
		164m 6s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
	hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy
	hadoop.hdfs.TestReconstructStripedFile
	hadoop.hdfs.tools.TestDFSAdminWithHA
	hadoop.hdfs.TestGetFileChecksum

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2052/1/artifact/out/Dockerfile
GITHUB PR	#2052
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 0397bc78377d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `704409d`
Default Java	Private Build-1.8.0_252-8u252-b09-1~18.04-b09
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-2052/1/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-2052/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-2052/1/testReport/
Max. process+thread count	4612 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-2052/1/console
versions	git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

sodonnel · 2020-06-04T08:06:34Z

...-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java

If you like, you can change this block to below (Java 8 feature):

List<ReplicaInfo> blocks = blkToInvalidate.computeIfAbsent(bpid, (k) -> new ArrayList<>());

This will return the existing key if it exists, or create a new one it does not.

Just thinking - this fix will need to go on all branches back into the 2.8 branch, which I think still uses Java 7. Therefore it would be ideal to have the computeIfAbsent method for trunk and 3.x but we will need a patch like this existing one for branch 2.

@sodonnel Thank you for reviewing this!

Okay, I will change the code for your review here. And after this is committed to trunk, I will make a new PR for branch 2, which is like the original code.

hadoop-yetus · 2020-06-04T10:49:15Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	25m 24s	trunk passed
+1 💚	compile	1m 30s	trunk passed
+1 💚	checkstyle	0m 58s	trunk passed
+1 💚	mvnsite	1m 34s	trunk passed
+1 💚	shadedclient	16m 58s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 47s	trunk passed
+0 🆗	spotbugs	2m 52s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 48s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 11s	the patch passed
+1 💚	compile	0m 59s	the patch passed
+1 💚	javac	0m 59s	the patch passed
+1 💚	checkstyle	0m 42s	hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 122 unchanged - 3 fixed = 122 total (was 125)
+1 💚	mvnsite	1m 8s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	13m 43s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 39s	the patch passed
+1 💚	findbugs	3m 3s	the patch passed
		_ Other Tests _
-1 ❌	unit	96m 22s	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 38s	The patch does not generate ASF License warnings.
		170m 13s

Reason	Tests
Failed junit tests	hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy
	hadoop.hdfs.TestReconstructStripedFile
	hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
	hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier
	hadoop.hdfs.TestGetFileChecksum
	hadoop.hdfs.tools.TestDFSAdminWithHA

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2052/2/artifact/out/Dockerfile
GITHUB PR	#2052
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux a1c3b82f22b7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `5157118`
Default Java	Private Build-1.8.0_252-8u252-b09-1~18.04-b09
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-2052/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-2052/2/testReport/
Max. process+thread count	3826 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-2052/2/console
versions	git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…ing multiple DN's data directories

hadoop-yetus · 2020-06-04T15:29:14Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	18m 35s	trunk passed
+1 💚	compile	1m 10s	trunk passed
+1 💚	checkstyle	0m 51s	trunk passed
+1 💚	mvnsite	1m 16s	trunk passed
+1 💚	shadedclient	16m 0s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 47s	trunk passed
+0 🆗	spotbugs	2m 52s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 50s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 4s	the patch passed
+1 💚	compile	1m 3s	the patch passed
+1 💚	javac	1m 3s	the patch passed
+1 💚	checkstyle	0m 42s	hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 122 unchanged - 3 fixed = 122 total (was 125)
+1 💚	mvnsite	1m 8s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	13m 45s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 43s	the patch passed
+1 💚	findbugs	2m 54s	the patch passed
		_ Other Tests _
-1 ❌	unit	93m 20s	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 40s	The patch does not generate ASF License warnings.
		158m 39s

Reason	Tests
Failed junit tests	hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy
	hadoop.hdfs.TestReconstructStripedFile
	hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
	hadoop.hdfs.TestStripedFileAppend
	hadoop.hdfs.server.namenode.TestAddStripedBlockInFBR
	hadoop.hdfs.tools.TestDFSAdminWithHA

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2052/3/artifact/out/Dockerfile
GITHUB PR	#2052
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux b2dfcbfd107d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `5157118`
Default Java	Private Build-1.8.0_252-8u252-b09-1~18.04-b09
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-2052/3/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-2052/3/testReport/
Max. process+thread count	4050 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-2052/3/console
versions	git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

sodonnel · 2020-06-04T22:00:12Z

These changes LGTM +1

…ving multiple DN's data directories (#2052) Contributed by Toshihiro Suzuki. (cherry picked from commit 545a0a1)

…ving multiple DN's data directories (#2052) Contributed by Toshihiro Suzuki. (cherry picked from commit 545a0a1) Conflicts: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java

…ving multiple DN's data directories (#2052) Contributed by Toshihiro Suzuki. (cherry picked from commit 545a0a1) Conflicts: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java (cherry picked from commit e5a02a7)

…ving multiple DN's data directories (apache#2052) Contributed by Toshihiro Suzuki. Ref: ENGESC-2568 (cherry picked from commit 545a0a1) Conflicts: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java Change-Id: I3a3dd2a01066bcbffb3d4011768e9102a1ed7961 (cherry picked from commit 29ede28)

brfrn169 force-pushed the HDFS-15386 branch from 57e1e50 to 200c7c1 Compare June 4, 2020 07:57

sodonnel reviewed Jun 4, 2020

View reviewed changes

HDFS-15386 ReplicaNotFoundException keeps happening in DN after remov…

2071828

…ing multiple DN's data directories

brfrn169 force-pushed the HDFS-15386 branch from 200c7c1 to 2071828 Compare June 4, 2020 12:49

brfrn169 requested a review from sodonnel June 4, 2020 12:49

sodonnel approved these changes Jun 4, 2020

View reviewed changes

sodonnel changed the title ~~HDFS-15386 ReplicaNotFoundException keeps happening in DN after remov…~~ HDFS-15386. ReplicaNotFoundException keeps happening in DN after removing multiple DN's data directories. Jun 5, 2020

sodonnel merged commit 545a0a1 into apache:trunk Jun 5, 2020

asfgit pushed a commit that referenced this pull request Jun 5, 2020

HDFS-15386. ReplicaNotFoundException keeps happening in DN after remo…

ec8f371

…ving multiple DN's data directories (#2052) Contributed by Toshihiro Suzuki. (cherry picked from commit 545a0a1)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HDFS-15386. ReplicaNotFoundException keeps happening in DN after removing multiple DN's data directories. #2052

HDFS-15386. ReplicaNotFoundException keeps happening in DN after removing multiple DN's data directories. #2052

Uh oh!

brfrn169 commented Jun 4, 2020

Uh oh!

hadoop-yetus commented Jun 4, 2020

Uh oh!

sodonnel Jun 4, 2020

Uh oh!

sodonnel Jun 4, 2020

Uh oh!

brfrn169 Jun 4, 2020

Uh oh!

hadoop-yetus commented Jun 4, 2020

Uh oh!

hadoop-yetus commented Jun 4, 2020

Uh oh!

sodonnel commented Jun 4, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HDFS-15386. ReplicaNotFoundException keeps happening in DN after removing multiple DN's data directories. #2052

HDFS-15386. ReplicaNotFoundException keeps happening in DN after removing multiple DN's data directories. #2052

Uh oh!

Conversation

brfrn169 commented Jun 4, 2020

Uh oh!

hadoop-yetus commented Jun 4, 2020

Uh oh!

sodonnel Jun 4, 2020

Choose a reason for hiding this comment

Uh oh!

sodonnel Jun 4, 2020

Choose a reason for hiding this comment

Uh oh!

brfrn169 Jun 4, 2020

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Jun 4, 2020

Uh oh!

hadoop-yetus commented Jun 4, 2020

Uh oh!

sodonnel commented Jun 4, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants