-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HDFS-15385 Upgrade boost library to 1.72 #2051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💔 -1 overall
This message was automatically generated. |
The CI job runs on docker container and the dockerfile is at |
974afc7 to
12f58ae
Compare
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
12f58ae to
988edce
Compare
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
988edce to
82e1ace
Compare
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
82e1ace to
53b5944
Compare
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
53b5944 to
857ee1b
Compare
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
857ee1b to
74340c7
Compare
|
(!) A patch to the testing environment has been detected. |
74340c7 to
6fad8ff
Compare
|
(!) A patch to the testing environment has been detected. |
|
I've addressed all the mentioned issues and the build + tests are passing - #2051 (comment) except for the |
|
Thank you @GauthamBanasandra for cleaning up the code! |
* Upgraded boost library to version 1.72. * Removed the asio-1.10.2 that was checked in under libhdfspp/third_party directory.
* Changed version 1.76 to 1.72 in the comments.
6fad8ff to
9af2c17
Compare
It's my pleasure @aajisaka 😄. I believe Hadoop is a very mature code base. Even though I just started with Hadoop quite recently, it has really taught me a lot. I think there's a lot to be gained by contributing to this wonderful community. |
|
The timeout setting is here: Line 26 in 9821b94
I think the timeout can be increased to 20 hours. |
* The CI run was timing out, hence increasing it to 20 hours.
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
|
Just went through the change list, it's strange how nobody thought of dependency cleanup till now. I always thought of giving a similar patch but didn't make time. Checking out the entire code of a dependency should never be done, especially in a project of this size. Going forward, we should not allow anyone to checkout the dependency, we should expect the user to install the dependency. |
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
…to upgrade-boost
...p-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/util/StringUtil.cc
Show resolved
Hide resolved
|
Thank you for your update. The patch mostly looks good. Sorry for the late response. |
…to upgrade-boost
* WORKDIR is set to /root and must not be overridden. Using cd command instead.
|
@aajisaka I've rebased and addressed the comments. |
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
|
Would you add |
* Suppressing the warning DL3003 that is caused by Boost.
|
@aajisaka I've now added |
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
aajisaka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
Thank you @GauthamBanasandra for your work. I really appreciate it. |
Hi all,
I've upgraded the boost library to the latest. Please do take a look.
Also, I need some help with the CI. I saw that the whole boost library was checked in as part of the Hadoop codebase. From what I've learned, the third party code must be kept separate or must be pulled at the time of build and should definitely not be part of the codebase.
So, my changes expect that the boost libraries be installed in the system. Could someone with access to the CI machines please install the latest version of boost by running the following command -