HADOOP-17052. NetUtils.connect() throws unchecked exception (UnresolvedAddressException) causing clients to abort #2036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhirajh
changed the title
|
🎊 +1 overall
This message was automatically generated. |
liuml07
approved these changes
May 29, 2020
| socket.close(); | ||
| fail("Should not have connected"); | ||
| } catch (UnknownHostException ce) { | ||
| System.err.println("Got exception: " + ce); |
Member
There was a problem hiding this comment.
nit: I know this is following existing test case, but since we now have a logger, we can use this:
LOG.info("Got expected exception", uhe);
Sytem.err in test code is not friendly to test output/log interpretation.
| } | ||
| } catch (SocketTimeoutException ste) { | ||
| throw new ConnectTimeoutException(ste.getMessage()); | ||
| } catch (UnresolvedAddressException ue) { |
dhirajh
changed the title
|
🎊 +1 overall
This message was automatically generated. |
asfgit
pushed a commit
that referenced
this pull request
Jun 1, 2020
…edAddressException) causing clients to abort (#2036) Contributed by Dhiraj Hegde. Signed-off-by: Mingliang Liu <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Jun 1, 2020
…edAddressException) causing clients to abort (#2036) Contributed by Dhiraj Hegde. Signed-off-by: Mingliang Liu <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Jun 1, 2020
…edAddressException) causing clients to abort (#2036) Contributed by Dhiraj Hegde. Signed-off-by: Mingliang Liu <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Jun 1, 2020
…edAddressException) causing clients to abort (#2036) Contributed by Dhiraj Hegde. Signed-off-by: Mingliang Liu <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Jun 1, 2020
…edAddressException) causing clients to abort (#2036) Contributed by Dhiraj Hegde. Signed-off-by: Mingliang Liu <[email protected]>
jojochuang
pushed a commit
to jojochuang/hadoop
that referenced
this pull request
May 23, 2023
…edAddressException) causing clients to abort (apache#2036) Contributed by Dhiraj Hegde. Signed-off-by: Mingliang Liu <[email protected]> (cherry picked from commit 9fe4c37) Change-Id: I67d527ad454567fc4b4476de64072d8bdd941d85
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute