HDFS-15168: ABFS enhancement to translate AAD Object to Linux idenities #1858
Conversation
|
@virajith, @ThomasMarquardt, @bilaharith - Please review. |
|
Integration Test results (after the javadoc and style fixes) - East US2: |
steveloughran
left a comment
steveloughran
left a comment
There was a problem hiding this comment.
design looks good, as do javadocs on text format. Some tuning needed before it's ready to go in
There was a problem hiding this comment.
nit: add a "." to the end of each sentence, here and below, to keep javadoc happy
There was a problem hiding this comment.
nit: add a space between the java. and the org.apache block
There was a problem hiding this comment.
nit: add trailing "."
There was a problem hiding this comment.
nit: add trailing "."
There was a problem hiding this comment.
see the other comments about import ordering
There was a problem hiding this comment.
no need for this.
2. put the ? on a new line; the : should also go there; the ?: sequence is significant enough to highligh
There was a problem hiding this comment.
this will be very noisy if it happens a lot. Is that what you want?
also: it doesn't provide the information you'd need to debug the failure from the logs
Preferred
- Error message includes string being looked up and resolved line.
- full stack at DEBUG only
There was a problem hiding this comment.
see all comments in previous block and apply here as appropriate
There was a problem hiding this comment.
- add use of "#" as comment
There was a problem hiding this comment.
@steveloughran, clarification - you would want # with <pre> block or just #?
* Group identity file should be delimited by colon in below format.
* <pre>
* # OBJ_ID:GROUP_NAME:GROUP_ID:SGP_NAME
* </pre>
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
3 participants
ABFS driver enhancement - Allow customizable translation from AAD SPNs and security groups to Linux user and group
Integration Test results - East US2:
Tests: 1255 Errors: 0 Failures: 0 Skipped: 390`