Skip to content

Conversation

@steveloughran
Copy link
Contributor

Followup to #1791

Add an extra test to verify FilterOutputStream close in try-with-resources

All seems good -tested azure cardiff

Change-Id: Iaa9c5f9602d7a4f0b8c9d8bd71f308c87e4d525a

NOTICE

Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

Add an extra test to verify FilterOutputStream close in try-with-resources

All seems good

Change-Id: Iaa9c5f9602d7a4f0b8c9d8bd71f308c87e4d525a
@steveloughran
Copy link
Contributor Author

tried to expand the test but no, failed to be able to trigger any problems with FilterOutputStream;

hopefully that means: no problem

Add an extra test to verify FilterOutputStream close in try-with-resources

All seems good

Change-Id: Iaa9c5f9602d7a4f0b8c9d8bd71f308c87e4d525a
@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 30m 31s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 18m 10s trunk passed
+1 💚 compile 0m 31s trunk passed
+1 💚 checkstyle 0m 25s trunk passed
+1 💚 mvnsite 0m 34s trunk passed
+1 💚 shadedclient 13m 37s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 27s trunk passed
+0 🆗 spotbugs 0m 51s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 0m 49s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 27s the patch passed
+1 💚 compile 0m 24s the patch passed
+1 💚 javac 0m 24s the patch passed
+1 💚 checkstyle 0m 16s the patch passed
+1 💚 mvnsite 0m 26s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 13m 16s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 23s the patch passed
+1 💚 findbugs 0m 54s the patch passed
_ Other Tests _
+1 💚 unit 1m 22s hadoop-azure in the patch passed.
+1 💚 asflicense 0m 31s The patch does not generate ASF License warnings.
84m 37s
Subsystem Report/Notes
Docker Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1809/2/artifact/out/Dockerfile
GITHUB PR #1809
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux af55442296b2 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / a0ff42d
Default Java 1.8.0_232
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1809/2/testReport/
Max. process+thread count 411 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1809/2/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@apache apache deleted a comment from hadoop-yetus Jan 17, 2020
@steveloughran
Copy link
Contributor Author

@ThomasMarquardt -this completes the previous patch with one extra test; shows that filterFS is apparently happy.

Copy link
Contributor

@ThomasMarquardt ThomasMarquardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1

@steveloughran
Copy link
Contributor Author

thanks

@steveloughran
Copy link
Contributor Author

merged to branch-3.2+

@steveloughran steveloughran deleted the abfs/HADOOP-16785-part-2 branch October 15, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants