Skip to content

Conversation

@steveloughran
Copy link
Contributor

This moves the import of a java module to the preferred place in the import ordering.

I know this is minor but it's good to at least try to keep imports under control. If I'd noticed the problem earlier I'd have done the reordering during the commit process.

Change-Id: I1a594e3d954554a72c2b71c954eda0ae940a8f70

This moves the import of a java module to the preferred place in the import ordering.

Change-Id: I1a594e3d954554a72c2b71c954eda0ae940a8f70
@steveloughran
Copy link
Contributor Author

followup to #1754

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 23m 25s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 21m 17s trunk passed
-1 ❌ compile 11m 11s root in trunk failed.
+1 💚 checkstyle 0m 45s trunk passed
+1 💚 mvnsite 1m 24s trunk passed
+1 💚 shadedclient 17m 24s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 30s trunk passed
+0 🆗 spotbugs 2m 17s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 2m 13s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 51s the patch passed
+1 💚 compile 18m 28s the patch passed
-1 ❌ javac 18m 28s root generated 194 new + 1674 unchanged - 0 fixed = 1868 total (was 1674)
+1 💚 checkstyle 0m 55s the patch passed
+1 💚 mvnsite 1m 40s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 14m 11s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 25s the patch passed
+1 💚 findbugs 2m 16s the patch passed
_ Other Tests _
+1 💚 unit 9m 17s hadoop-common in the patch passed.
+1 💚 asflicense 0m 49s The patch does not generate ASF License warnings.
130m 9s
Subsystem Report/Notes
Docker Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1799/1/artifact/out/Dockerfile
GITHUB PR #1799
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux f69c38cecfe4 4.15.0-70-generic #79-Ubuntu SMP Tue Nov 12 10:36:11 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / d1f5976
Default Java 1.8.0_232
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1799/1/artifact/out/branch-compile-root.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-1799/1/artifact/out/diff-compile-javac-root.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1799/1/testReport/
Max. process+thread count 1327 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1799/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@aajisaka aajisaka self-requested a review January 8, 2020 01:13
Copy link
Member

@aajisaka aajisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thank you for the cleanup.

@steveloughran steveloughran merged commit bb1aed4 into apache:trunk Jan 8, 2020
RogPodge pushed a commit to RogPodge/hadoop that referenced this pull request Mar 25, 2020
This moves the import of a java module to the preferred place in the import ordering.

Change-Id: I1a594e3d954554a72c2b71c954eda0ae940a8f70
@steveloughran steveloughran deleted the s3/HADOOP-16751-duration-followup branch October 15, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants