HADOOP-16455. ABFS: Implement FileSystem.access() method. #1711

bilaharith · 2019-11-13T03:26:16Z

mvn -T 1C -Dparallel-tests=abfs -Dscale -DtestsThreadCount=8 clean verify

Driver test results using an account with namespace support in Central India:

[INFO] Tests run: 42, Failures: 0, Errors: 0, Skipped: 0
[ERROR] Errors:
[ERROR] ITestAzureBlobFileSystemCLI>AbstractAbfsIntegrationTest.setup:137 ? AbfsRestOperation
[INFO]
[ERROR] Tests run: 405, Failures: 0, Errors: 1, Skipped: 33
[WARNING] Tests run: 192, Failures: 0, Errors: 0, Skipped: 24

Driver test results using an account without namespace support in Central India:

NSD
[INFO] Tests run: 42, Failures: 0, Errors: 0, Skipped: 0
[WARNING] Tests run: 405, Failures: 0, Errors: 0, Skipped: 220
WARNING] Tests run: 192, Failures: 0, Errors: 0, Skipped: 24

snvijaya · 2019-11-13T09:32:12Z

...ls/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/ConfigurationKeys.java

  public static final String FS_AZURE_USER_AGENT_PREFIX_KEY = "fs.azure.user.agent.prefix";
  public static final String FS_AZURE_SSL_CHANNEL_MODE_KEY = "fs.azure.ssl.channel.mode";
+  public static final String FS_AZURE_ENABLE_CHECK_ACCESS = "fs.azure.enable.check.access";
+  /** Provides a config to enable the checkAccess API


Move the comments above the new config.

snvijaya · 2019-11-13T09:42:24Z

...tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java

+      return;
+    }
+    String relativePath = path.isRoot() ? "" : ("/" + getRelativePath(path));
+    throwFileNotFoundIfNotExists(relativePath);


We should not do GetFileStatus call. Response for checkaccess call should be the source of response to client.

snvijaya · 2019-11-13T10:53:15Z

...tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java

+    AbfsRestOperation abfsOp = this.client
+        .checkAccess(relativePath, mode.SYMBOL);
+    if (abfsOp.getResult().getStatusCode() != CHECK_ACCESS_SUCCESS) {
+      throw new AccessControlException();


This is going to return AccessControlException for any error server response, even if its a server system error.
If server is already returning AccessControlException in its response for forbidden, then can we not handle the response as other APIs do for error scenarios.

steveloughran

LGTM, changes suggested in tests so failures are more meaningful.

PR #1611 is about to go in -it will show what extra instrumentation you need to add the round the new rest call

hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java

...ls/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/ConfigurationKeys.java

...p-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemCheckAccess.java

steveloughran · 2019-11-13T15:04:33Z

...p-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemCheckAccess.java

+      this.testUserFs.access(path, fsAction);
+    } catch (AccessControlException e) {
+      isAccessible = false;
+    } catch (IOException e) {


no need to catch and rethrow

steveloughran · 2019-11-13T15:04:36Z

...p-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemCheckAccess.java

+    }
+    return isAccessible;
+  }
+}


add a newline

hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AbfsConfiguration.java

virajith · 2019-11-14T03:33:54Z

hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java

   * @throws IOException                   see specific implementation
   */
  @Override
  public void access(final Path path, FsAction mode) throws IOException {


Should {{getIsNamespaceEnabled()}} be checked? In the test, you use modifyAclEntries which requires hierarchical namespace to be enabled. Shouldn't this be the case for access() as well?

virajith · 2019-11-14T03:34:31Z

...tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java

+      throws AzureBlobFileSystemException {
+    LOG.debug("access for filesystem: {}, path: {}, mode: {}",
+        this.client.getFileSystem(), path, mode);
+    if (!this.abfsConfiguration.isCheckAccessEnabled()) {


Why is this needed as a configuration? Shouldn't it be always valid?

Currently the ABFS access() is a noop. Adding the functionality with a config flag to keep it backward compatible.

goiri · 2019-11-15T17:34:55Z

...ls/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/ConfigurationKeys.java

  public static final String FS_AZURE_USER_AGENT_PREFIX_KEY = "fs.azure.user.agent.prefix";
  public static final String FS_AZURE_SSL_CHANNEL_MODE_KEY = "fs.azure.ssl.channel.mode";
+  /** Provides a config to enable/disable the checkAccess API.
+   *  By default this will be false.   */


This comment should be in DEFAULT_ENABLE_CHECK_ACCESS.

hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java

steveloughran

Happy with the explicit changes, we still have the IDE playing import games.

I'm =0 on whether the access changes should be a config option and what the default should be.

From a test perspective, having it fixed to true is best.
If optional, from a UX perspective, enabling it the most forward looking
but from a backwards compatibility perspective -default = false

Now, what about documentation?

...p-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemCheckAccess.java

hadoop-tools/hadoop-azure/src/site/markdown/abfs.md

steveloughran · 2019-11-19T10:51:18Z

...tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java


 import java.io.Closeable;
 import java.io.File;
+import java.io.FileNotFoundException;


not needed according to checkstyle

steveloughran · 2019-11-19T10:54:00Z

Checkstyle

./hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java:22:import java.io.FileNotFoundException;:8: Unused import - java.io.FileNotFoundException. [UnusedImports]
./hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java:94:import org.apache.hadoop.security.AccessControlException;:8: Unused import - org.apache.hadoop.security.AccessControlException. [UnusedImports]
./hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemCheckAccess.java:219:  public void testFsActionREAD_EXECUTE() throws Exception {:15: Name 'testFsActionREAD_EXECUTE' must match pattern '^[a-z][a-zA-Z0-9]*$'. [MethodName]
./hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemCheckAccess.java:235:  public void testFsActionWRITE_EXECUTE() throws Exception {:15: Name 'testFsActionWRITE_EXECUTE' must match pattern '^[a-z][a-zA-Z0-9]*$'. [MethodN

I'm not worried about those test name mismatches as they make sense and they are consistent with the rest.

Unused imports should be removed.

Other than that: it's ready to go in!

hadoop-yetus · 2019-11-20T04:50:45Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 37s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	markdownlint	0m 0s	markdownlint was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	18m 18s	trunk passed
+1 💚	compile	0m 31s	trunk passed
+1 💚	checkstyle	0m 23s	trunk passed
+1 💚	mvnsite	0m 33s	trunk passed
+1 💚	shadedclient	13m 26s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 26s	trunk passed
+0 🆗	spotbugs	0m 51s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	0m 50s	trunk passed
-0 ⚠️	patch	1m 7s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 28s	the patch passed
+1 💚	compile	0m 23s	the patch passed
+1 💚	javac	0m 23s	the patch passed
+1 💚	checkstyle	0m 17s	hadoop-tools/hadoop-azure: The patch generated 0 new + 6 unchanged - 1 fixed = 6 total (was 7)
+1 💚	mvnsite	0m 26s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	13m 22s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 23s	the patch passed
+1 💚	findbugs	0m 52s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 23s	hadoop-azure in the patch passed.
+1 💚	asflicense	0m 32s	The patch does not generate ASF License warnings.
		54m 42s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1711/8/artifact/out/Dockerfile
GITHUB PR	#1711
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint
uname	Linux 1105110b5283 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `0b50aa2`
Default Java	1.8.0_222
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1711/8/testReport/
Max. process+thread count	453 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1711/8/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-11-20T05:25:32Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	markdownlint	0m 0s	markdownlint was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	19m 52s	trunk passed
+1 💚	compile	0m 32s	trunk passed
+1 💚	checkstyle	0m 23s	trunk passed
+1 💚	mvnsite	0m 36s	trunk passed
+1 💚	shadedclient	15m 28s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 25s	trunk passed
+0 🆗	spotbugs	0m 56s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	0m 53s	trunk passed
-0 ⚠️	patch	1m 12s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 30s	the patch passed
+1 💚	compile	0m 25s	the patch passed
+1 💚	javac	0m 25s	the patch passed
+1 💚	checkstyle	0m 17s	hadoop-tools/hadoop-azure: The patch generated 0 new + 6 unchanged - 1 fixed = 6 total (was 7)
+1 💚	mvnsite	0m 28s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	14m 30s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 22s	the patch passed
+1 💚	findbugs	0m 53s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 21s	hadoop-azure in the patch passed.
+1 💚	asflicense	0m 30s	The patch does not generate ASF License warnings.
		59m 38s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1711/9/artifact/out/Dockerfile
GITHUB PR	#1711
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint
uname	Linux 21aa44e94280 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `0b50aa2`
Default Java	1.8.0_222
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1711/9/testReport/
Max. process+thread count	419 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1711/9/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

bilaharith · 2019-11-20T06:25:12Z

mvn -T 1C -Dparallel-tests=abfs -Dscale -DtestsThreadCount=1 clean verify

Driver test results using an account with namespace support in Central India:
[INFO] Tests run: 52, Failures: 0, Errors: 0, Skipped: 0
[[ERROR] Errors:
[ERROR] ITestAzureBlobFileSystemCLI>AbstractAbfsIntegrationTest.setup:137 ? AbfsRestOperation
[INFO]
[ERROR] Tests run: 407, Failures: 0, Errors: 1, Skipped: 35
[WARNING] Tests run: 192, Failures: 0, Errors: 0, Skipped: 24

Driver test results using an account without namespace support in Central India:
[INFO] Tests run: 52, Failures: 0, Errors: 0, Skipped: 0
[WARNING] Tests run: 407, Failures: 0, Errors: 0, Skipped: 221
[WARNING] Tests run: 192, Failures: 0, Errors: 0, Skipped: 24

hadoop-yetus · 2019-11-20T07:22:21Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	markdownlint	0m 0s	markdownlint was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	20m 14s	trunk passed
+1 💚	compile	0m 31s	trunk passed
+1 💚	checkstyle	0m 19s	trunk passed
+1 💚	mvnsite	0m 31s	trunk passed
+1 💚	shadedclient	13m 13s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 26s	trunk passed
+0 🆗	spotbugs	0m 51s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	0m 48s	trunk passed
-0 ⚠️	patch	1m 6s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 27s	the patch passed
+1 💚	compile	0m 24s	the patch passed
+1 💚	javac	0m 24s	the patch passed
+1 💚	checkstyle	0m 16s	hadoop-tools/hadoop-azure: The patch generated 0 new + 6 unchanged - 1 fixed = 6 total (was 7)
+1 💚	mvnsite	0m 27s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	13m 20s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 23s	the patch passed
+1 💚	findbugs	0m 53s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 20s	hadoop-azure in the patch passed.
+1 💚	asflicense	0m 30s	The patch does not generate ASF License warnings.
		56m 23s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1711/10/artifact/out/Dockerfile
GITHUB PR	#1711
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint
uname	Linux 99d2cae4db34 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `0b50aa2`
Default Java	1.8.0_222
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1711/10/testReport/
Max. process+thread count	412 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1711/10/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

...tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java

hadoop-yetus · 2019-11-26T06:05:32Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	markdownlint	0m 0s	markdownlint was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	18m 3s	trunk passed
+1 💚	compile	0m 31s	trunk passed
+1 💚	checkstyle	0m 23s	trunk passed
+1 💚	mvnsite	0m 34s	trunk passed
+1 💚	shadedclient	13m 27s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 26s	trunk passed
+0 🆗	spotbugs	0m 49s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	0m 48s	trunk passed
-0 ⚠️	patch	1m 6s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 27s	the patch passed
+1 💚	compile	0m 24s	the patch passed
+1 💚	javac	0m 24s	the patch passed
+1 💚	checkstyle	0m 16s	hadoop-tools/hadoop-azure: The patch generated 0 new + 6 unchanged - 1 fixed = 6 total (was 7)
+1 💚	mvnsite	0m 26s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	13m 25s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 22s	the patch passed
+1 💚	findbugs	0m 53s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 19s	hadoop-azure in the patch passed.
+1 💚	asflicense	0m 31s	The patch does not generate ASF License warnings.
		54m 30s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1711/11/artifact/out/Dockerfile
GITHUB PR	#1711
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint
uname	Linux dc576d57d35d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `6c20512`
Default Java	1.8.0_222
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1711/11/testReport/
Max. process+thread count	411 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1711/11/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-11-26T06:44:39Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 43s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	markdownlint	0m 0s	markdownlint was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	22m 19s	trunk passed
+1 💚	compile	0m 32s	trunk passed
+1 💚	checkstyle	0m 25s	trunk passed
+1 💚	mvnsite	0m 36s	trunk passed
+1 💚	shadedclient	15m 44s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 26s	trunk passed
+0 🆗	spotbugs	0m 57s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	0m 55s	trunk passed
-0 ⚠️	patch	1m 14s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 30s	the patch passed
+1 💚	compile	0m 25s	the patch passed
+1 💚	javac	0m 25s	the patch passed
+1 💚	checkstyle	0m 17s	hadoop-tools/hadoop-azure: The patch generated 0 new + 6 unchanged - 1 fixed = 6 total (was 7)
+1 💚	mvnsite	0m 29s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	15m 16s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 23s	the patch passed
+1 💚	findbugs	0m 58s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 22s	hadoop-azure in the patch passed.
+1 💚	asflicense	0m 30s	The patch does not generate ASF License warnings.
		63m 32s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1711/12/artifact/out/Dockerfile
GITHUB PR	#1711
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint
uname	Linux b006cf3de829 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `6c20512`
Default Java	1.8.0_222
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1711/12/testReport/
Max. process+thread count	448 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1711/12/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

DadanielZ

Look great, +1 :)

steveloughran · 2019-11-27T15:57:18Z

+1, merged via github. If you want on branch-3.2, cherry pick, retest and provide a new PR

bilaharith added 3 commits November 12, 2019 13:03

HADOOP-16455 Implemented FileSystem.access() for ABFS

789a6e4

Fixes in test case

178441b

HADOOP-16455 Added testcase for FileNotFound

5346b60

snvijaya reviewed Nov 13, 2019

View reviewed changes

Addressed the review comments

c4c9323

steveloughran mentioned this pull request Nov 13, 2019

HADOOP-16612 Track Azure Blob File System client-perceived latency #1611

Closed

steveloughran requested changes Nov 13, 2019

View reviewed changes

virajith reviewed Nov 14, 2019

View reviewed changes

goiri changed the title ~~Hadoop 16455~~ HADOOP-16455. ABFS: Implement FileSystem.access() method. Nov 14, 2019

apache deleted a comment from hadoop-yetus Nov 14, 2019

Addressed the review comments

88c72be

goiri reviewed Nov 15, 2019

View reviewed changes

hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java Show resolved Hide resolved

steveloughran requested changes Nov 17, 2019

View reviewed changes

...p-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemCheckAccess.java Outdated Show resolved Hide resolved

...p-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemCheckAccess.java Show resolved Hide resolved

bilaharith added 2 commits November 19, 2019 12:24

Addressed the review comments

50b8e7e

Minor formattings

7991515

hadoop-yetus reviewed Nov 19, 2019

View reviewed changes

hadoop-tools/hadoop-azure/src/site/markdown/abfs.md Outdated Show resolved Hide resolved

hadoop-yetus reviewed Nov 19, 2019

View reviewed changes

hadoop-tools/hadoop-azure/src/site/markdown/abfs.md Outdated Show resolved Hide resolved

Removed trailing space

c7cb783

apache deleted a comment from hadoop-yetus Nov 19, 2019

steveloughran reviewed Nov 19, 2019

View reviewed changes

apache deleted a comment from hadoop-yetus Nov 19, 2019

bilaharith and others added 2 commits November 20, 2019 09:20

Merge branch 'trunk' into HADOOP-16455

ecbea36

Checkstyle fixes

8b7588b

Test case refactoring

5c8e39e

bilaharith requested a review from steveloughran November 25, 2019 10:25

DadanielZ reviewed Nov 26, 2019

View reviewed changes

...tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java Show resolved Hide resolved

bilaharith added 2 commits November 26, 2019 10:36

Added perf tracking for access method

899ad6d

Fix on the perf tracking

4ddd7f8

DadanielZ approved these changes Nov 27, 2019

View reviewed changes

apache deleted a comment from hadoop-yetus Nov 27, 2019

steveloughran merged commit 9e69628 into apache:trunk Nov 27, 2019

Uh oh!

HADOOP-16455. ABFS: Implement FileSystem.access() method. #1711

HADOOP-16455. ABFS: Implement FileSystem.access() method. #1711

Uh oh!

Conversation

bilaharith commented Nov 13, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

steveloughran left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

steveloughran left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

steveloughran commented Nov 19, 2019

Uh oh!

hadoop-yetus commented Nov 20, 2019

Uh oh!

hadoop-yetus commented Nov 20, 2019

Uh oh!

bilaharith commented Nov 20, 2019

Uh oh!

hadoop-yetus commented Nov 20, 2019

Uh oh!

Uh oh!

hadoop-yetus commented Nov 26, 2019

Uh oh!

hadoop-yetus commented Nov 26, 2019

Uh oh!

DadanielZ left a comment

Choose a reason for hiding this comment

Uh oh!

steveloughran commented Nov 27, 2019

Uh oh!