HDFS-14907. [Dynamometer] DataNode can't find junit jar when using Hadoop-3 binary #1680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| extraClasspathDir="$(pwd)/additionalClasspath/" | ||
| mkdir -p "${extraClasspathDir}" | ||
|
|
||
| junitClassPath="$(find $hadoopHome -name "junit*.jar" | head -n 1)" |
There was a problem hiding this comment.
shellcheck:24: note: Double quote to prevent globbing and word splitting. [SC2086]
|
💔 -1 overall
This message was automatically generated. |
| extraClasspathDir="$(pwd)/additionalClasspath/" | ||
| mkdir -p "${extraClasspathDir}" | ||
|
|
||
| junitClassPath="$(find ${hadoopHome} -name "junit*.jar" | head -n 1)" |
There was a problem hiding this comment.
shellcheck:24: note: Double quote to prevent globbing and word splitting. [SC2086]
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
xkrogen
requested changes
Oct 28, 2019
Contributor
xkrogen
left a comment
xkrogen
left a comment
There was a problem hiding this comment.
Nice! Looks like a good change. Left some minor comments.
| extraClasspathDir="$(pwd)/additionalClasspath/" | ||
| mkdir -p "${extraClasspathDir}" | ||
|
|
||
| junitClassPath="$(find "${hadoopHome}" -name "junit*.jar" | head -n 1)" |
Contributor
There was a problem hiding this comment.
Can we add a comment here explaining why this is necessary?
|
|
||
| junitClassPath="$(find "${hadoopHome}" -name "junit*.jar" | head -n 1)" | ||
| if [[ -z "$junitClassPath" ]]; then | ||
| echo "Can't find junit jar file." |
Contributor
There was a problem hiding this comment.
Can we include where the JAR was searched (hadoopHome)?
Member
Author
|
Thanks for your reviews, @xkrogen! Updated the PR. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
LGTM! Thanks @tasanuma ! |
RogPodge
pushed a commit
to RogPodge/hadoop
that referenced
this pull request
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.