HDFS-14308. DFSStripedInputStream curStripeBuf is not freed by unbuff… #1667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
I think the patch makes sense to me. |
avijayanhwx
reviewed
Oct 23, 2019
| public synchronized void unbuffer() { | ||
| closeCurrentBlockReaders(); | ||
| if (curStripeBuf != null) { | ||
| curStripeBuf.clear(); |
Contributor
There was a problem hiding this comment.
Probably a minor issue. Won't we be doing this curStripeBuf.clear() step twice in the unbuffer method? The first time is in Line #127-129.
Contributor
Author
There was a problem hiding this comment.
@avijayanhwx Thanks for review! Good point! It cleared twice, I removed the clear in the unbuffer. Could you help review again? Thanks!
Contributor
There was a problem hiding this comment.
Thanks for the changes. I am trying to understand why the parityBuf clear step was removed.
Contributor
Author
There was a problem hiding this comment.
@avijayanhwx Thanks for review again! The parityBuf can be cleared in method getParityBuffer() line # 133 - 140
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
LGTM +1 |
Contributor
Author
|
@jojochuang I saw you suggest change the "closeCurrentBlockReaders()" to "super.unbuffer()", just want to confirm, will I need to do the changes? Because I got the mail but can NOT find the comments in the PR. Thanks! |
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
+1 |
asfgit
pushed a commit
that referenced
this pull request
Oct 25, 2019
…er() (#1667) Reviewed-by: Aravindan Vijayan <[email protected]> Reviewed-by: Wei-Chiu Chuang <[email protected]> (cherry picked from commit 30db895) (cherry picked from commit 9316ca1)
asfgit
pushed a commit
that referenced
this pull request
Oct 25, 2019
…er() (#1667) Reviewed-by: Aravindan Vijayan <[email protected]> Reviewed-by: Wei-Chiu Chuang <[email protected]> (cherry picked from commit 30db895)
amahussein
pushed a commit
to amahussein/hadoop
that referenced
this pull request
Oct 29, 2019
…er() (apache#1667) Reviewed-by: Aravindan Vijayan <[email protected]> Reviewed-by: Wei-Chiu Chuang <[email protected]>
jojochuang
pushed a commit
to jojochuang/hadoop
that referenced
this pull request
Feb 2, 2020
…er() (apache#1667) Reviewed-by: Aravindan Vijayan <[email protected]> Reviewed-by: Wei-Chiu Chuang <[email protected]> (cherry picked from commit 30db895) (cherry picked from commit 9316ca1) (cherry picked from commit 44ca2fe) Change-Id: I6f2a60f637080fc23b99744d86b67013504c634a
RogPodge
pushed a commit
to RogPodge/hadoop
that referenced
this pull request
Mar 25, 2020
…er() (apache#1667) Reviewed-by: Aravindan Vijayan <[email protected]> Reviewed-by: Wei-Chiu Chuang <[email protected]>
bentito
pushed a commit
to bentito/hadoop
that referenced
this pull request
Dec 2, 2020
…er() (apache#1667) Reviewed-by: Aravindan Vijayan <[email protected]> Reviewed-by: Wei-Chiu Chuang <[email protected]> (cherry picked from commit 30db895) (cherry picked from commit 9316ca1)
bentito
pushed a commit
to bentito/hadoop
that referenced
this pull request
Dec 3, 2020
…er() (apache#1667) Reviewed-by: Aravindan Vijayan <[email protected]> Reviewed-by: Wei-Chiu Chuang <[email protected]> (cherry picked from commit 30db895) (cherry picked from commit 9316ca1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…er()
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute