Skip to content

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Make RAT check ignore ozone-recon-web/build directory.

During ozone-recon to recon rename (HDDS-2044) the directory ignored by RAT was changed to recon-web/build, but the real directory is still ozone-recon-web.

The mismatch is not a problem for CI because it doesn't build anything before the RAT check, so the build directory is not present.

https://issues.apache.org/jira/browse/HDDS-2234

How was this patch tested?

$ mvn -f pom.ozone.xml -Dmaven.javadoc.skip=true -DskipTests clean package
...
[INFO] BUILD SUCCESS

$ ls hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/build
asset-manifest.json
favicon.ico
index.html
manifest.json
precache-manifest.2d16a2d17952080aea9277dca13a2b39.js
service-worker.js
static

$ hadoop-ozone/dev-support/checks/rat.sh
...
[INFO] BUILD SUCCESS

$ echo $?
0

@adoroszlai
Copy link
Contributor Author

/label ozone

@elek elek added the ozone label Oct 3, 2019
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 767 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
-1 mvninstall 46 hadoop-hdds in trunk failed.
-1 mvninstall 46 hadoop-ozone in trunk failed.
-1 compile 23 hadoop-hdds in trunk failed.
-1 compile 17 hadoop-ozone in trunk failed.
+1 mvnsite 0 trunk passed
+1 shadedclient 1104 branch has no errors when building and testing our client artifacts.
-1 javadoc 23 hadoop-hdds in trunk failed.
-1 javadoc 19 hadoop-ozone in trunk failed.
_ Patch Compile Tests _
-1 mvninstall 39 hadoop-hdds in the patch failed.
-1 mvninstall 40 hadoop-ozone in the patch failed.
-1 compile 26 hadoop-hdds in the patch failed.
-1 compile 19 hadoop-ozone in the patch failed.
-1 javac 26 hadoop-hdds in the patch failed.
-1 javac 19 hadoop-ozone in the patch failed.
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 1 The patch has no ill-formed XML file.
+1 shadedclient 894 patch has no errors when building and testing our client artifacts.
-1 javadoc 24 hadoop-hdds in the patch failed.
-1 javadoc 19 hadoop-ozone in the patch failed.
_ Other Tests _
-1 unit 31 hadoop-hdds in the patch failed.
-1 unit 25 hadoop-ozone in the patch failed.
+1 asflicense 35 The patch does not generate ASF License warnings.
3247
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1580/1/artifact/out/Dockerfile
GITHUB PR #1580
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml
uname Linux 1500dcf8b9ff 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 0e026cb
Default Java 1.8.0_222
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1580/1/artifact/out/branch-mvninstall-hadoop-hdds.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1580/1/artifact/out/branch-mvninstall-hadoop-ozone.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1580/1/artifact/out/branch-compile-hadoop-hdds.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1580/1/artifact/out/branch-compile-hadoop-ozone.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1580/1/artifact/out/branch-javadoc-hadoop-hdds.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1580/1/artifact/out/branch-javadoc-hadoop-ozone.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1580/1/artifact/out/patch-mvninstall-hadoop-hdds.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1580/1/artifact/out/patch-mvninstall-hadoop-ozone.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1580/1/artifact/out/patch-compile-hadoop-hdds.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1580/1/artifact/out/patch-compile-hadoop-ozone.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-1580/1/artifact/out/patch-compile-hadoop-hdds.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-1580/1/artifact/out/patch-compile-hadoop-ozone.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1580/1/artifact/out/patch-javadoc-hadoop-hdds.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1580/1/artifact/out/patch-javadoc-hadoop-ozone.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1580/1/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1580/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1580/1/testReport/
Max. process+thread count 399 (vs. ulimit of 5500)
modules C: hadoop-ozone U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1580/1/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@anuengineer anuengineer merged commit 47d721d into apache:trunk Oct 3, 2019
@anuengineer
Copy link
Contributor

Thank you for taking care of this issue.

@adoroszlai adoroszlai deleted the HDDS-2234 branch October 4, 2019 03:54
@adoroszlai
Copy link
Contributor Author

Thanks @anuengineer for reporting this issue and reviewing/committing the fix.

amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019
RogPodge pushed a commit to RogPodge/hadoop that referenced this pull request Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants