Skip to content

Conversation

@bharatviswa504
Copy link
Contributor

No description provided.

@bharatviswa504 bharatviswa504 requested a review from arp7 October 1, 2019 17:37
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 74 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
-1 mvninstall 31 hadoop-hdds in trunk failed.
-1 mvninstall 33 hadoop-ozone in trunk failed.
-1 compile 22 hadoop-hdds in trunk failed.
-1 compile 15 hadoop-ozone in trunk failed.
-0 checkstyle 26 The patch fails to run checkstyle in hadoop-ozone
+1 mvnsite 0 trunk passed
+1 shadedclient 850 branch has no errors when building and testing our client artifacts.
-1 javadoc 23 hadoop-hdds in trunk failed.
-1 javadoc 21 hadoop-ozone in trunk failed.
0 spotbugs 952 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 33 hadoop-hdds in trunk failed.
-1 findbugs 21 hadoop-ozone in trunk failed.
_ Patch Compile Tests _
-1 mvninstall 35 hadoop-hdds in the patch failed.
-1 mvninstall 38 hadoop-ozone in the patch failed.
-1 compile 26 hadoop-hdds in the patch failed.
-1 compile 19 hadoop-ozone in the patch failed.
-1 javac 26 hadoop-hdds in the patch failed.
-1 javac 19 hadoop-ozone in the patch failed.
-0 checkstyle 29 The patch fails to run checkstyle in hadoop-ozone
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 726 patch has no errors when building and testing our client artifacts.
-1 javadoc 22 hadoop-hdds in the patch failed.
-1 javadoc 20 hadoop-ozone in the patch failed.
-1 findbugs 33 hadoop-hdds in the patch failed.
-1 findbugs 21 hadoop-ozone in the patch failed.
_ Other Tests _
-1 unit 29 hadoop-hdds in the patch failed.
-1 unit 27 hadoop-ozone in the patch failed.
+1 asflicense 34 The patch does not generate ASF License warnings.
2400
Subsystem Report/Notes
Docker Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/Dockerfile
GITHUB PR #1567
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 8f7447798b62 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 1921e94
Default Java 1.8.0_222
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/branch-mvninstall-hadoop-hdds.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/branch-mvninstall-hadoop-ozone.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/branch-compile-hadoop-hdds.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/branch-compile-hadoop-ozone.txt
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out//home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-1567/out/maven-branch-checkstyle-hadoop-ozone.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/branch-javadoc-hadoop-hdds.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/branch-javadoc-hadoop-ozone.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/branch-findbugs-hadoop-hdds.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/branch-findbugs-hadoop-ozone.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/patch-mvninstall-hadoop-hdds.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/patch-mvninstall-hadoop-ozone.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/patch-compile-hadoop-hdds.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/patch-compile-hadoop-ozone.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/patch-compile-hadoop-hdds.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/patch-compile-hadoop-ozone.txt
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out//home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-1567/out/maven-patch-checkstyle-hadoop-ozone.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/patch-javadoc-hadoop-hdds.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/patch-javadoc-hadoop-ozone.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/patch-findbugs-hadoop-hdds.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/patch-findbugs-hadoop-ozone.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/testReport/
Max. process+thread count 412 (vs. ulimit of 5500)
modules C: hadoop-hdds/common U: hadoop-hdds/common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@bharatviswa504 bharatviswa504 self-assigned this Oct 1, 2019
Copy link
Contributor

@arp7 arp7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@bharatviswa504
Copy link
Contributor Author

bharatviswa504 commented Oct 2, 2019

Thank You @arp7 for the review.
Test failures are not related to this patch.
I will commit this to the trunk.

@bharatviswa504 bharatviswa504 merged commit 53ed78b into apache:trunk Oct 2, 2019
amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019
RogPodge pushed a commit to RogPodge/hadoop that referenced this pull request Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants