HDDS-2211. Collect docker logs if env fails to start

[adoroszlai]

What changes were proposed in this pull request?

1. Collect docker logs if environment fails to start up (previously it was collected only after actual test run)
2. Copy docker logs to aggregate result directory
3. Fail fast if datanodes cannot be started
4. Avoid ANSI codes in output
5. Sort test cases for consistent run ordering (Robot summary table is already sorted)

https://issues.apache.org/jira/browse/HDDS-2211

How was this patch tested?

Ran acceptance.sh locally. Also simulated failure during datanode startup, verified that docker log is saved.

[adoroszlai]

/label ozone

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	86	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
0	shelldocs	1	Shelldocs was not available.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
-1	mvninstall	56	hadoop-hdds in trunk failed.
-1	mvninstall	43	hadoop-ozone in trunk failed.
+1	mvnsite	0	trunk passed
+1	shadedclient	891	branch has no errors when building and testing our client artifacts.
		_ Patch Compile Tests _
-1	mvninstall	35	hadoop-hdds in the patch failed.
-1	mvninstall	38	hadoop-ozone in the patch failed.
+1	mvnsite	0	the patch passed
+1	shellcheck	0	There were no new shellcheck issues.
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	815	patch has no errors when building and testing our client artifacts.
		_ Other Tests _
-1	unit	25	hadoop-hdds in the patch failed.
-1	unit	26	hadoop-ozone in the patch failed.
+1	asflicense	32	The patch does not generate ASF License warnings.
		2182

Subsystem	Report/Notes
Docker	Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1553/1/artifact/out/Dockerfile
GITHUB PR	#1553
Optional Tests	dupname asflicense mvnsite unit shellcheck shelldocs
uname	Linux 30685cfa644f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 4d3c580
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1553/1/artifact/out/branch-mvninstall-hadoop-hdds.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1553/1/artifact/out/branch-mvninstall-hadoop-ozone.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1553/1/artifact/out/patch-mvninstall-hadoop-hdds.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1553/1/artifact/out/patch-mvninstall-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1553/1/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1553/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1553/1/testReport/
Max. process+thread count	307 (vs. ulimit of 5500)
modules	C: hadoop-ozone/dist U: hadoop-ozone/dist
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1553/1/console
versions	git=2.7.4 maven=3.3.9 shellcheck=0.4.6
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[dineshchitlangia]

+1 LGTM (pending CI). Thanks @adoroszlai for this useful improvement.

[arp7]

Dumb q. - I see a couple of integration test failures. How can I get to their docker-compose logs?

[adoroszlai]

I see a couple of integration test failures. How can I get to their docker-compose logs?

Integration tests are simple (long-running) JUnit tests. They do not use docker-compose. Tests classes with failures are listed in the summary file ("Details" link of integration) with separate link to results and output.

Acceptance tests use docker-compose. Their results are in this directory, docker-compose logs are the docker-*.log files. In general you can get to it by following one of the other "Details" links (eg. author or build) and then navigating up one level in the directory hierarchy, then down to acceptance. The "Details" link for acceptance tests leads to the HTML report on the GitHub Pages version of the same repo, which has the advantage that it gets rendered by the browser rather than showing the raw source, but directory listing does not work there.

[arp7]

Looks good. +1 from me. I will commit this today.

[adoroszlai]

Thanks @dineshchitlangia and @arp7 for the reviews.