Skip to content

Conversation

@adoroszlai
Copy link
Contributor

@adoroszlai adoroszlai commented Sep 20, 2019

What changes were proposed in this pull request?

Remove project root from filenames in checkstyle.sh output. Also, make script slightly more readable by breaking long sed command.

https://issues.apache.org/jira/browse/HDDS-2157

How was this patch tested?

Introduced some checkstyle errors, then ran check:

$ git revert --no-commit 126ef77a810
$ hadoop-ozone/dev-support/checks/checkstyle.sh
...
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/db/cache/TableCache.java
 88: Line is longer than 80 characters (found 91).
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/RocksDBStoreIterator.java
 29: Line is longer than 80 characters (found 90).
 46: Line is longer than 80 characters (found 105).
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/LevelDBStoreIterator.java
 28: Line is longer than 80 characters (found 90).
hadoop-hdds/common/src/test/java/org/apache/hadoop/hdds/utils/TestMetadataStore.java
 124: Line is longer than 80 characters (found 87).
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java
 451: '}' at column 11 should be alone on a line.
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/client/HddsClientUtils.java
 136: Line is longer than 80 characters (found 89).
 144: Line is longer than 80 characters (found 81).
 154: Line is longer than 80 characters (found 99).
...

@adoroszlai
Copy link
Contributor Author

/label ozone

@elek elek added the ozone label Sep 20, 2019
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 105 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
0 shelldocs 0 Shelldocs was not available.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
-1 mvninstall 34 hadoop-ozone in trunk failed.
+1 mvnsite 0 trunk passed
-1 shadedclient 35 branch has errors when building and testing our client artifacts.
_ Patch Compile Tests _
-1 mvninstall 32 hadoop-ozone in the patch failed.
+1 mvnsite 0 the patch passed
+1 shellcheck 0 There were no new shellcheck issues.
+1 whitespace 0 The patch has no whitespace issues.
-1 shadedclient 28 patch has errors when building and testing our client artifacts.
_ Other Tests _
+1 unit 57 hadoop-hdds in the patch passed.
-1 unit 25 hadoop-ozone in the patch failed.
+1 asflicense 30 The patch does not generate ASF License warnings.
659
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1485/1/artifact/out/Dockerfile
GITHUB PR #1485
Optional Tests dupname asflicense mvnsite unit shellcheck shelldocs
uname Linux feb834285bcb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 3f223be
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1485/1/artifact/out/branch-mvninstall-hadoop-ozone.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1485/1/artifact/out/patch-mvninstall-hadoop-ozone.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1485/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1485/1/testReport/
Max. process+thread count 50 (vs. ulimit of 5500)
modules C: hadoop-ozone U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1485/1/console
versions git=2.7.4 maven=3.3.9 shellcheck=0.4.6
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@anuengineer anuengineer merged commit 5363730 into apache:trunk Sep 20, 2019
@adoroszlai adoroszlai deleted the HDDS-2157 branch September 23, 2019 10:01
@adoroszlai
Copy link
Contributor Author

Thanks @anuengineer for merging it.

amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019
RogPodge pushed a commit to RogPodge/hadoop that referenced this pull request Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants