HDFS-13118. SnapshotDiffReport should provide the INode type.

[ehiggs]

No description provided.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	42	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 5 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	19	Maven dependency ordering for branch
+1	mvninstall	1123	trunk passed
+1	compile	199	trunk passed
+1	checkstyle	60	trunk passed
+1	mvnsite	118	trunk passed
+1	shadedclient	835	branch has no errors when building and testing our client artifacts.
+1	javadoc	83	trunk passed
0	spotbugs	168	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	290	trunk passed
		_ Patch Compile Tests _
0	mvndep	12	Maven dependency ordering for patch
+1	mvninstall	102	the patch passed
+1	compile	197	the patch passed
+1	cc	197	the patch passed
+1	javac	197	the patch passed
-0	checkstyle	47	hadoop-hdfs-project: The patch generated 61 new + 376 unchanged - 6 fixed = 437 total (was 382)
+1	mvnsite	103	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	716	patch has no errors when building and testing our client artifacts.
+1	javadoc	78	the patch passed
-1	findbugs	132	hadoop-hdfs-project/hadoop-hdfs-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
+1	unit	115	hadoop-hdfs-client in the patch passed.
-1	unit	4738	hadoop-hdfs in the patch failed.
+1	asflicense	43	The patch does not generate ASF License warnings.
		9247

Reason	Tests
FindBugs	module:hadoop-hdfs-project/hadoop-hdfs-client
	Null passed for non-null parameter of org.apache.hadoop.hdfs.protocol.proto.HdfsProtos$SnapshotDiffReportListingEntryProto$Builder.setFileType(HdfsProtos$HdfsFileStatusProto$FileType) in org.apache.hadoop.hdfs.protocolPB.PBHelperClient.convert(SnapshotDiffReportListing$DiffReportListingEntry) Method invoked at PBHelperClient.java:of org.apache.hadoop.hdfs.protocol.proto.HdfsProtos$SnapshotDiffReportListingEntryProto$Builder.setFileType(HdfsProtos$HdfsFileStatusProto$FileType) in org.apache.hadoop.hdfs.protocolPB.PBHelperClient.convert(SnapshotDiffReportListing$DiffReportListingEntry) Method invoked at PBHelperClient.java:[line 2756]
Failed junit tests	hadoop.hdfs.web.TestWebHDFS

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/2/artifact/out/Dockerfile
GITHUB PR	#1313
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname	Linux da5a860d1d97 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 3bba808
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/2/artifact/out/diff-checkstyle-hadoop-hdfs-project.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/2/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/2/testReport/
Max. process+thread count	4094 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/2/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	73	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 5 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	16	Maven dependency ordering for branch
+1	mvninstall	1146	trunk passed
+1	compile	183	trunk passed
+1	checkstyle	53	trunk passed
+1	mvnsite	103	trunk passed
+1	shadedclient	842	branch has no errors when building and testing our client artifacts.
+1	javadoc	81	trunk passed
0	spotbugs	154	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	267	trunk passed
		_ Patch Compile Tests _
0	mvndep	13	Maven dependency ordering for patch
+1	mvninstall	95	the patch passed
+1	compile	176	the patch passed
+1	cc	176	the patch passed
+1	javac	176	the patch passed
-0	checkstyle	48	hadoop-hdfs-project: The patch generated 61 new + 376 unchanged - 6 fixed = 437 total (was 382)
+1	mvnsite	95	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	669	patch has no errors when building and testing our client artifacts.
+1	javadoc	72	the patch passed
-1	findbugs	130	hadoop-hdfs-project/hadoop-hdfs-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
+1	unit	106	hadoop-hdfs-client in the patch passed.
-1	unit	6249	hadoop-hdfs in the patch failed.
+1	asflicense	33	The patch does not generate ASF License warnings.
		10648

Reason	Tests
FindBugs	module:hadoop-hdfs-project/hadoop-hdfs-client
	Null passed for non-null parameter of org.apache.hadoop.hdfs.protocol.proto.HdfsProtos$SnapshotDiffReportListingEntryProto$Builder.setFileType(HdfsProtos$HdfsFileStatusProto$FileType) in org.apache.hadoop.hdfs.protocolPB.PBHelperClient.convert(SnapshotDiffReportListing$DiffReportListingEntry) Method invoked at PBHelperClient.java:of org.apache.hadoop.hdfs.protocol.proto.HdfsProtos$SnapshotDiffReportListingEntryProto$Builder.setFileType(HdfsProtos$HdfsFileStatusProto$FileType) in org.apache.hadoop.hdfs.protocolPB.PBHelperClient.convert(SnapshotDiffReportListing$DiffReportListingEntry) Method invoked at PBHelperClient.java:[line 2756]
Failed junit tests	hadoop.hdfs.web.TestWebHDFS
	hadoop.hdfs.TestDFSStripedOutputStream
	hadoop.hdfs.TestDFSStripedOutputStreamWithFailure
	hadoop.hdfs.server.namenode.TestReconstructStripedBlocks

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/1/artifact/out/Dockerfile
GITHUB PR	#1313
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname	Linux 5a58f74fa716 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 3bba808
Default Java	1.8.0_222
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/1/artifact/out/diff-checkstyle-hadoop-hdfs-project.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/1/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/1/testReport/
Max. process+thread count	4317 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/1/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[ehiggs]

Updated MR to fix findbugs and checkstyle issues.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	86	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 5 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	18	Maven dependency ordering for branch
+1	mvninstall	1113	trunk passed
+1	compile	200	trunk passed
+1	checkstyle	50	trunk passed
+1	mvnsite	100	trunk passed
+1	shadedclient	771	branch has no errors when building and testing our client artifacts.
+1	javadoc	77	trunk passed
0	spotbugs	159	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	277	trunk passed
		_ Patch Compile Tests _
0	mvndep	9	Maven dependency ordering for patch
+1	mvninstall	98	the patch passed
+1	compile	180	the patch passed
+1	cc	180	the patch passed
+1	javac	180	the patch passed
-0	checkstyle	46	hadoop-hdfs-project: The patch generated 2 new + 376 unchanged - 6 fixed = 378 total (was 382)
+1	mvnsite	92	the patch passed
+1	whitespace	1	The patch has no whitespace issues.
+1	shadedclient	688	patch has no errors when building and testing our client artifacts.
-1	javadoc	48	hadoop-hdfs-project_hadoop-hdfs generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)
-1	findbugs	31	hadoop-hdfs in the patch failed.
		_ Other Tests _
+1	unit	113	hadoop-hdfs-client in the patch passed.
-1	unit	31	hadoop-hdfs in the patch failed.
+1	asflicense	25	The patch does not generate ASF License warnings.
		4242

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/4/artifact/out/Dockerfile
GITHUB PR	#1313
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname	Linux 6a04cd6c38be 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 6244502
Default Java	1.8.0_222
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/4/artifact/out/diff-checkstyle-hadoop-hdfs-project.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/4/artifact/out/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/4/artifact/out/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/4/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/4/testReport/
Max. process+thread count	411 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/4/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[jojochuang]

Quickly reviewed it, and I think the patch makes sense to me and has high quality.

[ehiggs]

Forgot to commit SnapshotDiffListingInfo 😞

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	44	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	1	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 5 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	17	Maven dependency ordering for branch
+1	mvninstall	1174	trunk passed
+1	compile	223	trunk passed
+1	checkstyle	57	trunk passed
+1	mvnsite	110	trunk passed
+1	shadedclient	824	branch has no errors when building and testing our client artifacts.
+1	javadoc	86	trunk passed
0	spotbugs	177	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	314	trunk passed
		_ Patch Compile Tests _
0	mvndep	11	Maven dependency ordering for patch
+1	mvninstall	110	the patch passed
+1	compile	207	the patch passed
+1	cc	207	the patch passed
+1	javac	207	the patch passed
-0	checkstyle	50	hadoop-hdfs-project: The patch generated 2 new + 377 unchanged - 6 fixed = 379 total (was 383)
+1	mvnsite	103	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	717	patch has no errors when building and testing our client artifacts.
+1	javadoc	71	the patch passed
+1	findbugs	291	the patch passed
		_ Other Tests _
+1	unit	112	hadoop-hdfs-client in the patch passed.
-1	unit	4924	hadoop-hdfs in the patch failed.
+1	asflicense	36	The patch does not generate ASF License warnings.
		9518

Reason	Tests
Failed junit tests	hadoop.hdfs.TestErasureCodingExerciseAPIs
	hadoop.hdfs.TestFileChecksum
	hadoop.hdfs.web.TestWebHDFS
	hadoop.hdfs.server.namenode.TestFsck
	hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
	hadoop.hdfs.TestDFSStripedInputStream

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/6/artifact/out/Dockerfile
GITHUB PR	#1313
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname	Linux 03e23d8485d2 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / e684b17
Default Java	1.8.0_222
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/6/artifact/out/diff-checkstyle-hadoop-hdfs-project.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/6/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/6/testReport/
Max. process+thread count	4325 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/6/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	38	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 5 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	22	Maven dependency ordering for branch
+1	mvninstall	1219	trunk passed
+1	compile	221	trunk passed
+1	checkstyle	76	trunk passed
+1	mvnsite	161	trunk passed
+1	shadedclient	1579	branch has no errors when building and testing our client artifacts.
+1	javadoc	303	trunk passed
0	spotbugs	412	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	739	trunk passed
		_ Patch Compile Tests _
0	mvndep	64	Maven dependency ordering for patch
+1	mvninstall	314	the patch passed
+1	compile	456	the patch passed
+1	cc	456	the patch passed
+1	javac	456	the patch passed
-0	checkstyle	125	hadoop-hdfs-project: The patch generated 2 new + 376 unchanged - 6 fixed = 378 total (was 382)
+1	mvnsite	327	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	1017	patch has no errors when building and testing our client artifacts.
+1	javadoc	81	the patch passed
+1	findbugs	323	the patch passed
		_ Other Tests _
+1	unit	119	hadoop-hdfs-client in the patch passed.
-1	unit	5284	hadoop-hdfs in the patch failed.
+1	asflicense	33	The patch does not generate ASF License warnings.
		12612

Reason	Tests
Failed junit tests	hadoop.hdfs.web.TestWebHDFS
	hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/5/artifact/out/Dockerfile
GITHUB PR	#1313
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname	Linux 0f63838fb8c9 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / e684b17
Default Java	1.8.0_222
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/5/artifact/out/diff-checkstyle-hadoop-hdfs-project.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/5/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/5/testReport/
Max. process+thread count	3461 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/5/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[bshashikant]

Thanks @ehiggs for working on this. The patch overall looks good to me with few minor comments . The test failure TestWebHDFS#testWebHdfsSnapshotDiff looks related. Can you please check this as well?

[ehiggs]

The test failure TestWebHDFS#testWebHdfsSnapshotDiff looks related. Can you please check this as well?

It was indeed related. I was not outputting the inodeType as part of the Json for WebHdfs. This should be fixed now.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	139	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 5 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	42	Maven dependency ordering for branch
+1	mvninstall	1321	trunk passed
+1	compile	198	trunk passed
+1	checkstyle	57	trunk passed
+1	mvnsite	115	trunk passed
+1	shadedclient	931	branch has no errors when building and testing our client artifacts.
+1	javadoc	80	trunk passed
0	spotbugs	197	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	327	trunk passed
		_ Patch Compile Tests _
0	mvndep	13	Maven dependency ordering for patch
+1	mvninstall	115	the patch passed
+1	compile	193	the patch passed
+1	cc	193	the patch passed
+1	javac	193	the patch passed
-0	checkstyle	52	hadoop-hdfs-project: The patch generated 2 new + 376 unchanged - 6 fixed = 378 total (was 382)
+1	mvnsite	106	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	821	patch has no errors when building and testing our client artifacts.
+1	javadoc	86	the patch passed
+1	findbugs	328	the patch passed
		_ Other Tests _
+1	unit	118	hadoop-hdfs-client in the patch passed.
-1	unit	6324	hadoop-hdfs in the patch failed.
+1	asflicense	39	The patch does not generate ASF License warnings.
		11449

Reason	Tests
Failed junit tests	hadoop.hdfs.web.TestWebHDFS
	hadoop.hdfs.server.namenode.TestFSImage
	hadoop.hdfs.qjournal.server.TestJournalNodeSync
	hadoop.hdfs.server.namenode.ha.TestHAAppend

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/7/artifact/out/Dockerfile
GITHUB PR	#1313
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname	Linux 9a1f6faf50d5 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / ee7c261
Default Java	1.8.0_222
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/7/artifact/out/diff-checkstyle-hadoop-hdfs-project.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/7/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/7/testReport/
Max. process+thread count	3193 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/7/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	42	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 5 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	10	Maven dependency ordering for branch
+1	mvninstall	1085	trunk passed
+1	compile	186	trunk passed
+1	checkstyle	47	trunk passed
+1	mvnsite	97	trunk passed
+1	shadedclient	756	branch has no errors when building and testing our client artifacts.
+1	javadoc	72	trunk passed
0	spotbugs	151	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	265	trunk passed
		_ Patch Compile Tests _
0	mvndep	9	Maven dependency ordering for patch
+1	mvninstall	93	the patch passed
+1	compile	187	the patch passed
+1	cc	187	the patch passed
+1	javac	187	the patch passed
-0	checkstyle	45	hadoop-hdfs-project: The patch generated 3 new + 384 unchanged - 6 fixed = 387 total (was 390)
+1	mvnsite	97	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	689	patch has no errors when building and testing our client artifacts.
+1	javadoc	70	the patch passed
+1	findbugs	286	the patch passed
		_ Other Tests _
+1	unit	107	hadoop-hdfs-client in the patch passed.
-1	unit	4866	hadoop-hdfs in the patch failed.
+1	asflicense	35	The patch does not generate ASF License warnings.
		9069

Reason	Tests
Failed junit tests	hadoop.hdfs.TestDistributedFileSystem

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/9/artifact/out/Dockerfile
GITHUB PR	#1313
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname	Linux 8d3c60aaf2e0 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 28fb4b5
Default Java	1.8.0_222
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/9/artifact/out/diff-checkstyle-hadoop-hdfs-project.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/9/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/9/testReport/
Max. process+thread count	4074 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/9/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	86	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	1	The patch appears to include 5 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	10	Maven dependency ordering for branch
+1	mvninstall	1093	trunk passed
+1	compile	204	trunk passed
+1	checkstyle	53	trunk passed
+1	mvnsite	104	trunk passed
+1	shadedclient	819	branch has no errors when building and testing our client artifacts.
+1	javadoc	82	trunk passed
0	spotbugs	171	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	298	trunk passed
		_ Patch Compile Tests _
0	mvndep	10	Maven dependency ordering for patch
+1	mvninstall	109	the patch passed
+1	compile	193	the patch passed
+1	cc	193	the patch passed
+1	javac	193	the patch passed
-0	checkstyle	46	hadoop-hdfs-project: The patch generated 3 new + 384 unchanged - 6 fixed = 387 total (was 390)
+1	mvnsite	100	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	680	patch has no errors when building and testing our client artifacts.
+1	javadoc	75	the patch passed
+1	findbugs	290	the patch passed
		_ Other Tests _
+1	unit	108	hadoop-hdfs-client in the patch passed.
-1	unit	8282	hadoop-hdfs in the patch failed.
-1	asflicense	34	The patch generated 2 ASF License warnings.
		12698

Reason	Tests
Failed junit tests	hadoop.hdfs.tools.TestDFSZKFailoverController
	hadoop.hdfs.TestClientProtocolForPipelineRecovery
	hadoop.hdfs.TestDatanodeReport
	hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy
	hadoop.hdfs.TestReadWhileWriting
	hadoop.hdfs.TestErasureCodeBenchmarkThroughput
	hadoop.hdfs.TestMiniDFSCluster
	hadoop.hdfs.TestDFSStripedOutputStream
	hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead
	hadoop.hdfs.TestDistributedFileSystemWithECFile
	hadoop.hdfs.TestFileChecksum
	hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
	hadoop.hdfs.server.mover.TestStorageMover
	hadoop.hdfs.TestDFSPermission
	hadoop.hdfs.TestPread
	hadoop.hdfs.server.balancer.TestBalancer
	hadoop.hdfs.TestRestartDFS
	hadoop.hdfs.TestFileAppendRestart
	hadoop.hdfs.TestErasureCodingExerciseAPIs
	hadoop.hdfs.TestEncryptionZones
	hadoop.hdfs.TestDFSStripedInputStream
	hadoop.hdfs.shortcircuit.TestShortCircuitCache
	hadoop.hdfs.server.balancer.TestBalancerWithEncryptedTransfer
	hadoop.hdfs.TestFileChecksumCompositeCrc
	hadoop.hdfs.TestReadStripedFileWithDecodingCorruptData
	hadoop.hdfs.server.mover.TestMover
	hadoop.hdfs.TestReconstructStripedFile
	hadoop.hdfs.TestDFSStripedOutputStreamWithFailure
	hadoop.hdfs.server.diskbalancer.command.TestDiskBalancerCommand
	hadoop.hdfs.TestEncryptedTransfer
	hadoop.hdfs.server.balancer.TestBalancerWithSaslDataTransfer
	hadoop.hdfs.TestMultiThreadedHflush
	hadoop.hdfs.server.balancer.TestBalancerRPCDelay
	hadoop.hdfs.server.diskbalancer.TestDiskBalancerRPC

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/8/artifact/out/Dockerfile
GITHUB PR	#1313
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname	Linux aa775ac98029 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 28fb4b5
Default Java	1.8.0_222
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/8/artifact/out/diff-checkstyle-hadoop-hdfs-project.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/8/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/8/testReport/
asflicense	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/8/artifact/out/patch-asflicense-problems.txt
Max. process+thread count	3668 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/8/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	78	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 5 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	11	Maven dependency ordering for branch
+1	mvninstall	1163	trunk passed
+1	compile	195	trunk passed
+1	checkstyle	57	trunk passed
+1	mvnsite	117	trunk passed
+1	shadedclient	922	branch has no errors when building and testing our client artifacts.
+1	javadoc	85	trunk passed
0	spotbugs	170	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	295	trunk passed
		_ Patch Compile Tests _
0	mvndep	11	Maven dependency ordering for patch
+1	mvninstall	105	the patch passed
+1	compile	182	the patch passed
+1	cc	182	the patch passed
+1	javac	182	the patch passed
-0	checkstyle	56	hadoop-hdfs-project: The patch generated 3 new + 385 unchanged - 6 fixed = 388 total (was 391)
+1	mvnsite	106	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	789	patch has no errors when building and testing our client artifacts.
+1	javadoc	78	the patch passed
+1	findbugs	309	the patch passed
		_ Other Tests _
+1	unit	114	hadoop-hdfs-client in the patch passed.
-1	unit	6073	hadoop-hdfs in the patch failed.
+1	asflicense	38	The patch does not generate ASF License warnings.
		10796

Reason	Tests
Failed junit tests	hadoop.hdfs.TestEncryptionZonesWithKMS
	hadoop.hdfs.TestSetrepDecreasing

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/10/artifact/out/Dockerfile
GITHUB PR	#1313
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname	Linux a4c0104e419d 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 3329257
Default Java	1.8.0_222
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/10/artifact/out/diff-checkstyle-hadoop-hdfs-project.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/10/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/10/testReport/
Max. process+thread count	2910 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/10/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[bshashikant]

The changes look good to me. Can you please address the checkstyle issues?

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	49	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 5 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	14	Maven dependency ordering for branch
+1	mvninstall	1306	trunk passed
+1	compile	211	trunk passed
+1	checkstyle	64	trunk passed
+1	mvnsite	132	trunk passed
+1	shadedclient	993	branch has no errors when building and testing our client artifacts.
+1	javadoc	98	trunk passed
0	spotbugs	200	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	349	trunk passed
		_ Patch Compile Tests _
0	mvndep	15	Maven dependency ordering for patch
+1	mvninstall	124	the patch passed
+1	compile	199	the patch passed
+1	cc	199	the patch passed
+1	javac	199	the patch passed
-0	checkstyle	61	hadoop-hdfs-project: The patch generated 3 new + 384 unchanged - 6 fixed = 387 total (was 390)
+1	mvnsite	118	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	843	patch has no errors when building and testing our client artifacts.
+1	javadoc	81	the patch passed
+1	findbugs	307	the patch passed
		_ Other Tests _
+1	unit	118	hadoop-hdfs-client in the patch passed.
-1	unit	5289	hadoop-hdfs in the patch failed.
+1	asflicense	37	The patch does not generate ASF License warnings.
		10432

Reason	Tests
Failed junit tests	hadoop.hdfs.TestReconstructStripedFile
	hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/11/artifact/out/Dockerfile
GITHUB PR	#1313
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname	Linux c400bcbd9be0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 915cbc9
Default Java	1.8.0_222
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/11/artifact/out/diff-checkstyle-hadoop-hdfs-project.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/11/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/11/testReport/
Max. process+thread count	4595 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/11/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	39	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 5 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	21	Maven dependency ordering for branch
+1	mvninstall	1080	trunk passed
+1	compile	191	trunk passed
+1	checkstyle	59	trunk passed
+1	mvnsite	117	trunk passed
+1	shadedclient	827	branch has no errors when building and testing our client artifacts.
+1	javadoc	89	trunk passed
0	spotbugs	164	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	288	trunk passed
		_ Patch Compile Tests _
0	mvndep	12	Maven dependency ordering for patch
+1	mvninstall	109	the patch passed
+1	compile	180	the patch passed
+1	cc	180	the patch passed
+1	javac	180	the patch passed
+1	checkstyle	54	hadoop-hdfs-project: The patch generated 0 new + 384 unchanged - 6 fixed = 384 total (was 390)
+1	mvnsite	111	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	694	patch has no errors when building and testing our client artifacts.
+1	javadoc	82	the patch passed
+1	findbugs	296	the patch passed
		_ Other Tests _
+1	unit	116	hadoop-hdfs-client in the patch passed.
-1	unit	5374	hadoop-hdfs in the patch failed.
+1	asflicense	40	The patch does not generate ASF License warnings.
		9804

Reason	Tests
Failed junit tests	hadoop.hdfs.server.namenode.snapshot.TestSnapshotBlocksMap
	hadoop.hdfs.TestFileChecksumCompositeCrc
	hadoop.hdfs.server.namenode.snapshot.TestSnapshotReplication
	hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy
	hadoop.hdfs.TestErasureCodingPolicies

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/12/artifact/out/Dockerfile
GITHUB PR	#1313
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname	Linux 67f095d32585 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 60af879
Default Java	1.8.0_222
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/12/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/12/testReport/
Max. process+thread count	5340 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/12/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[ehiggs]

Tests that failed all appear to have done so with resource exhaustion:

unable to create new native thread

Java heap space

[bshashikant]

/retest

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	45	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 5 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	21	Maven dependency ordering for branch
+1	mvninstall	1150	trunk passed
+1	compile	212	trunk passed
+1	checkstyle	68	trunk passed
+1	mvnsite	123	trunk passed
+1	shadedclient	931	branch has no errors when building and testing our client artifacts.
+1	javadoc	121	trunk passed
0	spotbugs	172	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	310	trunk passed
		_ Patch Compile Tests _
0	mvndep	12	Maven dependency ordering for patch
+1	mvninstall	117	the patch passed
+1	compile	206	the patch passed
-1	cc	206	hadoop-hdfs-project generated 4 new + 15 unchanged - 4 fixed = 19 total (was 19)
+1	javac	206	the patch passed
+1	checkstyle	58	hadoop-hdfs-project: The patch generated 0 new + 384 unchanged - 6 fixed = 384 total (was 390)
+1	mvnsite	112	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	779	patch has no errors when building and testing our client artifacts.
+1	javadoc	110	the patch passed
+1	findbugs	329	the patch passed
		_ Other Tests _
+1	unit	125	hadoop-hdfs-client in the patch passed.
-1	unit	5268	hadoop-hdfs in the patch failed.
+1	asflicense	44	The patch does not generate ASF License warnings.
		10163

Reason	Tests
Failed junit tests	hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
	hadoop.hdfs.TestLeaseRecovery2
	hadoop.hdfs.server.namenode.ha.TestEditLogTailer
	hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
	hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy

Subsystem	Report/Notes
Docker	Client=19.03.3 Server=19.03.3 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/15/artifact/out/Dockerfile
GITHUB PR	#1313
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname	Linux 905b772da59e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / ec86f42
Default Java	1.8.0_222
cc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/15/artifact/out/diff-compile-cc-hadoop-hdfs-project.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/15/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/15/testReport/
Max. process+thread count	3885 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1313/15/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[jojochuang]

Looks like this PR needs rebase. Other than that i think the patch is good to go if we can verify the failed tests aren't related.

[virajith]

@ehiggs - Can you confirm if this PR is ready to get in? Also, can you verify that the failed TestRenameWithSnapshots is (un) related? Other test failures look unrelated.