HADOOP-15958. Revisiting LICENSE and NOTICE files #1307
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll update the dependencies shortly. |
iwasakims
reviewed
Aug 19, 2019
LICENSE-binary
Outdated
There was a problem hiding this comment.
I don't know the version of the leveldb libraries included in leveldbjni-all.jar.
There is no information in the GitHub repository: https://github.com/fusesource/leveldbjni
It seems that the leveldb version depends on the release manager's environment.
There was a problem hiding this comment.
Hadoop bundles leveldbjni-all-1.8.jar which contains pre-built libraries for each platform. leveldb is build from the code in github.com/chirino/leveldb and its version is 1.13.
There was a problem hiding this comment.
Thank you for the information! Included the version.
iwasakims
reviewed
Aug 19, 2019
LICENSE-binary
Outdated
There was a problem hiding this comment.
These lines are not covered in LICENSE.txt. These could be sorted with above lines.
…e-files successfully
…oved from BSD 3-Clause section.
|
💔 -1 overall
This message was automatically generated. |
Conflicts: LICENSE.txt
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
iwasakims
reviewed
Aug 26, 2019
LICENSE-binary
Outdated
| junit:junit:4.12 | ||
|
|
||
|
|
||
| Eclipse Public License 2.0 |
There was a problem hiding this comment.
should be CDDL + GPLv2 with classpath exception?
There was a problem hiding this comment.
Yes. Thank you for your comment.
The libraries have been moved to eclipse repository and now the license is EPL, however, Apache Hadoop is using the old version of the libraries and the licenses were CDDL + GPLv2 with classpath exception.
|
I built dists with latest patch. Assembly part looks good overall.
|
|
CDDLs are not contained in licenses-binary. |
Added licenses-binary/LICENSE-cddl-gplv2-ce.txt |
|
+1. Thanks for the update. Further nits (of original LICENSE.txt) should be fixed in follow-ups. Once the split is done, reviewing the update would be much easier. |
|
Committed. Thank you, @iwasakims ! |
amahussein
pushed a commit
to amahussein/hadoop
that referenced
this pull request
Oct 29, 2019
This closes apache#1307 Reviewed-by: Masatake Iwasaki <[email protected]>
RogPodge
pushed a commit
to RogPodge/hadoop
that referenced
this pull request
Mar 25, 2020
This closes apache#1307 Reviewed-by: Masatake Iwasaki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/HADOOP-15958