Skip to content

HADOOP-16276. Fix jsvc startup command in hadoop-functions.sh due to jsvc >= 1.0.11 changed default current working directory #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2019
Merged

HADOOP-16276. Fix jsvc startup command in hadoop-functions.sh due to jsvc >= 1.0.11 changed default current working directory #1272

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c4628d
HADOOP-16276. Fix jsvc startup command in hadoop-functions.sh due to …
smengcl Aug 10, 2019
9f8544d
Change auto-detect logic, now based on grep.
smengcl Aug 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1921,6 +1921,22 @@ function hadoop_start_secure_daemon
exit 1
fi

if [[ -z "${HADOOP_DAEMON_JSVC_EXTRA_OPTS}" ]]; then
# If HADOOP_DAEMON_JSVC_EXTRA_OPTS is not set
if ${jsvc} -help | grep -q "\-cwd"; then
# Check if jsvc -help has entry for option -cwd
hadoop_debug "Your jsvc supports -cwd option." \
"Adding option '-cwd .'. See HADOOP-16276 for details."
HADOOP_DAEMON_JSVC_EXTRA_OPTS="-cwd ."
else
hadoop_debug "Your jsvc doesn't support -cwd option." \
"No need to add option '-cwd .'. See HADOOP-16276 for details."
fi
else
hadoop_debug "HADOOP_DAEMON_JSVC_EXTRA_OPTS is set." \
"Ignoring jsvc -cwd option detection and addition."
fi

# note that shellcheck will throw a
# bogus for-our-use-case 2086 here.
# it doesn't properly support multi-line situations
Expand Down