HDDS-1879. Support multiple excluded scopes when choosing datanodes in NetworkTopology

[ChenSammi]

https://issues.apache.org/jira/browse/HDDS-1879

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	41	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	22	Maven dependency ordering for branch
+1	mvninstall	600	trunk passed
+1	compile	347	trunk passed
+1	checkstyle	61	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	755	branch has no errors when building and testing our client artifacts.
+1	javadoc	149	trunk passed
0	spotbugs	417	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	605	trunk passed
		_ Patch Compile Tests _
0	mvndep	18	Maven dependency ordering for patch
+1	mvninstall	559	the patch passed
+1	compile	348	the patch passed
+1	javac	348	the patch passed
+1	checkstyle	67	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	626	patch has no errors when building and testing our client artifacts.
-1	javadoc	67	hadoop-hdds generated 1 new + 16 unchanged - 0 fixed = 17 total (was 16)
-1	findbugs	203	hadoop-hdds generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
-1	unit	314	hadoop-hdds in the patch failed.
-1	unit	2145	hadoop-ozone in the patch failed.
+1	asflicense	55	The patch does not generate ASF License warnings.
		7667

Reason	Tests
FindBugs	module:hadoop-hdds
	org.apache.hadoop.hdds.scm.net.InnerNodeImpl.getLeaf(int, List, Collection, int) makes inefficient use of keySet iterator instead of entrySet iterator At InnerNodeImpl.java:inefficient use of keySet iterator instead of entrySet iterator At InnerNodeImpl.java:[line 340]
Failed junit tests	hadoop.hdds.scm.container.placement.algorithms.TestSCMContainerPlacementRackAware
	hadoop.ozone.om.TestOzoneManagerHA
	hadoop.ozone.client.rpc.TestCommitWatcher
	hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
	hadoop.ozone.TestMiniOzoneCluster
	hadoop.hdds.scm.pipeline.TestSCMPipelineManager
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.Test2WayCommitInRatis
	hadoop.ozone.om.TestScmSafeMode
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/1/artifact/out/Dockerfile
GITHUB PR	#1194
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 28da2bcd03dc 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / d4ab9ae
Default Java	1.8.0_212
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/1/artifact/out/diff-javadoc-javadoc-hadoop-hdds.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/1/artifact/out/new-findbugs-hadoop-hdds.html
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/1/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/1/testReport/
Max. process+thread count	3959 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/server-scm U: hadoop-hdds
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/1/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	35	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	141	Maven dependency ordering for branch
+1	mvninstall	727	trunk passed
+1	compile	359	trunk passed
+1	checkstyle	74	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	1055	branch has no errors when building and testing our client artifacts.
+1	javadoc	164	trunk passed
0	spotbugs	459	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	685	trunk passed
		_ Patch Compile Tests _
0	mvndep	19	Maven dependency ordering for patch
+1	mvninstall	566	the patch passed
+1	compile	390	the patch passed
+1	javac	390	the patch passed
+1	checkstyle	74	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	737	patch has no errors when building and testing our client artifacts.
-1	javadoc	89	hadoop-hdds generated 1 new + 16 unchanged - 0 fixed = 17 total (was 16)
-1	findbugs	266	hadoop-hdds generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
-1	unit	354	hadoop-hdds in the patch failed.
-1	unit	2055	hadoop-ozone in the patch failed.
+1	asflicense	45	The patch does not generate ASF License warnings.
		8613

Reason	Tests
FindBugs	module:hadoop-hdds
	org.apache.hadoop.hdds.scm.net.InnerNodeImpl.getLeaf(int, List, Collection, int) makes inefficient use of keySet iterator instead of entrySet iterator At InnerNodeImpl.java:inefficient use of keySet iterator instead of entrySet iterator At InnerNodeImpl.java:[line 340]
Failed junit tests	hadoop.hdds.scm.container.placement.algorithms.TestSCMContainerPlacementRackAware
	hadoop.ozone.om.TestScmSafeMode
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/2/artifact/out/Dockerfile
GITHUB PR	#1194
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux ab6a97182374 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / c1f7440
Default Java	1.8.0_212
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/2/artifact/out/diff-javadoc-javadoc-hadoop-hdds.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/2/artifact/out/new-findbugs-hadoop-hdds.html
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/2/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/2/testReport/
Max. process+thread count	4376 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/server-scm U: hadoop-hdds
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/2/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	125	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	42	Maven dependency ordering for branch
+1	mvninstall	792	trunk passed
+1	compile	447	trunk passed
+1	checkstyle	91	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	1173	branch has no errors when building and testing our client artifacts.
+1	javadoc	205	trunk passed
0	spotbugs	575	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	821	trunk passed
		_ Patch Compile Tests _
0	mvndep	25	Maven dependency ordering for patch
+1	mvninstall	690	the patch passed
+1	compile	488	the patch passed
+1	javac	488	the patch passed
+1	checkstyle	97	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	910	patch has no errors when building and testing our client artifacts.
+1	javadoc	221	the patch passed
+1	findbugs	825	the patch passed
		_ Other Tests _
-1	unit	411	hadoop-hdds in the patch failed.
-1	unit	2500	hadoop-ozone in the patch failed.
+1	asflicense	39	The patch does not generate ASF License warnings.
		10105

Reason	Tests
Failed junit tests	hadoop.hdds.scm.container.placement.algorithms.TestSCMContainerPlacementRackAware
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.TestMiniChaosOzoneCluster
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestCommitWatcher
	hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/3/artifact/out/Dockerfile
GITHUB PR	#1194
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 88370a5bb228 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / a7371a7
Default Java	1.8.0_222
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/3/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/3/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/3/testReport/
Max. process+thread count	4091 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/server-scm U: hadoop-hdds
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/3/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	48	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	25	Maven dependency ordering for branch
+1	mvninstall	639	trunk passed
+1	compile	368	trunk passed
+1	checkstyle	62	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	840	branch has no errors when building and testing our client artifacts.
+1	javadoc	159	trunk passed
0	spotbugs	425	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	618	trunk passed
		_ Patch Compile Tests _
0	mvndep	25	Maven dependency ordering for patch
+1	mvninstall	545	the patch passed
+1	compile	377	the patch passed
+1	javac	377	the patch passed
+1	checkstyle	64	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	639	patch has no errors when building and testing our client artifacts.
+1	javadoc	148	the patch passed
+1	findbugs	658	the patch passed
		_ Other Tests _
-1	unit	334	hadoop-hdds in the patch failed.
-1	unit	2178	hadoop-ozone in the patch failed.
+1	asflicense	41	The patch does not generate ASF License warnings.
		7930

Reason	Tests
Failed junit tests	hadoop.hdds.scm.container.placement.algorithms.TestSCMContainerPlacementRackAware
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory
	hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.hdds.scm.pipeline.TestRatisPipelineProvider
	hadoop.ozone.om.TestScmSafeMode
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/4/artifact/out/Dockerfile
GITHUB PR	#1194
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux b8368897dc61 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / f86de6f
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/4/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/4/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/4/testReport/
Max. process+thread count	4603 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/server-scm U: hadoop-hdds
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/4/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	44	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	13	Maven dependency ordering for branch
+1	mvninstall	587	trunk passed
+1	compile	366	trunk passed
+1	checkstyle	65	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	793	branch has no errors when building and testing our client artifacts.
+1	javadoc	149	trunk passed
0	spotbugs	430	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	620	trunk passed
		_ Patch Compile Tests _
0	mvndep	16	Maven dependency ordering for patch
+1	mvninstall	561	the patch passed
+1	compile	361	the patch passed
+1	javac	361	the patch passed
-0	checkstyle	37	hadoop-hdds: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	607	patch has no errors when building and testing our client artifacts.
+1	javadoc	143	the patch passed
+1	findbugs	628	the patch passed
		_ Other Tests _
+1	unit	315	hadoop-hdds in the patch passed.
-1	unit	2174	hadoop-ozone in the patch failed.
+1	asflicense	41	The patch does not generate ASF License warnings.
		7723

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.client.rpc.TestCommitWatcher
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.om.TestScmSafeMode
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/6/artifact/out/Dockerfile
GITHUB PR	#1194
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux f7dc2d82f3f5 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / e872ceb
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/6/artifact/out/diff-checkstyle-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/6/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/6/testReport/
Max. process+thread count	4837 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/server-scm U: hadoop-hdds
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/6/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	46	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	10	Maven dependency ordering for branch
+1	mvninstall	588	trunk passed
+1	compile	366	trunk passed
+1	checkstyle	74	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	819	branch has no errors when building and testing our client artifacts.
+1	javadoc	149	trunk passed
0	spotbugs	412	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	608	trunk passed
		_ Patch Compile Tests _
0	mvndep	18	Maven dependency ordering for patch
+1	mvninstall	527	the patch passed
+1	compile	364	the patch passed
+1	javac	364	the patch passed
-0	checkstyle	34	hadoop-hdds: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	609	patch has no errors when building and testing our client artifacts.
+1	javadoc	148	the patch passed
+1	findbugs	627	the patch passed
		_ Other Tests _
+1	unit	289	hadoop-hdds in the patch passed.
-1	unit	1644	hadoop-ozone in the patch failed.
+1	asflicense	43	The patch does not generate ASF License warnings.
		7132

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.om.TestScmSafeMode
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
	hadoop.ozone.om.TestKeyManagerImpl
	hadoop.ozone.client.rpc.Test2WayCommitInRatis

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/7/artifact/out/Dockerfile
GITHUB PR	#1194
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux bbef7009df19 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 70b4617
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/7/artifact/out/diff-checkstyle-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/7/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/7/testReport/
Max. process+thread count	5283 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/server-scm U: hadoop-hdds
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/7/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	42	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	11	Maven dependency ordering for branch
+1	mvninstall	576	trunk passed
+1	compile	342	trunk passed
+1	checkstyle	65	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	793	branch has no errors when building and testing our client artifacts.
+1	javadoc	143	trunk passed
0	spotbugs	419	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	618	trunk passed
		_ Patch Compile Tests _
0	mvndep	17	Maven dependency ordering for patch
+1	mvninstall	531	the patch passed
+1	compile	349	the patch passed
+1	javac	349	the patch passed
-0	checkstyle	34	hadoop-hdds: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	613	patch has no errors when building and testing our client artifacts.
+1	javadoc	148	the patch passed
+1	findbugs	631	the patch passed
		_ Other Tests _
+1	unit	297	hadoop-hdds in the patch passed.
-1	unit	1276	hadoop-ozone in the patch failed.
+1	asflicense	40	The patch does not generate ASF License warnings.
		6696

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestReadRetries
	hadoop.ozone.web.TestOzoneVolumes
	hadoop.ozone.web.client.TestKeys
	hadoop.ozone.client.rpc.TestCommitWatcher
	hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/8/artifact/out/Dockerfile
GITHUB PR	#1194
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 38828c14ebdb 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 00b5a27
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/8/artifact/out/diff-checkstyle-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/8/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/8/testReport/
Max. process+thread count	3018 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/server-scm U: hadoop-hdds
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/8/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	125	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	26	Maven dependency ordering for branch
+1	mvninstall	646	trunk passed
+1	compile	355	trunk passed
+1	checkstyle	64	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	816	branch has no errors when building and testing our client artifacts.
+1	javadoc	149	trunk passed
0	spotbugs	429	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	628	trunk passed
		_ Patch Compile Tests _
0	mvndep	17	Maven dependency ordering for patch
+1	mvninstall	557	the patch passed
+1	compile	351	the patch passed
+1	javac	351	the patch passed
-0	checkstyle	30	hadoop-hdds: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	610	patch has no errors when building and testing our client artifacts.
+1	javadoc	142	the patch passed
+1	findbugs	646	the patch passed
		_ Other Tests _
+1	unit	350	hadoop-hdds in the patch passed.
-1	unit	2855	hadoop-ozone in the patch failed.
+1	asflicense	44	The patch does not generate ASF License warnings.
		8589

Reason	Tests
Failed junit tests	hadoop.ozone.TestStorageContainerManager
	hadoop.ozone.client.rpc.TestBlockOutputStream
	hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
	hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory
	hadoop.ozone.client.rpc.TestContainerStateMachineFailures
	hadoop.ozone.om.TestOzoneManagerHA
	hadoop.ozone.scm.TestSCMNodeManagerMXBean
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/9/artifact/out/Dockerfile
GITHUB PR	#1194
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 040b88056fb8 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 9a1d8cf
Default Java	1.8.0_222
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/9/artifact/out/diff-checkstyle-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/9/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/9/testReport/
Max. process+thread count	4191 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/server-scm U: hadoop-hdds
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/9/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	43	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	12	Maven dependency ordering for branch
+1	mvninstall	581	trunk passed
+1	compile	353	trunk passed
+1	checkstyle	63	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	826	branch has no errors when building and testing our client artifacts.
+1	javadoc	147	trunk passed
0	spotbugs	414	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	611	trunk passed
		_ Patch Compile Tests _
0	mvndep	15	Maven dependency ordering for patch
+1	mvninstall	536	the patch passed
-1	compile	265	hadoop-ozone in the patch failed.
-1	javac	265	hadoop-ozone in the patch failed.
-0	checkstyle	32	hadoop-hdds: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	626	patch has no errors when building and testing our client artifacts.
+1	javadoc	144	the patch passed
+1	findbugs	651	the patch passed
		_ Other Tests _
+1	unit	282	hadoop-hdds in the patch passed.
-1	unit	1662	hadoop-ozone in the patch failed.
+1	asflicense	43	The patch does not generate ASF License warnings.
		7157

Reason	Tests
Failed junit tests	hadoop.ozone.container.server.TestSecureContainerServer
	hadoop.ozone.TestStorageContainerManager

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/10/artifact/out/Dockerfile
GITHUB PR	#1194
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux f948c8345375 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 6244502
Default Java	1.8.0_222
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/10/artifact/out/patch-compile-hadoop-ozone.txt
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/10/artifact/out/patch-compile-hadoop-ozone.txt
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/10/artifact/out/diff-checkstyle-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/10/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/10/testReport/
Max. process+thread count	4691 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/server-scm U: hadoop-hdds
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/10/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	41	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	10	Maven dependency ordering for branch
-1	mvninstall	24	hadoop-hdds in trunk failed.
-1	mvninstall	6	hadoop-ozone in trunk failed.
-1	compile	7	hadoop-hdds in trunk failed.
-1	compile	6	hadoop-ozone in trunk failed.
-0	checkstyle	5	The patch fails to run checkstyle in hadoop-ozone
+1	mvnsite	0	trunk passed
+1	shadedclient	42	branch has no errors when building and testing our client artifacts.
-1	javadoc	12	hadoop-hdds in trunk failed.
-1	javadoc	8	hadoop-ozone in trunk failed.
0	spotbugs	80	Used deprecated FindBugs config; considering switching to SpotBugs.
-1	findbugs	8	hadoop-hdds in trunk failed.
-1	findbugs	7	hadoop-ozone in trunk failed.
		_ Patch Compile Tests _
0	mvndep	5	Maven dependency ordering for patch
-1	mvninstall	6	hadoop-hdds in the patch failed.
-1	mvninstall	7	hadoop-ozone in the patch failed.
-1	compile	7	hadoop-hdds in the patch failed.
-1	compile	7	hadoop-ozone in the patch failed.
-1	javac	7	hadoop-hdds in the patch failed.
-1	javac	7	hadoop-ozone in the patch failed.
-0	checkstyle	5	The patch fails to run checkstyle in hadoop-hdds
-0	checkstyle	4	The patch fails to run checkstyle in hadoop-ozone
+1	mvnsite	0	the patch passed
-1	whitespace	0	The patch has 133 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-1	whitespace	1	The patch 1800 line(s) with tabs.
+1	shadedclient	20	patch has no errors when building and testing our client artifacts.
-1	javadoc	6	hadoop-hdds in the patch failed.
-1	javadoc	6	hadoop-ozone in the patch failed.
-1	findbugs	6	hadoop-hdds in the patch failed.
-1	findbugs	6	hadoop-ozone in the patch failed.
		_ Other Tests _
-1	unit	6	hadoop-hdds in the patch failed.
-1	unit	5	hadoop-ozone in the patch failed.
0	asflicense	7	ASF License check generated no output?
		376

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/11/artifact/out/Dockerfile
GITHUB PR	#1194
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 78e8d77fff71 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 69ddb36
Default Java	1.8.0_222
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/11/artifact/out/branch-mvninstall-hadoop-hdds.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/11/artifact/out/branch-mvninstall-hadoop-ozone.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/11/artifact/out/branch-compile-hadoop-hdds.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/11/artifact/out/branch-compile-hadoop-ozone.txt
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/11/artifact/out//home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-1194/out/maven-branch-checkstyle-hadoop-ozone.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/11/artifact/out/branch-javadoc-hadoop-hdds.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/11/artifact/out/branch-javadoc-hadoop-ozone.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/11/artifact/out/branch-findbugs-hadoop-hdds.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/11/artifact/out/branch-findbugs-hadoop-ozone.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/11/artifact/out/patch-mvninstall-hadoop-hdds.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/11/artifact/out/patch-mvninstall-hadoop-ozone.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/11/artifact/out/patch-compile-hadoop-hdds.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/11/artifact/out/patch-compile-hadoop-ozone.txt
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/11/artifact/out/patch-compile-hadoop-hdds.txt
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/11/artifact/out/patch-compile-hadoop-ozone.txt
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/11/artifact/out//home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-1194/out/maven-patch-checkstyle-hadoop-hdds.txt
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/11/artifact/out//home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-1194/out/maven-patch-checkstyle-hadoop-ozone.txt
whitespace	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/11/artifact/out/whitespace-eol.txt
whitespace	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/11/artifact/out/whitespace-tabs.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/11/artifact/out/patch-javadoc-hadoop-hdds.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/11/artifact/out/patch-javadoc-hadoop-ozone.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/11/artifact/out/patch-findbugs-hadoop-hdds.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/11/artifact/out/patch-findbugs-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/11/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/11/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/11/testReport/
Max. process+thread count	52 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/server-scm U: hadoop-hdds
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/11/console
versions	git=2.7.4 maven=3.3.9
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	90	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	11	Maven dependency ordering for branch
+1	mvninstall	690	trunk passed
+1	compile	434	trunk passed
+1	checkstyle	91	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	1048	branch has no errors when building and testing our client artifacts.
+1	javadoc	170	trunk passed
0	spotbugs	481	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	687	trunk passed
		_ Patch Compile Tests _
0	mvndep	22	Maven dependency ordering for patch
+1	mvninstall	612	the patch passed
+1	compile	378	the patch passed
+1	javac	378	the patch passed
-0	checkstyle	31	hadoop-hdds: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	738	patch has no errors when building and testing our client artifacts.
+1	javadoc	189	the patch passed
+1	findbugs	705	the patch passed
		_ Other Tests _
+1	unit	346	hadoop-hdds in the patch passed.
-1	unit	2403	hadoop-ozone in the patch failed.
+1	asflicense	43	The patch does not generate ASF License warnings.
		8891

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
	hadoop.ozone.client.rpc.Test2WayCommitInRatis

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/12/artifact/out/Dockerfile
GITHUB PR	#1194
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 5067a43db9b4 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 3329257
Default Java	1.8.0_222
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/12/artifact/out/diff-checkstyle-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/12/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/12/testReport/
Max. process+thread count	5291 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/server-scm U: hadoop-hdds
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/12/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[elek]

/retest

[xiaoyuyao]

NIT: We can use CollectionUtils.isEmpty() to simplify the code at 79/80.

[ChenSammi]

OK

[xiaoyuyao]

I don't see this being used anywhere, should we remove it?

[ChenSammi]

OK

[xiaoyuyao]

NIT: use CollectionUtils.isEmpty() to simplify?

[xiaoyuyao]

Thanks @ChenSammi for the patch. It looks good to me overall. Just few minor comments inline..

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	43	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	16	Maven dependency ordering for branch
+1	mvninstall	604	trunk passed
+1	compile	400	trunk passed
+1	checkstyle	80	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	866	branch has no errors when building and testing our client artifacts.
+1	javadoc	189	trunk passed
0	spotbugs	483	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	694	trunk passed
		_ Patch Compile Tests _
0	mvndep	26	Maven dependency ordering for patch
+1	mvninstall	573	the patch passed
+1	compile	397	the patch passed
+1	javac	397	the patch passed
-0	checkstyle	41	hadoop-hdds: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	695	patch has no errors when building and testing our client artifacts.
+1	javadoc	172	the patch passed
+1	findbugs	671	the patch passed
		_ Other Tests _
+1	unit	282	hadoop-hdds in the patch passed.
-1	unit	1819	hadoop-ozone in the patch failed.
+1	asflicense	53	The patch does not generate ASF License warnings.
		7841

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException
	hadoop.ozone.om.TestSecureOzoneManager

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/13/artifact/out/Dockerfile
GITHUB PR	#1194
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux e8d26a2c59c0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 915cbc9
Default Java	1.8.0_222
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/13/artifact/out/diff-checkstyle-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/13/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/13/testReport/
Max. process+thread count	5264 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/server-scm U: hadoop-hdds
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/13/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	73	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	29	Maven dependency ordering for branch
+1	mvninstall	614	trunk passed
+1	compile	371	trunk passed
+1	checkstyle	74	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	942	branch has no errors when building and testing our client artifacts.
+1	javadoc	170	trunk passed
0	spotbugs	433	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	640	trunk passed
		_ Patch Compile Tests _
0	mvndep	20	Maven dependency ordering for patch
+1	mvninstall	555	the patch passed
+1	compile	376	the patch passed
+1	javac	376	the patch passed
-0	checkstyle	38	hadoop-hdds: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	740	patch has no errors when building and testing our client artifacts.
+1	javadoc	174	the patch passed
+1	findbugs	684	the patch passed
		_ Other Tests _
+1	unit	313	hadoop-hdds in the patch passed.
-1	unit	2702	hadoop-ozone in the patch failed.
+1	asflicense	39	The patch does not generate ASF License warnings.
		8767

Reason	Tests
Failed junit tests	hadoop.ozone.container.TestContainerReplication
	hadoop.ozone.TestSecureOzoneCluster
	hadoop.ozone.client.rpc.TestBlockOutputStream
	hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
	hadoop.ozone.TestMiniChaosOzoneCluster
	hadoop.ozone.container.common.statemachine.commandhandler.TestBlockDeletion
	hadoop.ozone.client.rpc.TestContainerStateMachineFailures

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/14/artifact/out/Dockerfile
GITHUB PR	#1194
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 2142a16a9b39 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / c3beeb7
Default Java	1.8.0_222
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/14/artifact/out/diff-checkstyle-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/14/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/14/testReport/
Max. process+thread count	5322 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/server-scm U: hadoop-hdds
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/14/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[xiaoyuyao]

Thanks @ChenSammi for updating the PR. The latest change LGTM. Can you fix the checkstyle and unit test failure that seems to be related? +1 after that.

[ChenSammi]

Thanks @xiaoyuyao for the review. A new patch to fix the check style issue. The failed UTs are not related. Will commit after the Yetus build.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	105	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	28	Maven dependency ordering for branch
-1	mvninstall	33	hadoop-ozone in trunk failed.
-1	compile	22	hadoop-ozone in trunk failed.
+1	checkstyle	68	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	866	branch has no errors when building and testing our client artifacts.
-1	javadoc	18	hadoop-hdds in trunk failed.
-1	javadoc	18	hadoop-ozone in trunk failed.
0	spotbugs	149	Used deprecated FindBugs config; considering switching to SpotBugs.
-1	findbugs	26	hadoop-ozone in trunk failed.
		_ Patch Compile Tests _
0	mvndep	18	Maven dependency ordering for patch
-1	mvninstall	33	hadoop-ozone in the patch failed.
-1	compile	26	hadoop-ozone in the patch failed.
-1	javac	53	hadoop-hdds generated 2 new + 25 unchanged - 2 fixed = 27 total (was 27)
-1	javac	26	hadoop-ozone in the patch failed.
-0	checkstyle	35	hadoop-hdds: The patch generated 46 new + 259 unchanged - 55 fixed = 305 total (was 314)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	667	patch has no errors when building and testing our client artifacts.
-1	javadoc	17	hadoop-hdds in the patch failed.
-1	javadoc	16	hadoop-ozone in the patch failed.
-1	findbugs	25	hadoop-ozone in the patch failed.
		_ Other Tests _
-1	unit	212	hadoop-hdds in the patch failed.
-1	unit	27	hadoop-ozone in the patch failed.
+1	asflicense	31	The patch does not generate ASF License warnings.
		3041

Reason	Tests
Failed junit tests	hadoop.hdds.scm.container.placement.algorithms.TestSCMContainerPlacementRackAware

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/15/artifact/out/Dockerfile
GITHUB PR	#1194
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 84fd38c81e89 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 3b06f0b
Default Java	1.8.0_222
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/15/artifact/out/branch-mvninstall-hadoop-ozone.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/15/artifact/out/branch-compile-hadoop-ozone.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/15/artifact/out/branch-javadoc-hadoop-hdds.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/15/artifact/out/branch-javadoc-hadoop-ozone.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/15/artifact/out/branch-findbugs-hadoop-ozone.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/15/artifact/out/patch-mvninstall-hadoop-ozone.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/15/artifact/out/patch-compile-hadoop-ozone.txt
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/15/artifact/out/diff-compile-javac-hadoop-hdds.txt
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/15/artifact/out/patch-compile-hadoop-ozone.txt
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/15/artifact/out/diff-checkstyle-hadoop-hdds.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/15/artifact/out/patch-javadoc-hadoop-hdds.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/15/artifact/out/patch-javadoc-hadoop-ozone.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/15/artifact/out/patch-findbugs-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/15/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/15/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/15/testReport/
Max. process+thread count	486 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/server-scm U: hadoop-hdds
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1194/15/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[ChenSammi]

Is the build system wrong? I don't think changed the code which cause the compile failure.

[elek]

/retest

[xiaoyuyao]

+1, I've merged the change to trunk.

[ChenSammi]

Thanks @xiaoyuyao for the code review and @elek for monitor the build result.