HDFS-14551 NN throws NPE if downgrade it during rolling upgrade from 3.x to 2.x

[Cosss7]

reference jira.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	91	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1	mvninstall	1302	trunk passed
+1	compile	65	trunk passed
+1	checkstyle	45	trunk passed
+1	mvnsite	73	trunk passed
+1	shadedclient	891	branch has no errors when building and testing our client artifacts.
+1	javadoc	62	trunk passed
0	spotbugs	188	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	183	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	65	the patch passed
+1	compile	61	the patch passed
+1	javac	61	the patch passed
+1	checkstyle	44	the patch passed
+1	mvnsite	78	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	831	patch has no errors when building and testing our client artifacts.
+1	javadoc	51	the patch passed
-1	findbugs	183	hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
-1	unit	6821	hadoop-hdfs in the patch failed.
-1	asflicense	34	The patch generated 1 ASF License warnings.
		10940

Reason	Tests
FindBugs	module:hadoop-hdfs-project/hadoop-hdfs
	Possible null pointer dereference of sectionName in org.apache.hadoop.hdfs.server.namenode.FSImageFormatProtobuf$Loader.loadInternal(RandomAccessFile, FileInputStream) Dereferenced at FSImageFormatProtobuf.java:sectionName in org.apache.hadoop.hdfs.server.namenode.FSImageFormatProtobuf$Loader.loadInternal(RandomAccessFile, FileInputStream) Dereferenced at FSImageFormatProtobuf.java:[line 311]
Failed junit tests	hadoop.hdfs.server.datanode.TestDirectoryScanner
	hadoop.hdfs.TestErasureCodingAddConfig
	hadoop.hdfs.TestRollingUpgradeRollback
	hadoop.hdfs.qjournal.server.TestJournalNodeSync

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/1/artifact/out/Dockerfile
GITHUB PR	#1128
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 90a6e0ab0ad3 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 4e66cb9
Default Java	1.8.0_212
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/1/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/1/testReport/
asflicense	https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/1/artifact/out/patch-asflicense-problems.txt
Max. process+thread count	2640 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/1/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	42	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1	mvninstall	1082	trunk passed
+1	compile	60	trunk passed
+1	checkstyle	39	trunk passed
+1	mvnsite	64	trunk passed
+1	shadedclient	723	branch has no errors when building and testing our client artifacts.
+1	javadoc	47	trunk passed
0	spotbugs	155	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	154	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	58	the patch passed
+1	compile	51	the patch passed
+1	javac	51	the patch passed
+1	checkstyle	34	the patch passed
+1	mvnsite	60	the patch passed
+1	whitespace	3	The patch has no whitespace issues.
+1	shadedclient	673	patch has no errors when building and testing our client artifacts.
+1	javadoc	45	the patch passed
-1	findbugs	161	hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
-1	unit	4982	hadoop-hdfs in the patch failed.
+1	asflicense	31	The patch does not generate ASF License warnings.
		8362

Reason	Tests
FindBugs	module:hadoop-hdfs-project/hadoop-hdfs
	Possible null pointer dereference of sectionName in org.apache.hadoop.hdfs.server.namenode.FSImageFormatProtobuf$Loader.loadInternal(RandomAccessFile, FileInputStream) Dereferenced at FSImageFormatProtobuf.java:sectionName in org.apache.hadoop.hdfs.server.namenode.FSImageFormatProtobuf$Loader.loadInternal(RandomAccessFile, FileInputStream) Dereferenced at FSImageFormatProtobuf.java:[line 311]
Failed junit tests	hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/2/artifact/out/Dockerfile
GITHUB PR	#1128
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 61f6d87ff78e 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / aebac6d
Default Java	1.8.0_212
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/2/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/2/testReport/
Max. process+thread count	4585 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/2/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	46	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1	mvninstall	1089	trunk passed
+1	compile	65	trunk passed
+1	checkstyle	39	trunk passed
+1	mvnsite	66	trunk passed
+1	shadedclient	750	branch has no errors when building and testing our client artifacts.
+1	javadoc	49	trunk passed
0	spotbugs	166	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	165	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	61	the patch passed
+1	compile	56	the patch passed
+1	javac	56	the patch passed
+1	checkstyle	37	the patch passed
+1	mvnsite	68	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	828	patch has no errors when building and testing our client artifacts.
+1	javadoc	53	the patch passed
-1	findbugs	245	hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
-1	unit	5136	hadoop-hdfs in the patch failed.
-1	asflicense	33	The patch generated 2 ASF License warnings.
		8851

Reason	Tests
FindBugs	module:hadoop-hdfs-project/hadoop-hdfs
	Possible null pointer dereference of sectionName in org.apache.hadoop.hdfs.server.namenode.FSImageFormatProtobuf$Loader.loadInternal(RandomAccessFile, FileInputStream) Dereferenced at FSImageFormatProtobuf.java:sectionName in org.apache.hadoop.hdfs.server.namenode.FSImageFormatProtobuf$Loader.loadInternal(RandomAccessFile, FileInputStream) Dereferenced at FSImageFormatProtobuf.java:[line 311]
Failed junit tests	hadoop.hdfs.server.namenode.snapshot.TestSnapRootDescendantDiff
	hadoop.hdfs.server.datanode.TestLargeBlockReport
	hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots
	hadoop.hdfs.server.namenode.snapshot.TestSnapshotDiffReport
	hadoop.hdfs.TestDFSInotifyEventInputStreamKerberized

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/3/artifact/out/Dockerfile
GITHUB PR	#1128
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux a5378be369ef 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / d086d05
Default Java	1.8.0_212
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/3/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/3/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/3/testReport/
asflicense	https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/3/artifact/out/patch-asflicense-problems.txt
Max. process+thread count	4299 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/3/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	45	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1	mvninstall	1205	trunk passed
+1	compile	54	trunk passed
+1	checkstyle	40	trunk passed
+1	mvnsite	61	trunk passed
+1	shadedclient	713	branch has no errors when building and testing our client artifacts.
+1	javadoc	46	trunk passed
0	spotbugs	161	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	159	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	57	the patch passed
+1	compile	52	the patch passed
+1	javac	52	the patch passed
+1	checkstyle	35	the patch passed
+1	mvnsite	58	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	752	patch has no errors when building and testing our client artifacts.
+1	javadoc	47	the patch passed
-1	findbugs	159	hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
-1	unit	5061	hadoop-hdfs in the patch failed.
-1	asflicense	33	The patch generated 1 ASF License warnings.
		8629

Reason	Tests
FindBugs	module:hadoop-hdfs-project/hadoop-hdfs
	Possible null pointer dereference of sectionName in org.apache.hadoop.hdfs.server.namenode.FSImageFormatProtobuf$Loader.loadInternal(RandomAccessFile, FileInputStream) Dereferenced at FSImageFormatProtobuf.java:sectionName in org.apache.hadoop.hdfs.server.namenode.FSImageFormatProtobuf$Loader.loadInternal(RandomAccessFile, FileInputStream) Dereferenced at FSImageFormatProtobuf.java:[line 311]
Failed junit tests	hadoop.hdfs.server.datanode.TestLargeBlockReport
	hadoop.hdfs.TestDFSStripedOutputStreamWithFailure
	hadoop.hdfs.TestDFSInotifyEventInputStreamKerberized
	hadoop.hdfs.server.namenode.TestNamenodeCapacityReport

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/4/artifact/out/Dockerfile
GITHUB PR	#1128
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 240b073eb5b5 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 70b4617
Default Java	1.8.0_212
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/4/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/4/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/4/testReport/
asflicense	https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/4/artifact/out/patch-asflicense-problems.txt
Max. process+thread count	4086 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/4/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	118	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1	mvninstall	1250	trunk passed
+1	compile	63	trunk passed
+1	checkstyle	50	trunk passed
+1	mvnsite	75	trunk passed
+1	shadedclient	904	branch has no errors when building and testing our client artifacts.
+1	javadoc	56	trunk passed
0	spotbugs	194	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	193	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	73	the patch passed
+1	compile	67	the patch passed
+1	javac	67	the patch passed
+1	checkstyle	48	the patch passed
+1	mvnsite	72	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	907	patch has no errors when building and testing our client artifacts.
+1	javadoc	53	the patch passed
-1	findbugs	185	hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
-1	unit	6100	hadoop-hdfs in the patch failed.
+1	asflicense	35	The patch does not generate ASF License warnings.
		10309

Reason	Tests
FindBugs	module:hadoop-hdfs-project/hadoop-hdfs
	Possible null pointer dereference of sectionName in org.apache.hadoop.hdfs.server.namenode.FSImageFormatProtobuf$Loader.loadInternal(RandomAccessFile, FileInputStream) Dereferenced at FSImageFormatProtobuf.java:sectionName in org.apache.hadoop.hdfs.server.namenode.FSImageFormatProtobuf$Loader.loadInternal(RandomAccessFile, FileInputStream) Dereferenced at FSImageFormatProtobuf.java:[line 311]
Failed junit tests	hadoop.hdfs.server.datanode.TestLargeBlockReport

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/5/artifact/out/Dockerfile
GITHUB PR	#1128
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux ade3e85245b8 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 397a563
Default Java	1.8.0_212
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/5/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/5/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/5/testReport/
Max. process+thread count	2606 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/5/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	42	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
-1	mvninstall	1242	root in trunk failed.
+1	compile	60	trunk passed
+1	checkstyle	46	trunk passed
+1	mvnsite	67	trunk passed
+1	shadedclient	783	branch has no errors when building and testing our client artifacts.
+1	javadoc	55	trunk passed
0	spotbugs	176	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	173	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	63	the patch passed
+1	compile	61	the patch passed
+1	javac	61	the patch passed
+1	checkstyle	39	the patch passed
+1	mvnsite	63	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	745	patch has no errors when building and testing our client artifacts.
+1	javadoc	49	the patch passed
-1	findbugs	175	hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
-1	unit	5017	hadoop-hdfs in the patch failed.
-1	asflicense	35	The patch generated 3 ASF License warnings.
		8765

Reason	Tests
FindBugs	module:hadoop-hdfs-project/hadoop-hdfs
	Possible null pointer dereference of sectionName in org.apache.hadoop.hdfs.server.namenode.FSImageFormatProtobuf$Loader.loadInternal(RandomAccessFile, FileInputStream) Dereferenced at FSImageFormatProtobuf.java:sectionName in org.apache.hadoop.hdfs.server.namenode.FSImageFormatProtobuf$Loader.loadInternal(RandomAccessFile, FileInputStream) Dereferenced at FSImageFormatProtobuf.java:[line 311]
Failed junit tests	hadoop.hdfs.TestWriteReadStripedFile

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/6/artifact/out/Dockerfile
GITHUB PR	#1128
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 40725b438d7f 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / e356e4f
Default Java	1.8.0_212
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/6/artifact/out/branch-mvninstall-root.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/6/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/6/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/6/testReport/
asflicense	https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/6/artifact/out/patch-asflicense-problems.txt
Max. process+thread count	4429 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1128/6/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.