-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HDDS-1713. ReplicationManager fail to find proper node topology based… #1112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you are removing this assertion because it makes the test flaky (node 2 and 3 may or may not be in the same rack, the only restriction is that they are in different one than nodes 0 and 1). If so, please also remove similar assertion from testFallback:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comments. Will remove last two assertions in testFallback.
|
💔 -1 overall
This message was automatically generated. |
|
Thanks @ChenSammi for working on this. Overall the change looks good to me. Few of the test failure seems related, can you please take a look at them? |
|
+1 for the latest change. I will merge it shortly. |
Add a putsAll API to the metadata store API. This allows for a delayed flush() call for underlying stores that require a flush() after write such as Kafka. Author: Daniel Nishimura <[email protected]> Reviewers: mynameborat <[email protected]> Closes apache#1112 from dnishimura/samza-2276-metadata-store-putall-api and squashes the following commits: 830b5994 [Daniel Nishimura] Update javadoc for MetadataStore#putAll e52d884c [Daniel Nishimura] SAMZA-2271: Add Metdata store putAll API
… Datanode details from heartbeat
#1008