Skip to content

HADOOP-16595. [pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 13, 2020
Merged

HADOOP-16595. [pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf #1

merged 2 commits into from
Jan 13, 2020

Conversation

@vinayakumarb
Copy link
Contributor

No description provided.

@vinayakumarb vinayakumarb force-pushed the trunk branch 2 times, most recently from 2c33176 to 88082b7 Compare September 27, 2019 17:13
Apache9
Apache9 requested changes Sep 28, 2019
View reviewed changes
@vinayakumarb
Copy link
Contributor Author

Will update the PR later today

@vinayakumarb vinayakumarb requested a review from Apache9 October 9, 2019 19:26
jojochuang
jojochuang reviewed Oct 9, 2019
View reviewed changes
@vinayakumarb vinayakumarb mentioned this pull request Oct 10, 2019
Merged
ayushtkn
ayushtkn reviewed Oct 10, 2019
View reviewed changes
ayushtkn
ayushtkn reviewed Oct 10, 2019
View reviewed changes
ayushtkn
ayushtkn reviewed Oct 10, 2019
View reviewed changes
ayushtkn
ayushtkn reviewed Oct 10, 2019
View reviewed changes
ayushtkn
ayushtkn reviewed Dec 19, 2019
View reviewed changes
ayushtkn
ayushtkn reviewed Dec 19, 2019
View reviewed changes
@ayushtkn
Copy link
Member

Thanx @vinayakumarb for the work here, can you give a check to the scripts in dev-support.
I tried create-release and that seems to be failing.

@vinayakumarb
Copy link
Contributor Author

Thanks @ayushtkn for reviews.

@Apache9 @jojochuang Please take a look latest change as well. Thanks

ayushtkn
ayushtkn approved these changes Jan 4, 2020
View reviewed changes
Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanx @vinayakumarb for the updates.
LGTM

Apache9
Apache9 approved these changes Jan 4, 2020
View reviewed changes
Copy link

@Apache9 Apache9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Still feel a bit strange that why we bind to protobuf 3.7 but not a blocker. Can be a follow on.

brahmareddybattula
brahmareddybattula reviewed Jan 10, 2020
View reviewed changes
@vinayakumarb
HADOOP-16595. [pb-upgrade] Create hadoop-thirdparty artifact to have …
8f8b397 
…shaded protobuf. Addendum fixed message in script
@vinayakumarb vinayakumarb self-assigned this Jan 13, 2020
@vinayakumarb vinayakumarb merged commit fd78dcf into apache:trunk Jan 13, 2020
@vinayakumarb
Copy link
Contributor Author

Merged.
Thanks @Apache9 @ayushtkn @jojochuang @brahmareddybattula for reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brahmareddybattula brahmareddybattula brahmareddybattula left review comments

@jojochuang jojochuang jojochuang left review comments

@Apache9 Apache9 Apache9 approved these changes

@ayushtkn ayushtkn ayushtkn approved these changes

Assignees

@vinayakumarb vinayakumarb

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vinayakumarb @ayushtkn @brahmareddybattula @jojochuang @Apache9