Skip to content

[FLINK-22536][runtime] Promote the critical log in FineGrainedSlotMan… #15850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[FLINK-22536][runtime] Promote the critical log in FineGrainedSlotMan… #15850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...in/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultSlotStatusSyncer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ public CompletableFuture<Void> allocateSlot(
taskManager.get().getTaskExecutorConnection().getTaskExecutorGateway();
final ResourceID resourceId = taskManager.get().getTaskExecutorConnection().getResourceID();

LOG.debug(
LOG.info(
"Starting allocation of slot {} from {} for job {} with resource profile {}.",
allocationId,
resourceId,
Expand Down Expand Up @@ -198,7 +198,7 @@ public CompletableFuture<Void> allocateSlot(
public void freeSlot(AllocationID allocationId) {
Preconditions.checkNotNull(allocationId);
checkStarted();
LOG.debug("Freeing slot {}.", allocationId);
LOG.info("Freeing slot {}.", allocationId);

final Optional<TaskManagerSlotInformation> slotOptional =
taskManagerTracker.getAllocatedOrPendingSlot(allocationId);
Expand Down Expand Up @@ -250,6 +250,7 @@ public boolean reportSlotStatus(InstanceID instanceId, SlotReport slotReport) {
// the next slot report or the acknowledgement of the allocation request.
if (!reportedAllocationIds.contains(slot.getAllocationId())
&& slot.getState() == SlotState.ALLOCATED) {
LOG.info("Freeing slot {} by slot report.", slot.getAllocationId());
taskManagerTracker.notifySlotStatus(
slot.getAllocationId(),
slot.getJobId(),
Expand Down
6 changes: 3 additions & 3 deletions ...ain/java/org/apache/flink/runtime/resourcemanager/slotmanager/FineGrainedSlotManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ public boolean registerTaskManager(
ResourceProfile totalResourceProfile,
ResourceProfile defaultSlotResourceProfile) {
checkInit();
LOG.debug(
LOG.info(
"Registering task executor {} under {} at the slot manager.",
taskExecutorConnection.getResourceID(),
taskExecutorConnection.getInstanceID());
Expand Down Expand Up @@ -400,7 +400,7 @@ private Optional<PendingTaskManagerId> findMatchingPendingTaskManager(
public boolean unregisterTaskManager(InstanceID instanceId, Exception cause) {
checkInit();

LOG.debug("Unregistering task executor {} from the slot manager.", instanceId);
LOG.info("Unregistering task executor {} from the slot manager.", instanceId);

if (taskManagerTracker.getRegisteredTaskManager(instanceId).isPresent()) {
Set<AllocationID> allocatedSlots =
Expand Down Expand Up @@ -705,7 +705,7 @@ private void releaseIdleTaskExecutorIfPossible(TaskManagerInfo taskManagerInfo)

private void releaseIdleTaskExecutor(InstanceID timedOutTaskManagerId) {
final FlinkException cause = new FlinkException("TaskManager exceeded the idle timeout.");
LOG.debug(
LOG.info(
"Release TaskManager {} because it exceeded the idle timeout.",
timedOutTaskManagerId);
resourceActions.releaseResource(timedOutTaskManagerId, cause);
Expand Down