Skip to content

[FLINK-37103] The parameters passed when calling method FactoryUtil.createDynamicTableSource are inconsistent #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[FLINK-37103] The parameters passed when calling method FactoryUtil.createDynamicTableSource are inconsistent #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...onnector-hive/src/main/java/org/apache/flink/connectors/hive/HiveDynamicTableFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
import org.apache.hadoop.mapred.JobConf;
import org.apache.hadoop.mapreduce.lib.input.FileInputFormat;

import java.util.Collections;
import java.util.Set;

import static org.apache.flink.connectors.hive.HiveOptions.STREAMING_SOURCE_ENABLE;
Expand Down Expand Up @@ -79,6 +80,7 @@ public DynamicTableSink createDynamicTableSink(Context context) {
null,
context.getObjectIdentifier(),
context.getCatalogTable(),
Collections.emptyMap(),
context.getConfiguration(),
context.getClassLoader(),
context.isTemporary());
Expand Down Expand Up @@ -114,6 +116,7 @@ public DynamicTableSource createDynamicTableSource(Context context) {
null,
context.getObjectIdentifier(),
context.getCatalogTable(),
Collections.emptyMap(),
context.getConfiguration(),
context.getClassLoader(),
context.isTemporary());
Expand Down
3 changes: 3 additions & 0 deletions ...ctor-hive/src/test/java/org/apache/flink/connectors/hive/HiveDynamicTableFactoryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
import org.junit.Test;

import java.time.Duration;
import java.util.Collections;

import static org.apache.flink.connector.file.table.FileSystemConnectorOptions.PARTITION_TIME_EXTRACTOR_CLASS;
import static org.apache.flink.connector.file.table.FileSystemConnectorOptions.PARTITION_TIME_EXTRACTOR_KIND;
Expand Down Expand Up @@ -274,6 +275,7 @@ private DynamicTableSource getTableSource(String tableName) throws Exception {
hiveCatalog.getFactory().orElseThrow(IllegalStateException::new),
tableIdentifier,
tableEnvInternal.getCatalogManager().resolveCatalogTable(catalogTable),
Collections.emptyMap(),
tableEnv.getConfig(),
Thread.currentThread().getContextClassLoader(),
false);
Expand All @@ -290,6 +292,7 @@ private DynamicTableSink getTableSink(String tableName) throws Exception {
hiveCatalog.getFactory().orElseThrow(IllegalStateException::new),
tableIdentifier,
tableEnvInternal.getCatalogManager().resolveCatalogTable(catalogTable),
Collections.emptyMap(),
tableEnv.getConfig(),
Thread.currentThread().getContextClassLoader(),
false);
Expand Down
2 changes: 2 additions & 0 deletions ...k-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveLookupJoinITCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
import java.time.Duration;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.Comparator;
import java.util.List;

Expand Down Expand Up @@ -436,6 +437,7 @@ private FileSystemLookupFunction<HiveTablePartition> getLookupFunction(String ta
tableEnvInternal
.getCatalogManager()
.resolveCatalogTable(catalogTable),
Collections.emptyMap(),
tableEnv.getConfig(),
Thread.currentThread().getContextClassLoader(),
false);
Expand Down
2 changes: 2 additions & 0 deletions ...k-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableFactoryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ void testHiveTable() throws Exception {
catalog.getFactory().orElseThrow(IllegalStateException::new),
ObjectIdentifier.of("mycatalog", "mydb", "mytable"),
new ResolvedCatalogTable(table, schema),
Collections.emptyMap(),
new Configuration(),
Thread.currentThread().getContextClassLoader(),
false);
Expand All @@ -154,6 +155,7 @@ void testHiveTable() throws Exception {
catalog.getFactory().orElseThrow(IllegalStateException::new),
ObjectIdentifier.of("mycatalog", "mydb", "mytable"),
new ResolvedCatalogTable(table, schema),
Collections.emptyMap(),
new Configuration(),
Thread.currentThread().getContextClassLoader(),
false);
Expand Down