-
Notifications
You must be signed in to change notification settings - Fork 49
[Feature] Implemenet Kafka-based state store #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
1d218c1
to
9d35542
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Please see my comments below.
tools/lint.sh
Outdated
echo "Using uv for dependency management" | ||
pushd python | ||
uv sync --extra lint | ||
uv sync --extra lint --index-strategy unsafe-best-match |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:( This is to mitigate the issue where our internal pip repo does not have the necessary dependency thus i have to add this to the lint for the lint to work. I will revert it to keep the main branch clean.
api/src/main/java/org/apache/flink/agents/api/configuration/AgentConfigOptions.java
Show resolved
Hide resolved
runtime/src/main/java/org/apache/flink/agents/runtime/actionstate/ActionStateKafkaSeder.java
Show resolved
Hide resolved
runtime/src/main/java/org/apache/flink/agents/runtime/actionstate/KafkaActionStateStore.java
Show resolved
Hide resolved
api/src/main/java/org/apache/flink/agents/api/configuration/AgentConfigOptions.java
Outdated
Show resolved
Hide resolved
runtime/src/main/java/org/apache/flink/agents/runtime/actionstate/KafkaActionStateStore.java
Outdated
Show resolved
Hide resolved
runtime/src/main/java/org/apache/flink/agents/runtime/actionstate/KafkaActionStateStore.java
Show resolved
Hide resolved
runtime/src/main/java/org/apache/flink/agents/runtime/actionstate/ActionStateStore.java
Show resolved
Hide resolved
# Conflicts: # runtime/src/main/java/org/apache/flink/agents/runtime/actionstate/ActionStateUtil.java # runtime/src/main/java/org/apache/flink/agents/runtime/actionstate/KafkaActionStateStore.java # Conflicts: # runtime/src/main/java/org/apache/flink/agents/runtime/actionstate/KafkaActionStateStore.java
e756bd4
to
86148d2
Compare
86148d2
to
94d1068
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. LGTM.
@xintongsong Could you take a look at the PR?
runtime/src/main/java/org/apache/flink/agents/runtime/actionstate/KafkaActionStateStore.java
Show resolved
Hide resolved
runtime/src/main/java/org/apache/flink/agents/runtime/operator/ActionExecutionOperator.java
Show resolved
Hide resolved
runtime/src/main/java/org/apache/flink/agents/runtime/operator/ActionExecutionOperator.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Linked issue: #153
Purpose of change
The main changes in this commits are
Tests
All of them are covered by unit tests.
API
Documentation