Skip to content

Conversation

letaoj
Copy link
Contributor

@letaoj letaoj commented Sep 17, 2025

Linked issue: #153

Purpose of change

The main changes in this commits are

  • Introduce the Kafka-based state store backend for Flink Agent to use
  • Introduce Seder for the ActionState
  • Introduce Custom Partitioner used to partition the Kafka record

Tests

All of them are covered by unit tests.

API

Documentation

@letaoj
Copy link
Contributor Author

letaoj commented Sep 17, 2025

I will need to rebase after the API change is merged.. Updated.

@letaoj letaoj changed the title [api] Add TaskActionState API to persist task action state [Feature] Implemenet Kafka-based state store Sep 17, 2025
@letaoj letaoj force-pushed the kafka-state-store branch 5 times, most recently from 1d218c1 to 9d35542 Compare September 21, 2025 05:16
@letaoj letaoj marked this pull request as ready for review September 21, 2025 05:17
Copy link
Contributor

@Sxnan Sxnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Please see my comments below.

tools/lint.sh Outdated
echo "Using uv for dependency management"
pushd python
uv sync --extra lint
uv sync --extra lint --index-strategy unsafe-best-match
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:( This is to mitigate the issue where our internal pip repo does not have the necessary dependency thus i have to add this to the lint for the lint to work. I will revert it to keep the main branch clean.

# Conflicts:
#	runtime/src/main/java/org/apache/flink/agents/runtime/actionstate/ActionStateUtil.java
#	runtime/src/main/java/org/apache/flink/agents/runtime/actionstate/KafkaActionStateStore.java

# Conflicts:
#	runtime/src/main/java/org/apache/flink/agents/runtime/actionstate/KafkaActionStateStore.java
@letaoj letaoj force-pushed the kafka-state-store branch 3 times, most recently from e756bd4 to 86148d2 Compare September 22, 2025 20:57
@letaoj letaoj requested a review from Sxnan September 23, 2025 04:26
Copy link
Contributor

@Sxnan Sxnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. LGTM.

@xintongsong Could you take a look at the PR?

Copy link
Contributor

@xintongsong xintongsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xintongsong xintongsong merged commit 23bce98 into apache:main Sep 24, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants