FELIX-6515: Add global write lock to write back cfg files #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Writing a file is a 2 step process where the file is created empty and then filled * There is a race-condition, where the DirectoryWatcher might pick up the creation of the * empty file. This empty file will be written back to disk on a follow-up CM_UPDATED event. * Using the global write lock will block the DirectoryWatcher to wait for the write to finish * and therefore never to read an empty file.
Author
|
I'll try to create a test for this race-condition but doing that might be hard to accomplish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing a file is a 2 step process where the file is created empty and then filled
There is a race-condition, where the DirectoryWatcher might pick up the creation of the empty file.
This empty file will be written back to disk on a follow-up CM_UPDATED event.
Using the global write lock will block the DirectoryWatcher to wait for the write to finish and therefore never to read an empty file.