Skip to content

Conversation

@andygrove
Copy link
Member

Which issue does this PR close?

Closes #2

Rationale for this change

One DataFrame implementation is better than two.

What changes are included in this PR?

  • Remove Ballista DataFrame
  • Move Ballista collect() method to BallistaContext

Are there any user-facing changes?

Yes, users now get DataFusion dataframes from the BallistaContext.

If there are user-facing changes then we may require documentation to be updated before approving the PR.

There isn't really any documentation yet to update.

If there are any breaking changes to public APIs, please add the breaking change label.

This is a breaking change but Ballista is < 1.0.0 so expected.

@codecov-commenter
Copy link

Codecov Report

Merging #48 (c73c1f3) into master (9ba214a) will increase coverage by 0.11%.
The diff coverage is 0.00%.

❗ Current head c73c1f3 differs from pull request most recent head 794dbce. Consider uploading reports for the commit 794dbce to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   76.24%   76.36%   +0.11%     
==========================================
  Files         134      134              
  Lines       23051    23017      -34     
==========================================
  Hits        17576    17576              
+ Misses       5475     5441      -34     
Impacted Files Coverage Δ
ballista/rust/client/src/context.rs 0.00% <0.00%> (ø)
benchmarks/src/bin/tpch.rs 35.07% <0.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ba214a...794dbce. Read the comment docs.

@andygrove
Copy link
Member Author

@alamb @jorgecarleitao Any objection to me merging this one?

Copy link
Member

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great simplification. :shipit: for me 👍

@andygrove andygrove merged commit 589f355 into apache:master Apr 25, 2021
@andygrove andygrove deleted the remove-ballista-dataframe branch April 25, 2021 13:47
@houqp houqp added the api change Changes the API exposed to users of the crate label Jul 29, 2021
alamb pushed a commit that referenced this pull request Jun 14, 2022
* chore: default precision and scale for cast decimal

improve

ok

* fix decimal type max precision size (#48)

* minor

* add tests
waynexia referenced this pull request in waynexia/arrow-datafusion Jun 20, 2022
* chore: default precision and scale for cast decimal

improve

ok

* fix decimal type max precision size (#48)

* minor

* add tests
unkloud pushed a commit to unkloud/datafusion that referenced this pull request Mar 23, 2025
H0TB0X420 pushed a commit to H0TB0X420/datafusion that referenced this pull request Oct 7, 2025
…che#48)

* feat: add table_exist funcation for dataframe

* fix: flake E712
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api change Changes the API exposed to users of the crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ballista should not have separate DataFrame implementation

4 participants