Skip to content

Conversation

@AdamGS
Copy link
Contributor

@AdamGS AdamGS commented Sep 15, 2025

Which issue does this PR close?

Rationale for this change

Aside from general maintenance and performance improvements, it includes casting support for decimal 32/64, which should be merged before #17501.

What changes are included in this PR?

  1. Upgrade arrow/parquet to the 56.1.0 release
  2. Fix a couple of calls to now deprecated functionality in parquet.
  3. A few tests show lower memory usage, but the root cause isn't clear to me, nothing obvious stood out from the arrow changelog.

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added datasource Changes to the datasource crate physical-plan Changes to the physical-plan crate labels Sep 15, 2025
let mut reader =
ParquetMetaDataReader::new_with_metadata(m).with_page_indexes(true);
let mut reader = ParquetMetaDataReader::new_with_metadata(m)
.with_page_index_policy(PageIndexPolicy::Required);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the exact same behavior, there's even a From<bool> for PageIndexPolicy implementation that does the same thing.

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Sep 15, 2025
@alamb
Copy link
Contributor

alamb commented Sep 15, 2025

I also made a PR to do this here:

One thing I am still trying to figure out with @nuno-faria is the IO changes with predicate pushdown

@alamb
Copy link
Contributor

alamb commented Sep 15, 2025

Thank you for this PR

@AdamGS
Copy link
Contributor Author

AdamGS commented Sep 15, 2025

That's my bad 🤦 should probably have looked specifically at your PRs. I'll close this one.

@AdamGS AdamGS closed this Sep 15, 2025
@alamb
Copy link
Contributor

alamb commented Sep 15, 2025

That's my bad 🤦 should probably have looked specifically at your PRs. I'll close this one.

No worry -- it is actually my bad I should not have kept the other PR waiting so long. I'll polish that one up and get it reviewed and hopefully ready to go

@alamb alamb mentioned this pull request Sep 15, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

datasource Changes to the datasource crate physical-plan Changes to the physical-plan crate sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants