Do not repartition sorted inputs SortPreservingMerge
#1748
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Along with #1732, Fixes #423 (the last part).
re #424
Rationale for this change
Repartitioning the input to an operator that relies on its input to be sorted is incorrect as the repartitioning will intermix the partitions and effectively "unsort" the input stream
We found this in IOx here https://github.com/influxdata/influxdb_iox/pull/3633#issuecomment-1030126757
Here is a picture showing the problem:
The streams need to remain the way they were
What changes are included in this PR?
SortPreservingMergeoperatorAre there any user-facing changes?
Probably not (yet) as
SortPreservingMergeisn't used as part of SQL planningcc @tustvold @Dandandan