Refactor DataSourceExec::try_swapping_with_projection to simplify and remove abstraction leakage #17395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… remove abstraction leakage
adriangb
changed the title
adriangb
commented
Sep 3, 2025
Comment on lines
-331
to
-346
| // Project the equivalence properties to the new schema | ||
| let projected_eq_properties = self | ||
| .cache | ||
| .eq_properties | ||
| .project(&projection_mapping, new_data_source_exec.schema()); | ||
|
|
||
| let preserved_exec = DataSourceExec { | ||
| data_source: Arc::clone(&new_data_source_exec.data_source), | ||
| cache: PlanProperties::new( | ||
| projected_eq_properties, | ||
| new_data_source_exec.cache.partitioning.clone(), | ||
| new_data_source_exec.cache.emission_type, | ||
| new_data_source_exec.cache.boundedness, | ||
| ) | ||
| .with_scheduling_type(new_data_source_exec.cache.scheduling_type), | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
We get to remove all of this complexity now 😄
Collaborator
blaginin
reviewed
Sep 3, 2025
datafusion/datasource/src/memory.rs
Outdated
| .transpose() | ||
| .transpose()?; | ||
|
|
||
| Ok(res) |
blaginin
approved these changes
Sep 3, 2025
Collaborator
blaginin
left a comment
blaginin
left a comment
There was a problem hiding this comment.
much cleaner, thank you for that!
github-actions
bot
added
the
documentation
Contributor
Author
|
Thanks for the review @blaginin ! I also added a note to the upgrade guide. |
adriangb
commented
Sep 3, 2025
| } | ||
| } | ||
|
|
||
| pub type ProjectionExpr = (Arc<dyn PhysicalExpr>, String); |
Contributor
Author
There was a problem hiding this comment.
I recommend a future PR transform this into a struct with named fields. That will be a breaking change so I am not going to do it in this PR, it should be done in isolation.
destrex271
pushed a commit
to destrex271/datafusion
that referenced
this pull request
Sep 5, 2025
… remove abstraction leakage (apache#17395)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies
try_swapping_with_projectionby: