#16994 Ensure CooperativeExec#maintains_input_order returns a Vec of the correct size #16995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ec of the correct size
Contributor
Author
|
@alamb this one might require a 49.0.1 😬 |
alamb
reviewed
Jul 31, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @pepijnve
I have a suggestion on testing: #16994 (comment),
Contributor
I added it to a "Maybe even 49.0.1" list on |
Contributor
Author
|
I added a number of invariant checks as suggested in #16994 (comment) |
Add checks that verify the length of the vectors returned by methods that need to return a value per child.
alamb
reviewed
Aug 1, 2025
|
|
||
| /// Checks a set of invariants that apply to all ExecutionPlan implementations. | ||
| /// Returns an error if the given node does not conform. | ||
| pub fn check_default_invariants<P: ExecutionPlan + ?Sized>( |
alamb
approved these changes
Aug 1, 2025
xudong963
approved these changes
Aug 2, 2025
Contributor
|
Thanks again @pepijnve and @xudong963 |
pepijnve
added a commit
to pepijnve/datafusion
that referenced
this pull request
Aug 7, 2025
…ec of the correct size (apache#16995) * apache#16994 Ensure CooperativeExec#maintains_input_order returns a Vec of the correct size * apache#16994 Extend default ExecutionPlan invariant checks Add checks that verify the length of the vectors returned by methods that need to return a value per child. (cherry picked from commit 2968331)
xudong963
pushed a commit
that referenced
this pull request
Aug 7, 2025
…the correct size (#16995) (#17068) * #16994 Ensure CooperativeExec#maintains_input_order returns a Vec of the correct size * #16994 Extend default ExecutionPlan invariant checks Add checks that verify the length of the vectors returned by methods that need to return a value per child. (cherry picked from commit 2968331)
hknlof
pushed a commit
to hknlof/datafusion
that referenced
this pull request
Aug 20, 2025
…ec of the correct size (apache#16995) * apache#16994 Ensure CooperativeExec#maintains_input_order returns a Vec of the correct size * apache#16994 Extend default ExecutionPlan invariant checks Add checks that verify the length of the vectors returned by methods that need to return a value per child.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
CooperativeExecincorrectly implementsmaintains_input_order#16994.Rationale for this change
The initial implementation of
CooperativeExec#maintains_input_orderis not correct and is likely to return aVecwith the wrong size.What changes are included in this PR?
Update the implementation of
maintains_input_ordertovec![true; self.children().len()]sinceCooperativeExecdoes not modify input order in any way.Are these changes tested?
Still working on unit test(s) that demonstrate the problem.
Are there any user-facing changes?
No