Skip to content

Draft: Parse literal to different types #15202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Draft: Parse literal to different types #15202

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efa6523
parse as numeric
jayzhan211 Mar 13, 2025
07f9366
round trip check
jayzhan211 Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion datafusion/sql/src/expr/value.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,19 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
) -> Result<Expr> {
match value {
Value::Number(n, _) => self.parse_sql_number(&n, false),
Value::SingleQuotedString(s) | Value::DoubleQuotedString(s) => Ok(lit(s)),
Value::SingleQuotedString(s) | Value::DoubleQuotedString(s) => {
let lit_val = if let Some(parsed) = s.parse::<i64>().ok().filter(|p| p.to_string() == s) {
lit(parsed)
} else if let Some(parsed) = s.parse::<f32>().ok().filter(|p| p.to_string() == s) {
lit(parsed)
} else if let Some(parsed) = s.parse::<f64>().ok().filter(|p| p.to_string() == s) {
lit(parsed)
} else {
lit(s)
};

Ok(lit_val)
}
Value::Null => Ok(Expr::Literal(ScalarValue::Null)),
Value::Boolean(n) => Ok(lit(n)),
Value::Placeholder(param) => {
Expand Down
Loading